[dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

[dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

[David Marchand]

testpmd depends on ethdev, which itself depends on meter.
No need for an explicit dependency, since no testpmd code directly calls
in the meter library.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-pmd/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index b5a0f7b620..21d50e92d0 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -28,7 +28,7 @@ sources = files(
         'util.c',
 )
 
-deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'meter', 'bus_pci']
+deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']
 if dpdk_conf.has('RTE_LIB_BITRATESTATS')
     deps += 'bitratestats'
 endif
-- 
2.23.0

[dpdk-dev] [PATCH 2/2] app/testpmd: remove double dependency on bitrate

[David Marchand]

No need for double dependency, once is enough.
While at it, sort alphabetically.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-pmd/meson.build | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index 21d50e92d0..b05c531c7f 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -29,20 +29,21 @@ sources = files(
 )
 
 deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']
-if dpdk_conf.has('RTE_LIB_BITRATESTATS')
-    deps += 'bitratestats'
-endif
-if dpdk_conf.has('RTE_LIB_PDUMP')
-    deps += 'pdump'
+if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
+    deps += 'crypto_scheduler'
 endif
 if dpdk_conf.has('RTE_LIB_BITRATESTATS')
     deps += 'bitratestats'
 endif
+if dpdk_conf.has('RTE_LIB_BPF')
+    sources += files('bpf_cmd.c')
+    deps += 'bpf'
+endif
 if dpdk_conf.has('RTE_LIB_LATENCYSTATS')
     deps += 'latencystats'
 endif
-if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
-    deps += 'crypto_scheduler'
+if dpdk_conf.has('RTE_LIB_PDUMP')
+    deps += 'pdump'
 endif
 if dpdk_conf.has('RTE_NET_BOND')
     deps += 'net_bond'
@@ -59,10 +60,6 @@ endif
 if dpdk_conf.has('RTE_NET_DPAA')
     deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
 endif
-if dpdk_conf.has('RTE_LIB_BPF')
-    sources += files('bpf_cmd.c')
-    deps += 'bpf'
-endif
 jansson_dep = dependency('jansson', required: false, method: 'pkg-config')
 if jansson_dep.found()
     dpdk_conf.set('RTE_HAS_JANSSON', 1)
-- 
2.23.0

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

[Bruce Richardson]

On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote:
> testpmd depends on ethdev, which itself depends on meter.
> No need for an explicit dependency, since no testpmd code directly calls
> in the meter library.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: remove unneeded dependency on meter

[Ferruh Yigit]

On 11/5/2021 1:40 PM, Bruce Richardson wrote:
> On Fri, Nov 05, 2021 at 02:30:17PM +0100, David Marchand wrote:
>> testpmd depends on ethdev, which itself depends on meter.
>> No need for an explicit dependency, since no testpmd code directly calls
>> in the meter library.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: remove double dependency on bitrate

[Ferruh Yigit]

On 11/5/2021 1:30 PM, David Marchand wrote:
> No need for double dependency, once is enough.
> While at it, sort alphabetically.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

     Fixes: fac83b3ef8ac ("app: fix missing dependencies")
     Cc: stable@dpdk.org

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.