DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"shaikh@niometrics.com" <shaikh@niometrics.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Xing,  Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i
Date: Mon, 2 Aug 2021 00:17:52 +0000	[thread overview]
Message-ID: <8d87678956ad49f9bca3e9f0af9991fd@intel.com> (raw)
In-Reply-To: <DM5PR11MB178726C45B38C36EF28701028C139@DM5PR11MB1787.namprd11.prod.outlook.com>

Hi Shahed, Could you answer Wenzhuo' s question?


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lu, Wenzhuo
> Sent: Wednesday, July 14, 2021 9:06 AM
> To: shaikh@niometrics.com
> Cc: dev@dpdk.org; stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e: fix compilation failure on
> core-avx-i
> 
> Hi Shahed,
> 
> 
> 
> > -----Original Message-----
> 
> > From: Shahed Shaikh
> <shaikh@niometrics.com<mailto:shaikh@niometrics.com>>
> 
> > Sent: Tuesday, June 22, 2021 5:37 PM
> 
> > To: Xing, Beilei <beilei.xing@intel.com<mailto:beilei.xing@intel.com>>
> 
> > Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Shahed Shaikh
> <shaikh@niometrics.com<mailto:shaikh@niometrics.com>>;
> 
> > stable@dpdk.org<mailto:stable@dpdk.org>
> 
> > Subject: [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i
> 
> >
> 
> > i40e_rxtx_vec_sse.c fails to compile with below configuration:
> 
> > - #define RTE_LIBRTE_I40E_16BYTE_RX_DESC 1 in config/rte_config.h
> 
> > - cpu=core-axv-i
> 
> > - gcc which supports -mavx2 (e.g. gcc 4.8.5)
> 
> >
> 
> > This is because commit 0604b1f2208f ("net/i40e: fix crash in AVX512")
> 
> > added
> 
> > i40e_rxq_rearm_common() to i40e_rxtx_vec_common.h which is included by
> 
> > i40e_rxtx_vec_sse.c.
> 
> >
> 
> > This function is enabled for compilation if CC_AVX2_SUPPORT is defined.
> 
> > As per drivers/net/i40e/meson.build, CC_AVX2_SUPPORT is defined when
> 
> > either CPU supports __AVX2__ or compiler supports -mavx2 option.
> 
> >
> 
> > So for given configuration, CC_AVX2_SUPPORT gets defined but we don't
> 
> > pass -mavx2 explicitly to gcc while compiling i40e_rxtx_vec_sse.c.
> 
> Looks like it's better and more clear if a new specific avx head file is added.
> 
> Just want to understand more about the problem. I don't see the same
> problem when using 'gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC)',
> don't understand why -mavx2 is missing.
> 
> And more, if so, why the avx2 code doesn't meet the same problem?
> 
> Thanks.
> 
> 
> 
> > Hence it fails due to avx2 specific code from i40e_rxq_rearm_command().
> 
> >
> 
> > This patch tries to fix the compilation by moving
> 
> > i40e_rxq_rearm_common() to a new header file which will only be
> 
> > included by i40e_rxtx_vec_avx2.c and i40e_rxtx_vec_avx512.c.
> 
> >
> 
> > Fixes: 0604b1f2208f ("net/i40e: fix crash in AVX512")
> 
> > Cc: stable@dpdk.org<mailto:stable@dpdk.org>
> 
> >
> 
> > Signed-off-by: Shahed Shaikh
> <shaikh@niometrics.com<mailto:shaikh@niometrics.com>>


  reply	other threads:[~2021-08-02  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  1:06 Lu, Wenzhuo
2021-08-02  0:17 ` Zhang, Qi Z [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-22  9:37 Shahed Shaikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d87678956ad49f9bca3e9f0af9991fd@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaikh@niometrics.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).