From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8378AA00C5; Tue, 21 Jun 2022 14:19:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F137D4281A; Tue, 21 Jun 2022 14:19:34 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by mails.dpdk.org (Postfix) with ESMTP id 52A4D40151; Tue, 21 Jun 2022 14:19:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OBVbCfAbLow9ig8KggmTF4YGOopH3JPSVAhXlrbiPdxupJE6zuZll89mf40bhZGivMrZiyK0yx+EVny2paAIALFKQ+yyxGv30sz2xyXY/AWwiJsQOTTpCzhj+9RrxmrFteasijmFhGwXynh86edsTtXS0XTUFyzxc+CkRozKs74k54iItgZtkVj4C53EKgOasfefn3Iz/GEOnpHqRF5j79HMALUcZyOwMZ9BNgIBu/5IzKRNKBkgc/xoDQQoJHAbatanOYZxPpVF2bXWdiw+V2djcfe9oQlzY22NsjR9FbgHMZ9FyA9Gbn29zgKctc3SA4BKKsN324qk6iRrnp7o/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t8z0S9fn7oQ/m6uHWxthmHH3rpoBbcGe9YLsLUkYOwA=; b=FP/6a+O+diGOA4RLElXOOIu567oy/cO2dRjMC4bFk4Pjp7Ki6VhFdsUBMg70fkgc9ilaEJDTCn5tssqiTCuJOZ/+75CNqTx16VKh8YYvk1h4ZlnAX55XHUr94agDDMENM/4vIxeKdcmaPMtFU0EbK6aBGEYsQdSorkl+xPs5OgaWcRk+W3huRqXC7updeOJAW3t1OdWyb2y7I2TL+gmwBT6jE/Q4lxg3y2OE2bhzIOjJoMXEaxd+ze//lGACt1n5Xfy9nIWXJLDqoVgoQB1ZMo2FKJtZJ4pnmaiXeRENHFQksoTq6CGWyhyj2/c7MMcFalwvh/5tOaipioCpg195CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8z0S9fn7oQ/m6uHWxthmHH3rpoBbcGe9YLsLUkYOwA=; b=knowWIEUj294E6YAS1MB+P1WV+0XcJCtYbHZ2ucCsOES5vRBuRAvp714PJmxuUs+WjdSc/ftROlsx8Q6MuG8rDjt/ina9QGWV8/AbxHkT96aHGmDz9LxkYQKQBL08MisPX9uJ9nCY+YS7hNACoI6Mb8b+DfJ1xIWkpWX2ejnWxs= Received: from DS7PR03CA0152.namprd03.prod.outlook.com (2603:10b6:5:3b2::7) by SA2PR02MB7739.namprd02.prod.outlook.com (2603:10b6:806:14d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 12:19:30 +0000 Received: from DM3NAM02FT039.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::c3) by DS7PR03CA0152.outlook.office365.com (2603:10b6:5:3b2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Tue, 21 Jun 2022 12:19:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT039.mail.protection.outlook.com (10.13.5.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 12:19:29 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 21 Jun 2022 13:19:28 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 21 Jun 2022 13:19:28 +0100 Envelope-to: jiawenwu@trustnetic.com, stable@dpdk.org, dev@dpdk.org Received: from [10.71.119.54] (port=9599) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3cqu-0003XB-0V; Tue, 21 Jun 2022 13:19:28 +0100 Message-ID: <8d89c0b2-f9cb-e3e5-72e1-736f655ab5c3@xilinx.com> Date: Tue, 21 Jun 2022 13:19:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/7] net/txgbe: fix register polling Content-Language: en-US To: Jiawen Wu CC: , References: <20220620075512.588744-1-jiawenwu@trustnetic.com> <20220620075512.588744-4-jiawenwu@trustnetic.com> From: Ferruh Yigit In-Reply-To: <20220620075512.588744-4-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2546fc1-4e55-46fd-ca4f-08da53804a43 X-MS-TrafficTypeDiagnostic: SA2PR02MB7739:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q+dSGTO0c+vxjDpRP0eHi3sfxsplTaKQ7TGeEhrFszkhxNHQ3wLvs8fspCt31x/h/6N9nDDQ2/BakUL6Hh9DXAtb9tj2ja8IBGD/JbiRGnOC806ul0p1fG7sSgGaNZUl7iypZom626jIgwUGPFfEdASW/YLy3Lu5dAYvMG1i8z/oXpHrCsxRQtkAm2iE2oXD+xZPyB29736qS8/wnmaa5L1DsYKwZO8l3msI9O8B5YFEqG7KRO2Tk2Dva/jmW+5w0Qy+z0NQclxYWjYL4B+Va+a6A1lfY3FUwSaUcyCZuRXM7AMb5FPUeVtODVbZiBcIF+wFEXCxRzFMNuM4xeY3KHENkz5qmuioY7EsUfibTL8eIrL8Kro06sVik0hKZrJ0WokCJ58p+Eddez6lGLeeXRL7/98oCxkGJFB8ftNGik55/+GEXdwnhEO6mwjncF3AreCtVdMlU3H6ZCjyORssPf/00QdIVVuEB9IUtogFNBCHKFK7fRYcfnW5UWzn/nfksybHLzezVLnJuYfq/wq0enN7tP7mnAqktd5EXPGGeTOE9hXDZ58NAXnQB9OekAeBi+D9YuK8oM2UKpwFUR1eGumX9+ZKRCsJFANo+ufCmudKGtzKlDxYfXjVQKnJl5sAAPLvwYmw1zBD86ZiHePb5QwwKW0P0/fuwniW1K7q9tRpMiWzWbvJ8XRBicFBpnWiJlwYoiS/ZHC0TcWTaE6eIDZCbJC58JMn2WrCl6Xbxwn9Iq0PHaKcdY9yjHV8ST5bsTgiKS7gfQ01pXJM9gD5X4ydGLX6HszkzxZGCkVQ4Eo= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:ErrorRetry; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(346002)(46966006)(36840700001)(40470700004)(9786002)(26005)(6916009)(36756003)(478600001)(5660300002)(44832011)(31696002)(8936002)(53546011)(36860700001)(356005)(81166007)(82740400003)(40460700003)(316002)(40480700001)(2906002)(186003)(70206006)(41300700001)(2616005)(426003)(82310400005)(47076005)(336012)(83380400001)(4326008)(54906003)(70586007)(31686004)(8676002)(50156003)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 12:19:29.1035 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2546fc1-4e55-46fd-ca4f-08da53804a43 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT039.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7739 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/20/2022 8:55 AM, Jiawen Wu wrote: > Fix to poll some specific registers, which expect bit 0. > > Fixes: 24a4c76aff4d ("net/txgbe: add error types and registers") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/base/txgbe_regs.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/txgbe/base/txgbe_regs.h b/drivers/net/txgbe/base/txgbe_regs.h > index 3139796911..911bb6e04e 100644 > --- a/drivers/net/txgbe/base/txgbe_regs.h > +++ b/drivers/net/txgbe/base/txgbe_regs.h > @@ -1864,8 +1864,13 @@ po32m(struct txgbe_hw *hw, u32 reg, u32 mask, u32 expect, u32 *actual, > } > > do { > - all |= rd32(hw, reg); > - value |= mask & all; > + if (expect != 0) { > + all |= rd32(hw, reg); > + value |= mask & all; > + } else { > + all = rd32(hw, reg); > + value = mask & all; > + } > if (value == expect) > break; > > @@ -1898,7 +1903,7 @@ po32m(struct txgbe_hw *hw, u32 reg, u32 mask, u32 expect, u32 *actual, > > #define wr32w(hw, reg, val, mask, slice) do { \ > wr32((hw), reg, val); \ > - po32m((hw), reg, mask, mask, NULL, 5, slice); \ > + po32m((hw), reg, mask, 0, NULL, 5, slice); \ Just to double check, is this change intentional, to always expect reading '0' from registers after writing to them? Perhaps you can explain a little more about this polling after read/write logic and what was wrong in the commit log. > } while (0) > > #define TXGBE_XPCS_IDAADDR 0x13000