From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0059.outbound.protection.outlook.com [104.47.41.59]) by dpdk.org (Postfix) with ESMTP id 469B758CD for ; Wed, 18 Jan 2017 09:38:51 +0100 (CET) Received: from BLUPR0301CA0039.namprd03.prod.outlook.com (10.162.113.177) by BLUPR0301MB1571.namprd03.prod.outlook.com (10.162.214.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Wed, 18 Jan 2017 08:38:49 +0000 Received: from BL2FFO11FD030.protection.gbl (2a01:111:f400:7c09::150) by BLUPR0301CA0039.outlook.office365.com (2a01:111:e400:5259::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Wed, 18 Jan 2017 08:38:49 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD030.mail.protection.outlook.com (10.173.161.40) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Wed, 18 Jan 2017 08:38:49 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0I8ckA7017413; Wed, 18 Jan 2017 01:38:47 -0700 To: Thomas Monjalon References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <2193672.0sRautH3mz@xps13> CC: From: Shreyansh Jain Message-ID: <8dd7ee97-b68f-0090-b128-cd693a314317@nxp.com> Date: Wed, 18 Jan 2017 14:12:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2193672.0sRautH3mz@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131292023293253781; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39450400003)(39380400002)(39860400002)(39410400002)(39840400002)(39850400002)(2980300002)(1110001)(1109001)(339900001)(377424004)(189002)(199003)(24454002)(377454003)(8936002)(4326007)(93886004)(47776003)(8676002)(97736004)(92566002)(4001350100001)(54356999)(65806001)(31686004)(65956001)(106466001)(81166006)(76176999)(33646002)(50986999)(105606002)(305945005)(81156014)(189998001)(104016004)(230700001)(38730400001)(85426001)(65826007)(83506001)(31696002)(110136003)(86362001)(356003)(5660300001)(6666003)(77096006)(23746002)(229853002)(53936002)(50466002)(6916009)(36756003)(2950100002)(68736007)(626004)(2906002)(64126003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1571; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD030; 1:9Rcn3Cz1Bfx8LYXKrniPupcZYp7qHIu/RzkDM9JLGLGstny4DddKZquHnpB0/MKRqQdmUB/h/Q3bcUaPTSSHCu9q5Dod+6+uPS3vJ6hLJReG/rs+0457Wr/9PA9tcRrlq6uTYqzgpK0F4RzSRCya1zSmPcFGgRc4eRlEhgcaXg9U0fTISk0REGrb1veAnRbgBYZCKupdfgN1Ta1DszTWmxI6LhPc+CTmfZb8UnDOjbi4TrbaIcqoTlmhc7zEEKYO6xKDuPOf0xkF6b1piYd9syff0yUsy3We9qW1DSX6giTDaXJwoLM/OjHnUsfehDamWD2kWprjPj2lFW+TE7yal0yqYXq+88JLliFc5qBdVJwEYS8QEH967bq3mwn8Dc7IJ5CWbQ27dEaE3U6ZyQXw07pPN3gRAsdGK6XMnAqmw8ElO7CIKZDsQzUXQFEtRSPc+4xb89ydVDAk1NZgulhkk+joPc75MmAkWbR1yLdg6g2Zavkx2Ek3TnIM/rnXNU79Z+5wUZqof5Lh8mlGVrR7zdjV1DILj28UV0/WFZII961tIHP0d6X97dzPKqf0fTUy X-MS-Office365-Filtering-Correlation-Id: 9dd2dd17-5d42-4956-8d8d-08d43f7d6ca0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0301MB1571; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 3:ZqbADkK6NI78Q6YaZ6Z8k319zhoEW6WTqgACxzR3PSfo/TmqXUxr99wG3xG7AZrMG5HmP/ULi+6QQEwBfIvQjUWRHiFPF3GBTUjPg7ZXqvameuZZJRpN6Bhge0mYVAQdr+VlI2CqK5pCe2Tdnyi5DuCgqxtWB01IjJ8iytvmEdgVwT3fo/EZh1s5r6fsgzM6aDWU+ejYx+46XXK1565kSuxl9jr7qBVu1R14UPuwJNkE/5h83wpsu+HVDYOJuyR5g6K/uTPzi5qDhqMiZeJDG1mMvLRBrP7Bm3WtPkD/ugV5ULV878977g0Dgu9GF9DNXq+jbPW8uKKnOc2ed5fZX7+NTbSAU7jR3Yp1BvhKd0YpHudphUvRca9sW3YINojs; 25:Rby58spnlFXCIMcjbQaX+8hq72GL7wEyDwQRAwkzb8dFTn6xe8M/lOjBjR8ZiM1Q6W4lZHQ064aXx185KcoazYa8TrRbDSb7YHROLaodLeKOl7Q1qJHhHPWZMwGnPUX88FeWhyNagLowCTPiyYfKB9ViIglE9IPZevCd0JtTgf7lqDmNBWSbjp+vrYLWF9oa8orIoEhYk2g1g55ISEKUK69ZgHg0HEwh1YKWZMAGRdy8AqPXJU0PjPAZ18iRLir4Fy8EOLXXROVtSqlJKD1jR2mGciaIG8SSDYQfmsaBIUs1yhSquLYe6sv0SaGWOnx5LIN6Glk4QEPh7QdlDkt0LLI9A0SgKz0RdqS2yfFjY9SoUTe5RiVZjoFsxGXFWo5WP7nxQCr1WfW6UlNG3tuxxtBiJtclf0UNl/HR6ZN9s0slVAm54NBk6yhx8mJYwBh1jE9odol8dfeErC3WWe5erA== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 31:Zmq29E9Oawo9QyItpDYyARPyNRARdfaTh46+n46aJ85KWTmSmA1dnLzamg4TOZ2C0lvGR0iQcKG3eEDhMGF+k5LF9T/xP4PZ/fUlP+AOyV51lo28VM1916Yt3NHxI8mZRSDRfdI954/KuZfYq58H+8P734YEoquyDdCtchEFmO2WExAjS2VLde4/KXm8Xuk+EyN933GBBPzOKPWfnUsibiYXhZN35nqrM/rcPLy1Juh1vYW4QrX71nvtx1urx2pIv59swpHv4OfRo6ffvWzwFn9Petil+gLwGFyfjpwRUd8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13015025)(13024025)(13023025)(13018025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(20161123559025); SRVR:BLUPR0301MB1571; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB1571; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 4:Lv96ctczXDae+GxhRqN8taFMosv7qnK0aV70H9EU9U616rOKtdJsVoLSjCZWxXP/3ajpzZ40fnQhh5vHdNSdMdFTQqyGUmhtLkCgeLFmejJQndgKwI9KgbpHKDz3/UmOeSn3WR30Zdj0mo6TvbcLBCDQ+SjxYdpT2YPlVOnGYZ+ftOjfOon5f1iSFhJ2jC/G44jhTTaMu8inh6gadsTOWRjnHiwVVqdM9WPMEeHMuvKwS8DJ/x1HVKiPMLJ18AUaW2JX9b1yxOg+0nQQ+yHUBevR1rcBvQclJD7Sgd/0lQMEloKN6h3kTJPf8Seiip2XVSyiCHDJo0oTOyCAXL0VCiyBcDHsnbsU0kATi37hUnsDQAogeJGDZCe9IVAtrmw5feXVgbLKfU4pvwyrnJbcn5P9WarI8LM7PXwM+x1LQcacnB/FniXeOyV45bGzY+AEnvlRsl9qrs6Om86ny8JZvcB6ONuzvQNljqP2f/lPs4UE8pWDc8fxZg4M/1vXFiena1gGqNiGu89I0yT9cdOJcVz8xzRcxLelI2y/Oz58WGVcpaVRZlxBUA1E7OM3A00b35DeN49yUcRa3CkGxzUdjSgQkEOKrD7s3ZTGPf1ro8iwoLm5LFb6iulvEtfQs9iguumb99IDhxLRtUbRcDmR0NFBiVmj/4FkjCIMIVwr9fA3hZV2eIAyYU+IQFqtG4W03GjbHjg6+Yr9SOHhXE+yWg== X-Forefront-PRVS: 01917B1794 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0301MB1571; 23:8iONxUuUiXBGl/gAQtO7tk9Lx+VSUs3c+bF?= =?Windows-1252?Q?1/M8dMTxg+oyUdw6TQo6iK2Gqa0zmx7DjAcJRK6IrnTuRWdmDW3zFM9x?= =?Windows-1252?Q?hFOdXIXZNPzjRpSOKxNMyPa97QeykI98EhtEJb6LrMxnOgL/HasFOZ4N?= =?Windows-1252?Q?A0fwncTj1W1K08/CyIdqpiDoOMdTZ3y4nanM32b4TLhqKClKd61bxB8O?= =?Windows-1252?Q?/v9C0QiuVjGNe2Wp711yg8XUtPYTV+tk672kCZq9FrLp+KIJI00SbN+j?= =?Windows-1252?Q?4ajCCfkRt8JeJVCRXkuxVivNfqhKJkidvixLYwdTu4WRvrsXiYUYF01q?= =?Windows-1252?Q?3uoZDTc+SJhGwIJ7HDi+kNKPDKkzG1KHrbt/a33xBsO7lt74MFvJoUFB?= =?Windows-1252?Q?wq3umtv3BCgaR16xh2TvfoX4HdsMdRNJcldfPIGj6qmMp0p6ePgqVk73?= =?Windows-1252?Q?T93lc7LbJ+qmPVEGsFDtWGofukQIlVVNG+NWOtHLwd/+3+wjOkhOkyJN?= =?Windows-1252?Q?lI1FCjOCwOHOp/I8QD7y/PUhxXwo91BgQfYegj5VuAjZ8UewJ2RErQbm?= =?Windows-1252?Q?L8IiKJqBMKroRw6XU+g1OloSmkv/0EIW6Q5wfc1KTnGJ4Mi4oWZZ6/j/?= =?Windows-1252?Q?bvZe5xAf/4nGqdZGqjrGqmwz59bzIUAQrdAC0av/5PqFm3uW0m1o2yiW?= =?Windows-1252?Q?QX5Xam8ozPZAYdQAATCCzkB2qyRSf8+ezFDWz941ZErwVqfGfDsjsWNJ?= =?Windows-1252?Q?c2Zpksg/SGksLoiHPjwPmRhHyp8znYOA3LmfhRi6LN0xV9qw1xfH5gMk?= =?Windows-1252?Q?G78gMtVtTwqV54j126kB7o+/GX9eBM2bO1O51a6aiG0QvjFXSvHIx/oj?= =?Windows-1252?Q?Z5MimiAEoz3gGr2pj8usa8wjE2fHts1IFVFk1KBAZ8sS22kTXXm0TkyG?= =?Windows-1252?Q?pd/0DeSHJCP03bBpdO2UZ+HN5VZsSR/xrqXketFD/nUVInLt4UZJrnHO?= =?Windows-1252?Q?BWkWHnFsnejyvs7nILka4zfzQbG2Bduo9H1SYuPGteNKEsi0azv7ekMM?= =?Windows-1252?Q?z9stTP6SGMlZBISqphfGGU5va4xQtnfMT9ULZWCBqBZiaROeiCwLN0lo?= =?Windows-1252?Q?3wb+A3aUw5vtC5tpLtoLNmX4Lbnw7alxQCP9uy+iM+n/9ToPB0Ttl941?= =?Windows-1252?Q?DdZCvohiygavjPi4Vi3fltflI/lsALJzrByFCpbdtBxRfS9c7O+D9jpf?= =?Windows-1252?Q?Gz4JcvHqltTJ7vbgnJBXBgwkWjLZRjMDadROpayeNKdF3oIjMbVu4yUf?= =?Windows-1252?Q?gUj9dTLLfRp8FoRKNJyGschy9H8HoyhxzRxIAqW80BGpHQkIwtqp/Nvn?= =?Windows-1252?Q?wgTMRUb0OsJHYBVK1X2BZl8rGGSC8T7yJvXC1JxdznrLItrrS6FG/o9L?= =?Windows-1252?Q?/fMt5BeO4j8cL9TlPGfdoVmKsckT6L+9y51edVgc2BlTttNM66at4p+X?= =?Windows-1252?Q?N1wZpK0wdgUrQJqgfSHp5sqn/KDifzEULjoVFFXiLMen3i396tjGrXSm?= =?Windows-1252?Q?zSZA8IVdAz0bXofkynrQfTcbQ6XUYBJEuoRcmiqoHFF3fQBFlINcbo5I?= =?Windows-1252?Q?Z8jTjUo/eSemsIKZC9Racr5RTjZoWmHu7eKdFYmjmB04F?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 6:tlpTgNo65reB62krEnHUF/s33m03LwxLMkal9d/i67zKLFNrX8y4HktervbW47u+m/xE6WIFAlm0x1ezIdcquh/opjyCHU6OvMtj87rFuA5TfA0lim1dRiYVy2D0giKkvDpxvGAUH5TbcJFEImtz5qo4WZHU3uq6hAOsyuUyPQVgvoLfxEbdwHlMYiTDLrIInuBnUbTAukNYjcDe1yg7BPj/3CeT7juor1L8ED1vpdzSlHBHQ9acgCYYq3xq4WXzVA9l84GybGnXh8Gfj00da+ADzCcLSCPWONhsyoqjJ0F4k8i5fFTEBnwh8/IJEX3+xVcqhXZIBS6r5mNNxE3rwMaIZbiUdFZQ5dOYZ+8b8sOUugEnohx7HNNzoJ0Z0Q8dl9Sw5KlUKosjGEZTcl0m9rBGouEGHcOq+crxaMoSCEFGpQijBysfWv9VzJLRUv5R; 5:sZctB9pLcUx10eJc5rOyp+W04rU7zZl1Y3427mihGj8cCifIVylXtJGwa4HjgRHch5MZ7pINkkFGIny2Gh6lNg3GxvCKCXS7hI2L/Kq3Rok748A/6iQt+OXSMG0fE+IE0o9GqMh2WS8303BuNQMaBdXd5QdoBKV0YplzFu9pZfNeHXXY1WWoFBqitqJABsgY; 24:NxKC70//jY4ulfYQ62OsIoXTtLGjEEnEr5obCUqStWsAjYgqW3wMd7CTKLXKy02S/kZWBiV5lBRrfgrHAi610ZxwIYMEke8ektQq25A52AQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 7:Pd275mhoHZSMuTOyrOjez+cLur6zE+k8PQm16tQcTvajc6jdQASw5rXjNfnkdGOUTK5GTDmQk3dnVwPF2on0OswXor4m2qWxu5dj0qrhODPaorH1U+vwso/YWKEeGoo16o+iCE3egL+VHW+66AUf+dy99myAqWEOO6z+ALWVEkJswJiqIoCCK3T/UPEBECdr8jUnM8NbkTXJFonQQKFw5BhBzALBECtk6HjmLHCqU9AMCKx8mmL+4oB+6z55GYTzXtIkH154zqDtw5AyQXEnnLzfdhKu+vibc8nfEcau/3kSEQpFwbxGtyW5dTZQrUp42jQT7fZOES03m1TbCgQmZbnMJ1I6kEUbkcWSYueqD+rZhW4Hb4H97ekljW2okZe+x8JQsRPcha3ebl6wue1VN6nFgk5+oHNeazOTwb8DJybpTzrORQ4Z9dFV2e0+gLQHFeKRT75dxgxl3A3Fx6+u6w== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2017 08:38:49.0289 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1571 Subject: Re: [dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 08:38:51 -0000 On Wednesday 18 January 2017 12:58 PM, Thomas Monjalon wrote: > 2017-01-18 06:56, Shreyansh Jain: >>>>> +/* Bus list exposed */ >>>>> +extern struct rte_bus_list rte_bus_list; >>>> >>>> I think it should be possible to write a test without the real list >>>> of registered bus. >>> >>> Yes, it is possible. I just modeled it on test_pci assuming that is a kind of >>> expected/standard. But, it seems probably it is not. I will change the tests. >> >> After sending out this mail I realized the real reason for using the actual lists. Functions like rte_eal_pci_register (for PCI) or rte_bus_register (for Bus), use global lists for registration. Test cases calls these functions for registering dummy device/bus. > > Why access to the bus list is externally required? > I feel there is something wrong here. It should be private in PCI. When I stated rte_eal_pci_register required global lists, I meant in previous code base (pre bus), the pci_device_list and pci_driver_list were public because registration function used them and test cases used the registration function. > >> One way is to not worry about adding these test/dummy devices/buses to original list as they would be unregistered anyway. But, risk is of impacting running list assuming multiple cases need to be run from same application/binary context. >> >> Another way is to rewrite these functions locally in test case, but that also means not testing these global registration/de-registration functions. >> >> Former method would continue to have symbols exported. Later is not testing some entry/exit functions of a sub-system. >> >> You still interested in this change? > > I would prefer you do not lose time with testing at this stage. > Ok. I will leave it as it is for now.