From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 2EBFF199B4 for ; Fri, 2 Feb 2018 16:30:02 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180202153001euoutp01eebd522038ecb308a0a766c3adb4a9ff~Pi_HVOGHS0145801458euoutp01n; Fri, 2 Feb 2018 15:30:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180202153001euoutp01eebd522038ecb308a0a766c3adb4a9ff~Pi_HVOGHS0145801458euoutp01n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1517585401; bh=J9IZWqIhrV8ejmmNhHzuDXvMnpPNI53cR4wZF3dchJ0=; h=Subject:To:Cc:From:Date:In-reply-to:References:From; b=kfa7P3dI07nJKqVK0zqYxImZ9FdKobbdH5fuj7wo3MOpCqphP7foqy7T5DFq9pBe9 MhEG5A8PqsPAUnXAM2xbT54qKvr2rSSAwsqW654XWDoSA63tdxnRmZGBptNtrNBFUO 69vkRIsSmbTjV1Dned3830sdYB7NX9H1A8mzL3WA= Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180202153000eucas1p2b1fc6dff9b093657831de61c77ab89ac~Pi_Ge2A5Y3058930589eucas1p2b; Fri, 2 Feb 2018 15:30:00 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges5.samsung.com (EUCPMTA) with SMTP id A2.F4.12743.8F3847A5; Fri, 2 Feb 2018 15:30:00 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180202152959eucas1p29e4663da3740566114fdb82045ee3caf~Pi_FrfcwT2339723397eucas1p2J; Fri, 2 Feb 2018 15:29:59 +0000 (GMT) X-AuditID: cbfec7f5-f79d06d0000031c7-81-5a7483f8eb35 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 96.93.20118.7F3847A5; Fri, 2 Feb 2018 15:29:59 +0000 (GMT) Received: from [106.109.129.180] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P3J000R14DYGB90@eusync3.samsung.com>; Fri, 02 Feb 2018 15:29:59 +0000 (GMT) To: Zhiyong Yang , dev@dpdk.org Cc: yliu@fridaylinux.org, maxime.coquelin@redhat.com From: Ilya Maximets Message-id: <8dda4863-b45a-7f71-1c2d-7df6e67b05b0@samsung.com> Date: Fri, 02 Feb 2018 18:29:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-version: 1.0 In-reply-to: <20180202083914.37584-1-zhiyong.yang@intel.com> Content-type: text/plain; charset="utf-8" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWy7djPc7o/mkuiDJ7/5rN492k7k8WV9p/s Fsc697BYtCzZyWQxf/luZgdWj18LlrJ63Ph3i81j8Z6XTB7v911l8+jbsooxgDWKyyYlNSez LLVI3y6BK2PSnbmMBc1cFe3b/zA2MHZzdDFycEgImEic+p/axcgJZIpJXLi3ng3EFhJYyihx 8nAkhP2ZUeLyAnaIGhOJaUt2ANlcQPFljBK7WzYwQTgvGCXuTf3FAlIlLOAssX/aDLAOEQFz iaNbF4PFmYG6V594wQhiswnoSJxafQTM5hWwk1i14gVYDYuAqsTyz2/BrhAViJDoeraLFaJG UOLH5HtgNZwCNhILL7xihpipKfHiyySo+eISx+7fZISw5SU2r3nLDHKchMARNonVPyazQrzg InHuzVNmCFtY4tXxLVCvyUhcntzNAtHQzCjRsOoSI4QzgVHiS/NyJogqe4lTN68yQazgk5i0 bTozJBx5JTrahCBKPCSuvWhkgbAdJW5e+sMCCaJ+RomDfc2MExjlZyH5aBaSL2Yh+WIWki8W MLKsYhRJLS3OTU8tNtUrTswtLs1L10vOz93ECEwrp/8d/7qDcekxq0OMAhyMSjy8N9JLooRY E8uKK3MPMUpwMCuJ8G7zBQrxpiRWVqUW5ccXleakFh9ilOZgURLntY1qixQSSE8sSc1OTS1I LYLJMnFwSjUwavNsDt1lvna6sKTAIePwDhEbL473tu96OrMl9A/lsYidjq17LjYpwXXVkQ2W QpIdbVHvdP/9fj8z5OzKdw+vMB3iYp5TfrRCUr7tkOpDLUWNmyL98mqmUkdUb86/mrLEOGf3 n+4kD7PrJ+dNnVF2vvexwPcZDQt8HJ2mJ97K+hEpIHg2/12mEktxRqKhFnNRcSIAa85RMicD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xq7rfm0uiDPac1rZ492k7k8WV9p/s Fsc697BYtCzZyWQxf/luZgdWj18LlrJ63Ph3i81j8Z6XTB7v911l8+jbsooxgDWKyyYlNSez LLVI3y6BK2PSnbmMBc1cFe3b/zA2MHZzdDFyckgImEhMW7KDHcIWk7hwbz1bFyMXh5DAEkaJ 56+fMoEkhAReMEp82poBYgsLOEvsnzYDrEFEwFzi6NbFLCA2M9Cg1SdeMELUW0t8W3OWFcRm E9CROLX6CFicV8BOYtWKF2D1LAKqEss/v2UDsUUFIiSaZs5lhagRlPgx+R5YDaeAjcTCC6+Y uxg5gOarS0yZkguxSlzi2P2bjBC2vMTmNW+ZJzAKzkLSPQuhYxaSjllIOhYwsqxiFEktLc5N zy020itOzC0uzUvXS87P3cQIDP5tx35u2cHY9S74EKMAB6MSD69BVkmUEGtiWXFl7iFGCQ5m JRHebb5AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4ry9e1ZHCgmkJ5akZqemFqQWwWSZODilGhgj jc0WHr7Q5v5xEzdzakawyN3SfeJNC3o/39YJv57u+Fv3Fr+4xcrLOyc8WyIsP7UjXnXH+fc7 IpPWVeT1SJrkvFkenterJHj3pHDpVq76C8s/u52J4HomUiPYenJTmff3jxKM1+fcuKu09K6R zsljpyVuRZxWaPrBG7A1Q/yB+9cddq4XFigqsRRnJBpqMRcVJwIAYcIMCXoCAAA= X-CMS-MailID: 20180202152959eucas1p29e4663da3740566114fdb82045ee3caf X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180202152959eucas1p29e4663da3740566114fdb82045ee3caf X-RootMTR: 20180202152959eucas1p29e4663da3740566114fdb82045ee3caf References: <20180202083914.37584-1-zhiyong.yang@intel.com> Subject: Re: [dpdk-dev] vhost: unlink existing file for server mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 15:30:03 -0000 Oh. It's such a game: twice a year someone sends this patch to mail list. I have another one for you: * Find all the patches equal to this one in archives. * Read all the discussions. * Come back if you have some new ideas, not already discussed many times here. Sorry for my sarcasm. NACK for this, as usual. Best regards, Ilya Maximets. On 02.02.2018 11:39, Zhiyong Yang wrote: > Vhost-user startup will fail based on server mode, if the specified > socket file has already existed. The patch introduces function > unlink() to remove the possible existing file. > > Cc: yliu@fridaylinux.org > Cc: maxime.coquelin@redhat.com > > Signed-off-by: Zhiyong Yang > --- > lib/librte_vhost/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 6e3857e7a..324a24f4e 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -315,6 +315,7 @@ vhost_user_start_server(struct vhost_user_socket *vsocket) > int fd = vsocket->socket_fd; > const char *path = vsocket->path; > > + unlink(path); > ret = bind(fd, (struct sockaddr *)&vsocket->un, sizeof(vsocket->un)); > if (ret < 0) { > RTE_LOG(ERR, VHOST_CONFIG, >