Re: [dpdk-dev] [PATCH v7 3/5] app/testpmd: enable per queue configure

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/22/2018 12:58 PM, Qi Zhang wrote:
> Each queue has independent configure information in rte_port.
> Base on this, we are able to add new commands to configure
> different queues with different value.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

<...>

> @@ -1752,30 +1753,41 @@ rxtx_config_display(void)
>  	       nb_fwd_lcores, nb_fwd_ports);
>  
>  	RTE_ETH_FOREACH_DEV(pid) {
> -		struct rte_eth_rxconf *rx_conf = &ports[pid].rx_conf;
> -		struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
> +		struct rte_eth_rxconf *rx_conf = &ports[pid].rx_conf[0];
> +		struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf[0];
>  
>  		printf("  port %d:\n", (unsigned int)pid);
>  		printf("  CRC stripping %s\n",
>  				(ports[pid].dev_conf.rxmode.offloads &
>  				 DEV_RX_OFFLOAD_CRC_STRIP) ?
>  				"enabled" : "disabled");
> -		printf("  RX queues=%d - RX desc=%d - RX free threshold=%d\n",
> -				nb_rxq, nb_rxd, rx_conf->rx_free_thresh);
> -		printf("  RX threshold registers: pthresh=%d hthresh=%d "
> -		       " wthresh=%d\n",
> -				rx_conf->rx_thresh.pthresh,
> -				rx_conf->rx_thresh.hthresh,
> -				rx_conf->rx_thresh.wthresh);
> -		printf("  TX queues=%d - TX desc=%d - TX free threshold=%d\n",
> -				nb_txq, nb_txd, tx_conf->tx_free_thresh);
> -		printf("  TX threshold registers: pthresh=%d hthresh=%d "
> -		       " wthresh=%d\n",
> -				tx_conf->tx_thresh.pthresh,
> -				tx_conf->tx_thresh.hthresh,
> -				tx_conf->tx_thresh.wthresh);
> -		printf("  TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n",
> -				tx_conf->tx_rs_thresh, tx_conf->offloads);
> +		printf("  RX queues = %d\n", nb_rxq);
> +		for (qid = 0; qid < nb_rxq; qid++) {
> +			printf("  Queue Index = %d\n", qid);
> +			printf("  RX desc=%d - RX free threshold=%d\n",
> +				ports[pid].nb_rx_desc[qid],
> +				rx_conf[qid].rx_free_thresh);
> +			printf("  RX threshold registers: pthresh=%d hthresh=%d "
> +				" wthresh=%d\n",
> +				rx_conf[qid].rx_thresh.pthresh,
> +				rx_conf[qid].rx_thresh.hthresh,
> +				rx_conf[qid].rx_thresh.wthresh);
> +		}
> +		printf("  TX queues = %d\n", nb_txq);
> +		for (qid = 0; qid < nb_txq; qid++) {
> +			printf("  Queue Index = %d\n", qid);
> +			printf("  TX desc=%d - TX free threshold=%d\n",
> +				ports[pid].nb_tx_desc[qid],
> +				tx_conf[qid].tx_free_thresh);
> +			printf("  TX threshold registers: pthresh=%d hthresh=%d "
> +				" wthresh=%d\n",
> +				tx_conf[qid].tx_thresh.pthresh,
> +				tx_conf[qid].tx_thresh.hthresh,
> +				tx_conf[qid].tx_thresh.wthresh);
> +			printf("  TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n",
> +				tx_conf[qid].tx_rs_thresh,
> +				tx_conf[qid].offloads);
> +		}

This part requires rebase because of recent updates,
this was wrong to display queue specific values as single value, thanks for fixing.