From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D06AA0C4C; Fri, 12 Nov 2021 10:08:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D210340692; Fri, 12 Nov 2021 10:08:42 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id E2EA040687 for ; Fri, 12 Nov 2021 10:08:40 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="232946646" X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="232946646" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 01:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="492926471" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 12 Nov 2021 01:08:27 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 01:08:26 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 12 Nov 2021 01:08:26 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 12 Nov 2021 01:08:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LubOPHe5hs98yWMi4QO53KRdu/xiIMK4KIpSAZ4g05dIUZsn82NOyq6LMw/Y3HgQsDMN6ZN+uMy+riR7jL0LsusXn8079zIBPDv7xy5EZ4OeehmxO2PaoYZ7rjkSuYBQ7vjTSBDdtgf5oF96fz+aWp1kwz9gXJhosNPiyD4YqD1iMvyhF9Y7szQdioghxp6RpwFtyQ/iyiLh4FrxYuDu3NaHrk9pOh6IQm3TuxYufA0AsrDDO/nyOx1ykz6oE2lDZzN5Tcur0wqJhl7JyDQ7EdDkt7tb6oj2kmIDhHCjJGmH7oUCWnPIji7yk+2EXJ5mssnCWaC5iRQl6pnKCr9Azg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LIWUUEBN6jV/IaH9/W7RwUIvTj1xAps5kJvIpycecM=; b=in3MopVyZfv/sjXy4Z9WmMALF7NBJXsp2P9nM7eb0ANoiJb0LyYzgQCs/spGerk6xWIBF3zwZonqqZDy7a/1e5f25/unyZw87RNmyTERqD4fNJEPposD8kFwp1uY1INbMAntDr0CDkE/0jcxQK3UMMY9NhhyXqnQGdFWqnakY91ZtT/cQT8Tp6GvYfCNLsMswwUQLomLxLkZDf0ZOLIy8pZdq8ffkEA+ELHh8aNSqY2Hp1LRRS4gCl/ItJKmNmS/zQaXgrACPDrKKaKQpPF5bpVg1PEbV3m7uyj2OJtQCYu/CgQQkOH0so7f2wzvoS6cFcmbrQQ0HGoFwl6q1mixsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2LIWUUEBN6jV/IaH9/W7RwUIvTj1xAps5kJvIpycecM=; b=demqUyP/BM/Yb7H99H43aPwaU5HNXRfjSgSPrNk9HMdyZ2wkbVjSI5coskRfX4vhcU1j1nasVK+N2+bbic67XPuKy5fdsJ7GAwqyi7Buh6ZRAfoITkTIkSiynVEjbys4ocER819iFqEblnz99UPYbdfzDw9jSTyRSkG3/1CRZeY= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CO1PR11MB5185.namprd11.prod.outlook.com (2603:10b6:303:95::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Fri, 12 Nov 2021 09:08:21 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505%3]) with mapi id 15.20.4669.015; Fri, 12 Nov 2021 09:08:21 +0000 Message-ID: <8e387645-07df-2d25-2d2a-660de589644a@intel.com> Date: Fri, 12 Nov 2021 14:38:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration To: Jie Wang , CC: , , References: <20211109080206.694428-1-jie1x.wang@intel.com> <20211110090842.912936-1-jie1x.wang@intel.com> From: "Singh, Aman Deep" In-Reply-To: <20211110090842.912936-1-jie1x.wang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0086.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:23::31) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 Received: from [192.168.1.18] (223.178.208.22) by PN2PR01CA0086.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:23::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Fri, 12 Nov 2021 09:08:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 718c5e42-1063-476e-ef6b-08d9a5bbf911 X-MS-TrafficTypeDiagnostic: CO1PR11MB5185: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:612; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVyALDrU2GPwGLdAL7Ya4XXEN+oDJJHMueXpicdZsjrTs4x/n6yFtoC2HRqFBm3iLvekzVnjj3EhMEjx66g2OBYMegiMvMYRmR/rkXbL7rCAxfkcCtYBoniHVYg/wQH/CcMLpfgNIRCoJDweelEGeRVVCSqLjONN70U3xpXVeOgI3k4Fk9pY4pa+0v0IeFxSHspsrkTQiSrnHsUdjnSMJQKPGeBUBq0GubCXYIG5mY7/Uk9ziXb15zuEpDzUJBWz85y1HY5fNjBmG8OPv6MZqAh2XFd/dHD5eLiMHNDrmdJ7LXEfwF+bH3ZFvi9ypELLeJlvo8zzKU6BBDwqRu6OmelnY7z/IYe9J7YMDkwkXrlEiqRMwXod6XjxcFNlIx99AAm8RYRm7gSUxl2lFwJeLAJdeCLJwQ4y2zzOQBq3JqJlb3MY75GbFEpB7P1Zx+PFdaMiOe9KyOfjONATu2m2Q12vOrO/sP7wiUJ7V60p2Iz/Boepl2rUCkDliQmxuzgGoRcRcWsljp5Zh2OoS8QEifJcgaD/Oy5alKDUjvOOuBvYidd7K7u6i/QNa1XIM2yBwVchntZIaQ9/2iPYR7quO92PVKJuCCqVa/+Lc0IngDnmrc7fOBqCRnMqLbh7FkVmwRalnAqbz4w/EseDkt+lOqW/TJ1rwaWB5ZhVdwRVcMQzlFLnBqdPVyuqGh3FT+0GEMi7S6LrpsJXiXs1TSNZHpSqfOg6VHmWt87qwWVO7PY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(5660300002)(82960400001)(31696002)(6666004)(53546011)(508600001)(186003)(66556008)(4326008)(107886003)(8676002)(26005)(31686004)(86362001)(66476007)(956004)(83380400001)(2616005)(36756003)(316002)(66946007)(38100700002)(6486002)(16576012)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnFUeDlteUJPUDhBZjNrVzZqdUVCK3A1dHJZMnJEY0FMellRc0J2dHR3dm1Y?= =?utf-8?B?TzdwcUU2WEppMXdWelhrV1ovUkU0QkQ4SjFlQTd5OWw0bUdnaElnZmorTHkr?= =?utf-8?B?ZmRnZW9MbVd0cUZ0ZnRlT0xiN2VaK0x6NzI4ZzZDc1kvOHRFckRkRWlzNzhi?= =?utf-8?B?bHRmelNBVGJRTnhYYys3d09VZlNKamVQNDZicGVqN2hyNzR0YlYxeWN2NnRs?= =?utf-8?B?M3hRdzdkdzFFUWh2dzZiaXdOYmNtOUZmVmt6K1lXWmxHVDNYa3BhOHhvL3A2?= =?utf-8?B?eEh3bUZvZHR2L3o2VHE3ZzgwYm5GWm9yZmgwNXJEdmExL0ZaT2tTRFVvVUtr?= =?utf-8?B?QUw5b0hXcyswYUpuL1pYaXhkUkJRY1g4bmJXWkp0c3MxaWMzSUlaZWZKVlF3?= =?utf-8?B?dTBtZkFvM0FiQ25Md3RiVjNmT2ZLc2kxMDJvZDAza0h4M2V1OXROTGdCUzFi?= =?utf-8?B?RldCZXVURC9ZbEtZaEJZVGROeUJzc05CcUdWTG1VdW5CUzhFNGlRKzhzVjBo?= =?utf-8?B?RDRtNTJCdW9nTjVpRTFjYjNyclArSUZBUERzUC9iT3pDT2JlanJXOHBra3JV?= =?utf-8?B?Qm5zSzhHdTVmbSt4SEQzSVpSMUxsbzZFOTlBNy9oU3BIbHFzNVZMTmtMTjhK?= =?utf-8?B?NmNFLytXaHRMVExwYy9FcTloTDhJRHlyNGU2T0xLUWhqcjJvME5hWXc0dE82?= =?utf-8?B?ZStGbms4dU8yQ1RhYlc0bXRvMDltWFRjdHZrWTZXejEvS3g1TitJV2dBSmhY?= =?utf-8?B?c3hzcWtvays0cTl3cGp0OGsrOW1XcjJ2UnYwZzRSVXl6Z2Z5clprRGs4anhj?= =?utf-8?B?UHRwakFXcWp1RmxPZTFoeDc4TkZ2cWVUVGs1bjVvWjhKTnViNnRhZHAvb0hs?= =?utf-8?B?TWgwQmZ2QW9aQmNRQlFJUGs3Y2UveGw5VVhaMVpjdmx0UXQ4a29iR3dzTGJL?= =?utf-8?B?RHJhNWNJaVpjTnJyS3JTUWJ6ak9Ydk05ZjM5cDJlR3QrWkFjanhEU0RRNWlK?= =?utf-8?B?b2xLMklYY3FQVzk3M0tFbG9RZ21xS3pReThodHlrdktCOHdHVkUwVDh2T0s4?= =?utf-8?B?eDBzTHl5QjZWc21jOXVJNGx6T054OHlhdHJENE5XOEdZM0FMSmV4UzdXOVZN?= =?utf-8?B?NzdCdEJtZElhL0hmVUZMZldvd3k4SHFyNVJSSUdrSkdoZm9IYnplTEE4Um4v?= =?utf-8?B?dWNUNkk3RloxcXk5TTVVRURPTCs0V09MdHJ6MWdGdzN3M3RHL1lGTTFLdnE1?= =?utf-8?B?TG93YzIvQ0hjSkNCVVFhQnZYdWEvNlNjbC9IZnVySGFONG8vYTduRFNIankv?= =?utf-8?B?WkpJcWdVTnhMOS9BekZid1hsUWYrT2wrb1hWL2JHTTZCSlp3NGNJQjZkV3do?= =?utf-8?B?aU51RVlha1BCaGlqWjJ3UTh3dDFmUGhEbWlpUFFkR1pBSUt2L2dlM1BDc3Zr?= =?utf-8?B?K2dCZk1yeEYxVFFMTjdmM3FlWXZ5ZHZhektDQXZNTEh0d1kxbTBGaGUzNlRE?= =?utf-8?B?Y1VCTGdYWUdhcU92UFNUQml5Rk5BVXphcGNOeDJ3ZEkyOXVJeVl1c3BWRFhi?= =?utf-8?B?U1ZUQVlDYXZOeW9EMnVaL1Uyd3g0Qkd0eG5WdWFoZmtGdFRuNTM5S3JKdnVW?= =?utf-8?B?MWdSTE5mc3N4ajV0RzNHTWdSckZBT0Eva1FDY0dLNGo0aVRqR0lUMXc4aWdt?= =?utf-8?B?ZkMxZ3NIdWlDRGI5T1lKbDQ4eVlPd2xqSGFVQ3NBdWFTMWY4dUpVU2ZQaGxZ?= =?utf-8?B?OXBxUGl5TFYvWmFycGQxeTBNVitEb2lmKzdyWFA0Nk42TVNaUjJWUjRWRVpG?= =?utf-8?B?QVYrSDViTG0zZ2dPSEJtZjEvby9JYlNUYVBSVjVKMUNCTWpDU04wUlBFallx?= =?utf-8?B?R0tKeXZLYlhrSjZwbHcrcldSSmZTam9USzlvaml5SGNGSmtOSzgwMHpGNEFK?= =?utf-8?B?S3JuaWg2UEhMa2I1eFAydmNRSFpSQmJMN3JlaUx4bmdiWEtRd2ViWFgzNW1O?= =?utf-8?B?UzRiaUltZWUwQW1NV0ZTMUVSSFJnL1NJMXZ0S2lWOGhnOXdocVJTMEozTWk1?= =?utf-8?B?NWNmTTdZend0N2tQM0ZHWVlYNldIQ00wYTRnNENUV2h1VXoyL0FxZlpnazRR?= =?utf-8?B?M1dzNGloaTZ6QlNrb1V1SE83VVJJTk4wRVdMOHU3M1Q0cmRQNXUrRSs1SjND?= =?utf-8?B?SHFWZFhOQW5KK0xPR3ZmZnJYczZyaU90T3lIaEVrODAxTTR4VGpNMHE1UUxW?= =?utf-8?B?dWswVHZYZEFIcUNXQ2JHak1zMk13PT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: 718c5e42-1063-476e-ef6b-08d9a5bbf911 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 09:08:20.9613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n3jlfXz3xHtVq7z0rq2wza1eDdRu9KtcILP/yC2NIYVK0svo7hDintpw2AfljTyqEFJdr1xQc67eXT1IVKOdno9q0sqa9NP6oGDc1DlcxCA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5185 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2021 2:38 PM, Jie Wang wrote: > When set port DCB mode enabled, it should remove RSS HASH offload > before reconfiguring the device and queues. > > Because port multi-queue mode is changed from RSS to DCB. > > Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") > > Signed-off-by: Jie Wang > --- > v2: > * update commit log. > * remove RSS HASH offload from port->rx_conf[i].offloads. > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index a66dfb297c..661be341a0 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3948,6 +3948,9 @@ init_port_dcb_config(portid_t pid, > if (retval < 0) > return retval; > port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER; > + port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH; > + for (i = 0; i < nb_rxq; i++) > + rte_port->rx_conf[i].offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH; I think this change will effect DCB_ENABLED case also ( without VT). In that case RSS offload is allowed. Please check with configuration "port config 0 dcb vt off 4 pfc off". > > /* re-configure the device . */ > retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);