From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C5B4B2BAE for ; Tue, 11 Apr 2017 13:24:38 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 11 Apr 2017 04:24:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,185,1488873600"; d="scan'208";a="1133919065" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2017 04:24:36 -0700 To: "Hunt, David" , Jingjing Wu , dev@dpdk.org References: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com> From: Ferruh Yigit Message-ID: <8e43866c-b00a-ee0b-783f-7ba0f319a512@intel.com> Date: Tue, 11 Apr 2017 12:24:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix default PFC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 11:24:39 -0000 On 4/11/2017 11:11 AM, Hunt, David wrote: > > On 11/4/2017 8:35 AM, Jingjing Wu wrote: >> To keep consistent with previous release, PFC need to be disabled >> by default. This patch fixes it. >> >> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs") >> Signed-off-by: Jingjing Wu >> --- >> drivers/net/i40e/i40e_ethdev.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >> index 6927fde..3e640b3 100644 >> --- a/drivers/net/i40e/i40e_ethdev.c >> +++ b/drivers/net/i40e/i40e_ethdev.c >> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) >> hw->local_dcbx_config.pfc.willing = 0; >> hw->local_dcbx_config.pfc.pfccap = >> I40E_MAX_TRAFFIC_CLASS; >> - hw->local_dcbx_config.pfc.pfcenable = >> - I40E_DEFAULT_TCMAP; >> /* FW needs one App to configure HW */ >> hw->local_dcbx_config.numapps = 1; >> hw->local_dcbx_config.app[0].selector = > > This also fixes an issue I was having occasionally where traffic was not > forwarded by testpmd on my platform. In those cases I was seeing ~4770 > pps on one of the ports rather than the full rate (>20mpps). > A git bisect confirmed that this commit (6f0a707e5b55) was the source of > the issue. > > Tested-by: David Hunt Applied to dpdk-next-net/master, thanks. (problem described by Dave added into commit log)