From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7967C4C92 for ; Wed, 12 Sep 2018 12:55:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2018 03:55:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,364,1531810800"; d="scan'208";a="69394861" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37]) ([10.237.221.37]) by fmsmga007.fm.intel.com with ESMTP; 12 Sep 2018 03:54:54 -0700 To: Stephen Hemminger Cc: dev@dpdk.org, john.mcnamara@intel.com References: <20180830105422.1198-1-david.hunt@intel.com> <20180830105422.1198-6-david.hunt@intel.com> <20180830100100.7ddf8630@xeon-e3> From: "Hunt, David" Message-ID: <8e4465cd-6eb5-7664-b945-400b130cde74@intel.com> Date: Wed, 12 Sep 2018 11:54:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180830100100.7ddf8630@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1 5/7] examples/power: add json string handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 10:55:19 -0000 Hi Stephen, On 30/8/2018 6:00 PM, Stephen Hemminger wrote: > On Thu, 30 Aug 2018 11:54:20 +0100 > David Hunt wrote: > >> Add JSON string handling to vm_power_manager for JSON strings received >> through the fifo. The format of the JSON strings are detailed in the >> next patch, the vm_power_manager user guide documentation updates. >> >> This patch introduces a new dependency on Jansson, a C library for >> encoding, decoding and manipulating JSON data. To compile the sample app >> you now need to have installed libjansson4 and libjansson-dev (these may >> be named slightly differently depending on your Operating System) >> >> Signed-off-by: David Hunt > If you introduce new dependency then it has to be in documentation, > and off by default in Makefile, and checked in meson build. Sure, I've added a check in the Makefile for the existence of the library, and it will build in the JSON handling if present, otherwise warn the user and build without. Thanks, Dave.