From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B355A5F4D for ; Sat, 9 Jun 2018 11:29:38 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 55FB214005A; Sat, 9 Jun 2018 09:29:37 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 9 Jun 2018 10:29:31 +0100 To: Ferruh Yigit , Thomas Monjalon CC: , Shahaf Shuler , Wei Dai , Qi Zhang References: <20180531124431.13746-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Message-ID: <8e87a4f4-ae17-d39c-e1bc-0ba0fb1fb85e@solarflare.com> Date: Sat, 9 Jun 2018 12:29:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23896.003 X-TM-AS-Result: No--12.100200-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1528536578-RMkB-860AfCa Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2018 09:29:38 -0000 On 06/08/2018 10:51 PM, Ferruh Yigit wrote: > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: >> The error path was disabled in previous release to let apps to be more >> flexible. >> >> But this release they are enabled, applications have to obey offload API >> rules otherwise they will get errors from following APIs: >> rte_eth_dev_configure >> rte_eth_rx_queue_setup >> rte_eth_tx_queue_setup >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Shahaf Shuler >> Cc: Wei Dai >> Cc: Qi Zhang >> Cc: Andrew Rybchenko > Any objection to this patch? > I really would like to get this early to catch any possible issue. I think it should be pushed just after old offload API removal since if it is pushed before, it should take old offload API into account in Tx queue setup function. Acked-by: Andrew Rybchenko