From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by dpdk.org (Postfix) with ESMTP id 9A12E1BB8C for ; Thu, 12 Apr 2018 09:38:30 +0200 (CEST) Received: from [IPv6:2001:67c:1220:c1a2:c80a:c42c:82c9:56ca] (unknown [IPv6:2001:67c:1220:c1a2:c80a:c42c:82c9:56ca]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 1AF8440005D; Thu, 12 Apr 2018 09:38:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2; t=1523518710; bh=rrHlrPw9kWK+qXW42byQBALMfXf//OzHghg+X0mqKNk=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ovmw6GWwsU+G8K6eLlHF+ijkd5CNr11E0v0n4mCER7nuN8HtXDlQctHEltbKFvtXo wwhcpLA5wwtkKIKgIXWjxf9mWJrpsTFdP4t1GQbgnayYMrvLc3JqCd/zt2suUxnrGo /g7D0s06QHjIFG707xZ1aH+Q7N4QcPhBeh4gVSHo= To: Ferruh Yigit , dev@dpdk.org Cc: remes@netcope.com, Yasufumi Ogawa References: <1523023929-1257-1-git-send-email-vido@cesnet.cz> <1523023929-1257-2-git-send-email-vido@cesnet.cz> <26c45c25-7eb1-fd62-f0ef-0e1d929a80f8@intel.com> <7ea9c0b5-4d69-e473-95ef-eb43b5bebe59@cesnet.cz> <0ba99f11-b2b0-c86f-2308-cda28d401295@intel.com> From: Matej Vido Message-ID: <8ea96dcd-da70-084e-7b82-6bc4ca85bee1@cesnet.cz> Date: Thu, 12 Apr 2018 09:38:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <0ba99f11-b2b0-c86f-2308-cda28d401295@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 07:38:30 -0000 On 11.04.2018 12:51, Ferruh Yigit wrote: > On 4/11/2018 10:36 AM, Matej Vido wrote: >> On 10.04.2018 17:28, Ferruh Yigit wrote: >>> On 4/6/2018 3:12 PM, Matej Vido wrote: >>>> NFB cards employ multiple Ethernet ports. >>>> Until now, Ethernet port-related operations were performed on all of them >>>> (since the whole card was represented as a single port). >>>> With new NFB-200G2QL card, this is no longer viable. >>>> >>>> Since there is no fixed mapping between the queues and Ethernet ports, >>>> and since a single card can be represented as two ports in DPDK, >>>> there is no way of telling which (if any) physical ports should be >>>> associated with individual ports in DPDK. >>>> >>>> This is also described in documentation in more detail. >>>> >>>> Signed-off-by: Matej Vido >>>> Signed-off-by: Jan Remes >>>> --- >>>> config/common_base | 5 - >>>> .../nics/img/szedata2_nfb200g_architecture.svg | 171 +++++++++++ >>> Hi Matej, >>> >>> This patch fails to apply [1], can you please confirm you can apply it? >>> >>> [1] >>> $ git apply --check >>> dpdk-dev-1-3-net-szedata2-do-not-affect-Ethernet-interfaces.patch >>> error: corrupt patch at line 270 >> Hi Ferruh, >> >> I've got same error on patch downloaded from patchwork. It seems that >> the difference between the downloaded patch and the patch generated from >> git is that the long lines in svg file are split into multiple lines in >> the patch downloaded from patchwork. I suppose this could be the >> problem. Any idea how to send a patch containing svg file correctly? > cc'ed Ogawa-san for support, > > I remember he fixed similar issue in the past for spp, but I don't remember how? Anyways I've hopefully fixed this by redrawing the image to avoid those long lines. I'm sending v2. Thanks, Matej > >> Thanks, >> Matej >>