DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix MAC address when one port resets
Date: Sat, 4 Apr 2020 10:07:22 -0400
Message-ID: <8eb94e8b-f918-cdcb-bc5f-b8023cf5a4e4@gmail.com> (raw)
In-Reply-To: <20200225092903.38455-3-huwei013@chinasoftinc.com>

The behavior is probably going to be inconsistent. Only one of the calls
to mac_address_slaves_update() is checked for failure. The two calls
are in bond_ethdev_lsc_event_callback()

                 if (internals->active_slave_count < 1) {
                         mac_address_slaves_update(bonded_eth_dev);

and in bond_ethdev_start():

         /* Update all slave devices MACs*/
         if (mac_address_slaves_update(eth_dev) != 0)
                 goto out_err;

So if the bond device is running, you safely fail to the backup device.
But if you stop and start the bond device, it will then fail to start?

What devices are you bonding together that aren't able to support
changing their MAC addresses reliably? ixgbe VF devices by any chance?
One solution is to always assume success or ignore the error from devices
that you know are not an issue. I agree that we shouldn't early exit
from mac_address_slaves_update(). I am not sure how to handle the error.

We probably shouldn't allow you to bond devices that don't support setting
MAC address. I don't think this check exists currently. That's possibly
one reason for this check.

On 2/25/20 4:29 AM, Wei Hu (Xavier) wrote:
 > From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
 >
 > Currently, based on a active-backup bond device, in the following 2 
cases:
 > 1) The primary port resets. The link status of the primary port changes
 >     from up to down.
 > 2) When switching the active port, one slave port resets at the same 
time.
 > one slave port changes to the primary port, but the new primary 
port's MAC
 > address probably cannot change to the bond device's MAC address. And we
 > can't continue receive packets whose destination MAC addresses are 
the same
 > as the bond devices's MAC address.
 >
 > The current bonding PMD driver call mac_address_slaves_update function to
 > modify the MAC address of all slaves devices. In 
mac_address_slaves_update
 > function, the rte_eth_dev_default_mac_addr_set API function is called to
 > set the MAC address of the slave devices in turn in the for loop 
statement.
 >
 > When one port reset, calling rte_eth_dev_default_mac_addr_set API fails
 > because the firmware will not respond to the commands from the driver,
 > and exit the loop, so other slave devices cannot continue to update the
 > MAC address.
 >
 > This patch fixes the issue by avoid exiting the loop when calling
 > rte_eth_dev_default_mac_addr_set fails.
 >
 > Fixes: 2efb58cbab6e ("bond: new link bonding library")
 > Cc: stable@dpdk.org
 >
 > Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
 > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
 > Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
 > Signed-off-by: Xuan Li <lixuan47@hisilicon.com>
 > ---
 >   drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++++--
 >   1 file changed, 6 insertions(+), 2 deletions(-)
 >
 > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c 
b/drivers/net/bonding/rte_eth_bond_pmd.c
 > index ddae3518c..ba3f342e7 100644
 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
 > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
 > @@ -1502,6 +1502,7 @@ int
 >   mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
 >   {
 >   	struct bond_dev_private *internals = 
bonded_eth_dev->data->dev_private;
 > +	bool setted;
 >   	int i;
 >
 >   	/* Update slave devices MAC addresses */
 > @@ -1529,6 +1530,7 @@ mac_address_slaves_update(struct rte_eth_dev 
*bonded_eth_dev)
 >   	case BONDING_MODE_TLB:
 >   	case BONDING_MODE_ALB:
 >   	default:
 > +		setted = true;
 >   		for (i = 0; i < internals->slave_count; i++) {
 >   			if (internals->slaves[i].port_id ==
 >   					internals->current_primary_port) {
 > @@ -1537,7 +1539,7 @@ mac_address_slaves_update(struct rte_eth_dev 
*bonded_eth_dev)
 >   						bonded_eth_dev->data->mac_addrs)) {
 >   					RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
 >   							internals->current_primary_port);
 > -					return -1;
 > +					setted = false;
 >   				}
 >   			} else {
 >   				if (rte_eth_dev_default_mac_addr_set(
 > @@ -1545,10 +1547,12 @@ mac_address_slaves_update(struct rte_eth_dev 
*bonded_eth_dev)
 >   						&internals->slaves[i].persisted_mac_addr)) {
 >   					RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
 >   							internals->slaves[i].port_id);
 > -					return -1;
 > +					setted = false;
 >   				}
 >   			}
 >   		}
 > +		if (!setted)
 > +			return -1;
 >   	}
 >
 >   	return 0;
 >

  reply	other threads:[~2020-04-04 14:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  9:29 [dpdk-dev] [PATCH 0/2] fixes for bonding Wei Hu (Xavier)
2020-02-25  9:29 ` [dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port Wei Hu (Xavier)
2020-02-27 17:03   ` Ferruh Yigit
2020-02-28  1:31     ` Wei Hu (Xavier)
2020-03-02  0:58       ` Wei Hu (Xavier)
2020-02-25  9:29 ` [dpdk-dev] [PATCH 2/2] net/bonding: fix MAC address when one port resets Wei Hu (Xavier)
2020-04-04 14:07   ` Chas Williams [this message]
2020-04-17  5:56     ` Wei Hu (Xavier)
2020-03-17  8:56 ` [dpdk-dev] [PATCH 0/2] fixes for bonding Wei Hu (Xavier)
2020-03-28  0:32 ` Wei Hu (Xavier)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eb94e8b-f918-cdcb-bc5f-b8023cf5a4e4@gmail.com \
    --to=3chas3@gmail.com \
    --cc=dev@dpdk.org \
    --cc=huwei013@chinasoftinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git