From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: niklas.soderlund@corigine.com,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 12/12] net/nfp: add flower PF rxtx logic
Date: Thu, 23 Jun 2022 15:36:32 +0300 [thread overview]
Message-ID: <8ecb1f8d-f073-f51b-5e12-5057758a54f8@oktetlabs.ru> (raw)
In-Reply-To: <1655807588-7320-13-git-send-email-chaoyong.he@corigine.com>
On 6/21/22 13:33, Chaoyong He wrote:
> This commit implements the flower Rx logic. Fallback packets are
> multiplexed to the correct representor port based on the prepended
> metadata. The Rx poll is set to run on the existing service
> infrastructure.
>
> For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths
> distinct. Flower fallback also adds 8 bytes of metadata to the start of
> the packet that has to be adjusted for in the Tx descriptor.
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
[snip]
> + if (unlikely(pkt->nb_segs > 1 &&
> + !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) {
> + PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set");
> + rte_panic("Multisegment packet unsupported\n");
checkpatches.sh warnings about it [1]. Please, rework code to
avoid usage of rte_panic().
[1] http://mails.dpdk.org/archives/test-report/2022-June/290996.html
> + }
[snip]
prev parent reply other threads:[~2022-06-23 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:32 [PATCH v2 00/12] preparation for the rte_flow offload of nfp PMD Chaoyong He
2022-06-21 10:32 ` [PATCH v2 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-06-21 10:32 ` [PATCH v2 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-06-21 10:32 ` [PATCH v2 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-06-21 10:33 ` [PATCH v2 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-06-21 10:33 ` [PATCH v2 05/12] net/nfp: add flower PF setup and mempool init logic Chaoyong He
2022-06-21 10:33 ` [PATCH v2 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-06-21 10:33 ` [PATCH v2 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-06-21 10:33 ` [PATCH v2 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-06-21 10:33 ` [PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-06-23 12:36 ` Andrew Rybchenko
2022-06-21 10:33 ` [PATCH v2 10/12] net/nfp: add flower representor framework Chaoyong He
2022-06-21 10:33 ` [PATCH v2 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-06-21 10:33 ` [PATCH v2 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
2022-06-23 12:36 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ecb1f8d-f073-f51b-5e12-5057758a54f8@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=niklas.soderlund@corigine.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).