From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1CCBCA0093;
	Thu, 23 Jun 2022 14:36:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9DD0F40E2D;
	Thu, 23 Jun 2022 14:36:34 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5272440E2D
 for <dev@dpdk.org>; Thu, 23 Jun 2022 14:36:33 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 12E37AD;
 Thu, 23 Jun 2022 15:36:33 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 12E37AD
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1655987793;
 bh=aGUwNH1ZRSl9JIPOQy+h1gAnHC0tT/GtnA29msFZtqU=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=eARSnFJ75LIX8NXcPUfwgHQr5lsuff55YfVXM8TrbcxcB6uv3EG3/BSy7HnwPeC2e
 f0h8G3/HGk3hHU37VjrFNe8oagCvNLNl5yQNb6o28jt0X7VlQh463lFADmkiggD1Ey
 I8eR9PzeNCS/1aeAg8CAF5EZppJgDK43gJ7aUKus=
Message-ID: <8ecb1f8d-f073-f51b-5e12-5057758a54f8@oktetlabs.ru>
Date: Thu, 23 Jun 2022 15:36:32 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 12/12] net/nfp: add flower PF rxtx logic
Content-Language: en-US
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: niklas.soderlund@corigine.com, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
References: <1655807588-7320-1-git-send-email-chaoyong.he@corigine.com>
 <1655807588-7320-13-git-send-email-chaoyong.he@corigine.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <1655807588-7320-13-git-send-email-chaoyong.he@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/21/22 13:33, Chaoyong He wrote:
> This commit implements the flower Rx logic. Fallback packets are
> multiplexed to the correct representor port based on the prepended
> metadata. The Rx poll is set to run on the existing service
> infrastructure.
> 
> For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths
> distinct. Flower fallback also adds 8 bytes of metadata to the start of
> the packet that has to be adjusted for in the Tx descriptor.
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

[snip]

> +		if (unlikely(pkt->nb_segs > 1 &&
> +				!(hw->cap & NFP_NET_CFG_CTRL_GATHER))) {
> +			PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set");
> +			rte_panic("Multisegment packet unsupported\n");

checkpatches.sh warnings about it [1]. Please, rework code to
avoid usage of rte_panic().

[1] http://mails.dpdk.org/archives/test-report/2022-June/290996.html

> +		}

[snip]