From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 73BC71B217
 for <dev@dpdk.org>; Tue,  9 Jan 2018 20:59:47 +0100 (CET)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 1333660005B; Tue,  9 Jan 2018 19:59:46 +0000 (UTC)
Received: from [192.168.239.128] (188.242.181.57) by ocex03.SolarFlarecom.com
 (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25;
 Tue, 9 Jan 2018 11:59:43 -0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>
References: <1515418535-16575-1-git-send-email-arybchenko@solarflare.com>
 <cc8fc312-e581-1893-8ba6-88e20d17e55a@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com>
Date: Tue, 9 Jan 2018 22:59:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <cc8fc312-e581-1893-8ba6-88e20d17e55a@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [188.242.181.57]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ocex03.SolarFlarecom.com (10.20.40.36)
X-MDID: 1515527986-6Q4GSx9e-vwy
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: change license to
 BSD-3-Clause
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 19:59:47 -0000

On 01/09/2018 10:38 PM, Ferruh Yigit wrote:
> On 1/8/2018 1:35 PM, Andrew Rybchenko wrote:
>> Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause.
>> Bump copyright year.
>>
> <...>
>
>> @@ -1,28 +1,8 @@
>> +   SPDX-License-Identifier: BSD-3-Clause
>>   
>> -   Copyright (c) 2006-2016 Solarflare Communications Inc.
>> +   Copyright (c) 2006-2018 Solarflare Communications Inc.
>>      All rights reserved.
> Defined syntax has no empty line between SPDX and Copyright line, is that line
> intentionally left?

Yes. I've seen examples, but have not found exact requirement to have
no empty line. We have file with 2 copyright holders and it looks strange
in this case without empty line.

> And not sure if this cause any problem on scripting license checks in the future...

Of course this empty line is not that critical and I can remove it if 
required.

> <...>