From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6B36D68D1 for ; Fri, 30 Sep 2016 12:45:25 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 30 Sep 2016 03:45:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,272,1473145200"; d="scan'208";a="885408719" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by orsmga003.jf.intel.com with ESMTP; 30 Sep 2016 03:45:24 -0700 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org References: <1475144449-22176-1-git-send-email-3chas3@gmail.com> <1475144449-22176-5-git-send-email-3chas3@gmail.com> Cc: harish.patil@qlogic.com From: Ferruh Yigit Message-ID: <8ee01f60-b3ac-bcb2-c7c5-af66e84cc647@intel.com> Date: Fri, 30 Sep 2016 11:45:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475144449-22176-5-git-send-email-3chas3@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 05/10] bnx2x: Restrict RX mask flags sent to the PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 10:45:25 -0000 On 9/29/2016 11:20 AM, Chas Williams wrote: > Don't use bnx2x_fill_accept_flags() to fill the RX mask in the VF > since the PF only handles a subset of the existing flags. now, > bnx2x_fill_accept_flags() can be static. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3@gmail.com> <...> > diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c > index 1c895f8..ecd4a7d 100644 > --- a/drivers/net/bnx2x/bnx2x_vfpf.c > +++ b/drivers/net/bnx2x/bnx2x_vfpf.c > @@ -576,7 +576,6 @@ bnx2x_vf_set_rx_mode(struct bnx2x_softc *sc) > { > struct vf_set_q_filters_tlv *query; > struct vf_common_reply_tlv *reply = &sc->vf2pf_mbox->resp.common_reply; > - unsigned long tx_mask; > > query = &sc->vf2pf_mbox->query[0].set_q_filters; > bnx2x_init_first_tlv(sc, &query->first_tlv, BNX2X_VF_TLV_SET_Q_FILTERS, > @@ -585,7 +584,27 @@ bnx2x_vf_set_rx_mode(struct bnx2x_softc *sc) > query->vf_qid = 0; > query->flags = BNX2X_VF_RX_MASK_CHANGED; > > - if (bnx2x_fill_accept_flags(sc, sc->rx_mode, &query->rx_mask, &tx_mask)) { > + switch (sc->rx_mode) { > + case BNX2X_RX_MODE_NONE: /* no Rx */ > + query->rx_mask = VFPF_RX_MASK_ACCEPT_NONE; > + break; > + case BNX2X_RX_MODE_NORMAL: > + query->rx_mask = VFPF_RX_MASK_ACCEPT_MATCHED_MULTICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_MATCHED_UNICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_BROADCAST; > + break; > + case BNX2X_RX_MODE_ALLMULTI: > + query->rx_mask = VFPF_RX_MASK_ACCEPT_ALL_MULTICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_MATCHED_UNICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_BROADCAST; > + break; > + case BNX2X_RX_MODE_PROMISC: > + query->rx_mask = VFPF_RX_MASK_ACCEPT_ALL_UNICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_ALL_MULTICAST; > + query->rx_mask |= VFPF_RX_MASK_ACCEPT_BROADCAST; > + break; > + default: > + PMD_DRV_LOG(ERR, "BAD rx mode (%d)", mode); "mode" is not defined in this function, enabling debug log is giving following compilation error: .../drivers/net/bnx2x/bnx2x_vfpf.c:657:40: error: ‘mode’ undeclared (first use in this function) PMD_DRV_LOG(ERR, "BAD rx mode (%d)", mode); ^