From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com
Cc: stable@dpdk.org, Yu Jiang <yux.jiang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix virtqueue initialization
Date: Mon, 9 Nov 2020 19:39:42 +0100 [thread overview]
Message-ID: <8ee41602-9275-c223-33bb-9b773d3dec77@redhat.com> (raw)
In-Reply-To: <d22f8483-fe5d-8b8a-f50e-48bbcee3f672@intel.com>
On 11/9/20 7:37 PM, Ferruh Yigit wrote:
> On 11/6/2020 2:47 PM, Maxime Coquelin wrote:
>> This patches fixes virtqueue initialization issue causing
>> segfault or file descriptor being closed unexpectedly.
>>
>> The wrong index was passed to init_vring_queue() by
>> alloc_vring_queue() when a hole in the virtqueue array was
>> met.
>>
>> Fixes: 8acd7c213353 ("vhost: fix virtqueues metadata allocation")
>> Cc: stable@dpdk.org
>>
>
> Since the issue is introduced in this release, there is nothing to
> backport and stable tag is not required, removing it in next-net.
I cc'ed stable because it is fixing a fix that was stable candidate.
>> Reported-by: Yu Jiang <yux.jiang@intel.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/vhost.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
>> index 8a151a9c1d..b83cf639eb 100644
>> --- a/lib/librte_vhost/vhost.c
>> +++ b/lib/librte_vhost/vhost.c
>> @@ -605,7 +605,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t
>> vring_idx)
>> }
>> dev->virtqueue[i] = vq;
>> - init_vring_queue(dev, vring_idx);
>> + init_vring_queue(dev, i);
>> rte_spinlock_init(&vq->access_lock);
>> vq->avail_wrap_counter = 1;
>> vq->used_wrap_counter = 1;
>>
>
next prev parent reply other threads:[~2020-11-09 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 14:47 Maxime Coquelin
2020-11-06 15:56 ` David Marchand
2020-11-09 5:09 ` Jiang, YuX
2020-11-09 18:38 ` Ferruh Yigit
2020-11-09 16:31 ` Maxime Coquelin
2020-11-09 18:37 ` Ferruh Yigit
2020-11-09 18:39 ` Maxime Coquelin [this message]
2020-11-09 18:40 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee41602-9275-c223-33bb-9b773d3dec77@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).