From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 458C2A0588; Tue, 21 Apr 2020 11:50:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C5751D97A; Tue, 21 Apr 2020 11:50:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8C1C91D95C for ; Tue, 21 Apr 2020 11:50:50 +0200 (CEST) IronPort-SDR: /dKIZfxLWXdqIJds7T4G8aUhagkPapFVipa5Uya8Gi6TNVLd4gWfaDLyN/7Ub2IZHomnMCEThX Rl+aLCHePieg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 02:50:49 -0700 IronPort-SDR: QJzJAyPvbBiyl4bZoS2lTvILlzbgbl3H0afvtFamtHHsv+RoDoiuYL/W/I7suzBMQPIdyCEUTp QOE9fkbXN3ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,409,1580803200"; d="scan'208";a="255242976" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.208.123]) ([10.213.208.123]) by orsmga003.jf.intel.com with ESMTP; 21 Apr 2020 02:50:48 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Tal Shnaiderman , bruce.richardson@intel.com, david.marchand@redhat.com References: <3278563.U75o6juQT5@thomas> <6e66deb1-e952-9e9c-81c1-dc51fc1326c4@intel.com> <3834383.y1PWrYsiD0@thomas> From: "Burakov, Anatoly" Message-ID: <8eeb979d-0beb-fe80-757a-3769d17c2992@intel.com> Date: Tue, 21 Apr 2020 10:50:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <3834383.y1PWrYsiD0@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Apr-20 6:39 PM, Thomas Monjalon wrote: > 20/04/2020 16:07, Burakov, Anatoly: >> On 19-Apr-20 2:10 PM, Thomas Monjalon wrote: >>> 19/04/2020 15:09, Thomas Monjalon: >>>> 17/04/2020 16:09, Burakov, Anatoly: >>>>> On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: >>>>>> On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: >>>>>>> Hi Anatoly, >>>>>>> >>>>>>> I’m working on the implementation of bus/pci driver for Windows, >>>>>>> pci_common.c uses the titled functions however they are relevant only >>>>>>> for Linux OS. >>>>>>> >>>>>>> I’m wondering if the implementation of those functions should be moved >>>>>>> to a Linux specific area since FreeBSD (and now Windows) are forced to >>>>>>> implemented those in the current state. >>>>> >>>>> Unfortunately, we don't have a generic API for these, but since we >>>>> export a single API on all platforms, either all platforms have to >>>>> implement these functions, or none of them do. There's simply no way to >>>>> avoid implementing stubs for these functions, short of coming up with a >>>>> generic API that would replace these. Given that this API is heavily >>>>> Linux specific, i don't see that happening. >>>> >>>> Because it is Linux specific, we should not force FreeBSD and Windows >>>> having stubs. Can we move VFIO calls in Linux-specific files? >>>> >>>> I think rte_vfio.h should be moved in lib/librte_eal/linux/include. >>> >>> +Cc Bruce and David >> >> ...and have a Linux-specific ABI? > > Yes, the ABI is different depending on arch and OS. > That's a fact, and I don't see any problem with it. > OK, no objections then :) -- Thanks, Anatoly