From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0736DA04B1; Mon, 5 Oct 2020 20:52:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D07FD1B67B; Mon, 5 Oct 2020 20:52:29 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 72CCF1B677 for ; Mon, 5 Oct 2020 20:52:27 +0200 (CEST) IronPort-SDR: LogOTQF/96UUoo2uf8Lo4hfoLA6dALDbh1oBRLspK7yjzN/fX8De2vr2ekFIwJSY1goPlJZCGS IVlA9MFs90lQ== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="227977798" X-IronPort-AV: E=Sophos;i="5.77,340,1596524400"; d="scan'208";a="227977798" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 11:52:17 -0700 IronPort-SDR: XMVFqtIeNbUsY5jZkXe2paC2RutAjHGgjc9/izWvkWcIb5JcNibsFFNpa85NYK+8QwpHIV+2aj z+el4zOaNgaA== X-IronPort-AV: E=Sophos;i="5.77,340,1596524400"; d="scan'208";a="526401010" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.105]) ([10.213.225.105]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 09:26:47 -0700 To: Hariprasad Govindharajan , dev@dpdk.org References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> <1601914708-27552-1-git-send-email-hariprasad.govindharajan@intel.com> From: Ferruh Yigit Message-ID: <8ef8c5ce-f5dd-79f4-9c5d-c65ccd53e7e6@intel.com> Date: Mon, 5 Oct 2020 17:26:15 +0100 MIME-Version: 1.0 In-Reply-To: <1601914708-27552-1-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2020 5:18 PM, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. > > Before building this module, the user is expected to build the > DPDK using meson build system and make sure that the required > libraries are installed in the path /usr/local > > The source code for igb_uio module is available in this git repository > https://git.dpdk.org/dpdk-kmods/. Once this repository is cloned, the > module can be built using this Makefile Can you update patch title as [DPDK-KMOD PATCH v#] to highlight the target repo is different? > > Signed-off-by: Hariprasad Govindharajan > --- > linux/igb_uio/Makefile | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 linux/igb_uio/Makefile > > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile > new file mode 100644 > index 0000000..fc5cefc > --- /dev/null > +++ b/linux/igb_uio/Makefile > @@ -0,0 +1,8 @@ > +DPDK_HEADERS ?= /usr/local/include > +RTE_KERNELDIR ?= `uname -r` Can you please use the variable for full path, so that the user can set a custom path for kernel directory. Like: RTE_KERNELDIR ?= /lib/modules/$(RTE_KERNELDIR)/build/ make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR) M=$(PWD) > + > +all: > + make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C /lib/modules/$(RTE_KERNELDIR)/build/ M=$(PWD) > + > +clean: > + make -C /lib/modules/$(RTE_KERNELDIR)/build M=$(PWD) clean >