From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B771FA0A0A;
Fri, 22 Jan 2021 13:12:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9B379140F4B;
Fri, 22 Jan 2021 13:12:59 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id 1B832140F3F;
Fri, 22 Jan 2021 13:12:57 +0100 (CET)
IronPort-SDR: PXmbD3sUGGDxL6eK+df+Y8+RhGxp2akbacngQgCLZX0K0hh6iigE1He0JXQ/kPPvbDLtCxHURV
pt4QQz++S0bQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="178659143"
X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="178659143"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Jan 2021 04:12:57 -0800
IronPort-SDR: PVki7Jl9aVhAvldSgQVWEsftnHbI+xsuzkjJclMYoS12Unxf0vJvKAqD9OiQPm9Ih4FbMwVYAE
uxejf28WBpJA==
X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="357003435"
Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.25.114])
([10.213.25.114])
by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Jan 2021 04:12:55 -0800
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
References: <20210120135556.33763-2-david.hunt@intel.com>
<20210121172201.22582-1-david.hunt@intel.com>
<20210121172201.22582-3-david.hunt@intel.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <8f005e4d-644c-4047-13d2-f2542686b29f@intel.com>
Date: Fri, 22 Jan 2021 12:12:53 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20210121172201.22582-3-david.hunt@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 2/6] power: make channel msg functions
public
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 21-Jan-21 5:21 PM, David Hunt wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
>
> Move the 2 public functions into rte_power_guest_channel.h
>
> Fixes: 210c383e247b ("power: packet format for vm power management")
> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
>
> ---
> changes in v3
> * Mark both added functions as experimental
> changes in v4
> * add @internal tag for Doxygen
> * add @warning EXPERIMENTAL tag for Doxygen
> * improve description of lcore param
> ---
> lib/librte_power/guest_channel.h | 40 +----------------
> lib/librte_power/rte_power_guest_channel.h | 50 ++++++++++++++++++++++
> 2 files changed, 51 insertions(+), 39 deletions(-)
>
> diff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h
> index d3d87f0ae..69020b030 100644
> --- a/lib/librte_power/guest_channel.h
> +++ b/lib/librte_power/guest_channel.h
> @@ -65,21 +65,7 @@ void guest_channel_host_disconnect(unsigned int lcore_id);
> */
> int guest_channel_send_msg(struct channel_packet *pkt, unsigned int lcore_id);
>
> -/**
> - * Send a message contained in pkt over the Virtio-Serial to the host endpoint.
> - *
> - * @param pkt
> - * Pointer to a populated struct channel_packet
> - *
> - * @param lcore_id
> - * lcore_id.
> - *
> - * @return
> - * - 0 on success.
> - * - Negative on error.
> - */
> -int rte_power_guest_channel_send_msg(struct channel_packet *pkt,
> - unsigned int lcore_id);
> +
>
Nitpick but you left an extra newline there :) can probably be fixed on
apply, so
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly