From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Jiang, YuX" <yux.jiang@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Michal Krawczyk <mk@semihalf.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag
Date: Fri, 22 Oct 2021 16:20:29 +0100 [thread overview]
Message-ID: <8f1804a8-b53a-bb50-6701-e7afd77e8b8d@intel.com> (raw)
In-Reply-To: <SJ0PR11MB5150B06F4BD0E1923667C9D9FE809@SJ0PR11MB5150.namprd11.prod.outlook.com>
On 10/22/2021 3:10 PM, Jiang, YuX wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: 2021年10月22日 20:57
>> To: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Hyong Youb
>> Kim <hyonkim@cisco.com>; Michal Krawczyk <mk@semihalf.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Somnath Kotur
>> <somnath.kotur@broadcom.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload
>> flag
>>
>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo
>> frame decisions based on MTU value checks, but some of the checks were
>> wrong by mistake, causing device initialization to fail, fixing them.
>>
>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Tested-by: Yu Jiang <YuX.Jiang@intel.com>
> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable)
> Tested on i40e(iavf) and it looks good, will test more on others.
>
Thanks Yu,
I can see it is not fully validated, and most likely it won't be
before -rc1, but it would be good to have this fix for -rc1 to not
block testing.
Since the previous code is clearly wrong, and fixes are similar
between drivers, if one is good I will take risk and merge
the fix for -rc1.
next prev parent reply other threads:[~2021-10-22 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 12:17 [dpdk-dev] [PATCH] ethdev: " Ferruh Yigit
2021-10-22 12:23 ` Andrew Rybchenko
2021-10-22 12:27 ` Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag Ferruh Yigit
2021-10-22 14:10 ` Jiang, YuX
2021-10-22 15:20 ` Ferruh Yigit [this message]
2021-10-22 15:46 ` Ferruh Yigit
2021-10-22 15:55 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f1804a8-b53a-bb50-6701-e7afd77e8b8d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=hyonkim@cisco.com \
--cc=jingjing.wu@intel.com \
--cc=mk@semihalf.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).