From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7526CA00C5; Mon, 6 Jul 2020 17:57:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26CAE1DB3C; Mon, 6 Jul 2020 17:57:37 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id C8FDC1DB2B for ; Mon, 6 Jul 2020 17:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594051055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TQmV+ClaSHA2oD3nOSNSMfMDQpR653SPwtvZAFaCSY4=; b=YXMeB5w0KZe0M3520mAOWI+IdjQzxdFpcHKtuL4LkKlFNRDtlaiK8GSfJRWK+uCu+vb1Ve 7yLL/bfh2o5swa6K1udq+WKWCxPAPDFyEHQpWkrruY6LoVQMvNDZYaonUhqeasKe4u0923 c3sBrhkD7gX2HiR4fDa+xi2FVxPywJ0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-AQx-ZEiOMmOv5KMvKpEYEw-1; Mon, 06 Jul 2020 11:57:25 -0400 X-MC-Unique: AQx-ZEiOMmOv5KMvKpEYEw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2969419057A1; Mon, 6 Jul 2020 15:57:23 +0000 (UTC) Received: from [10.33.37.18] (unknown [10.33.37.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9019E7B414; Mon, 6 Jul 2020 15:57:18 +0000 (UTC) From: Kevin Traynor To: "Stokes, Ian" , "Govindharajan, Hariprasad" , "stable@dpdk.org" , "Loftus, Ciara" Cc: "dev@dpdk.org" , Abhishek Marathe , Akhil Goyal , Ali Alnubani , "Walker, Benjamin" , David Christensen , Hemant Agrawal , Jerin Jacob , "Mcnamara, John" , Ju-Hyoung Lee , Luca Boccassi , Pei Zhang , "Yu, PingX" , "Xu, Qian Q" , Raslan Darawsheh , Thomas Monjalon , "Peng, Yuan" , "Chen, Zhaoyan" References: <20200626125306.7382-1-ktraynor@redhat.com> <7b8f79ea-2cea-3222-1a3b-d84dd7247329@redhat.com> <52156197ADF84D4FB1B836FA75938A8918E9B19F@IRSMSX103.ger.corp.intel.com> Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <8f20a7c6-3a54-4f7b-56d6-6f59d3220cac@redhat.com> Date: Mon, 6 Jul 2020 16:57:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] 18.11.9 (LTS) patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/06/2020 18:03, Kevin Traynor wrote: > On 30/06/2020 17:32, Stokes, Ian wrote: >> >>> -----Original Message----- >>> From: Kevin Traynor >>> Sent: Tuesday, June 30, 2020 5:21 PM >>> To: Govindharajan, Hariprasad ; >>> stable@dpdk.org; Stokes, Ian ; Loftus, Ciara >>> >>> Cc: dev@dpdk.org; Abhishek Marathe ; >>> Akhil Goyal ; Ali Alnubani ; >>> Walker, Benjamin ; David Christensen >>> ; Hemant Agrawal ; >>> Jerin Jacob ; Mcnamara, John >>> ; Ju-Hyoung Lee ; Luca >>> Boccassi ; Pei Zhang ; Yu, PingX >>> ; Xu, Qian Q ; Raslan Darawsheh >>> ; Thomas Monjalon ; Peng, >>> Yuan ; Chen, Zhaoyan >>> Subject: Re: [dpdk-dev] 18.11.9 (LTS) patches review and test >>> >>> On 30/06/2020 16:38, Govindharajan, Hariprasad wrote: >>>> >>>>> -----Original Message----- >>>>> From: dev On Behalf Of Kevin Traynor >>>>> Sent: Friday, June 26, 2020 1:53 PM >>>>> To: stable@dpdk.org >>>>> Cc: dev@dpdk.org; Abhishek Marathe ; >>>>> Akhil Goyal ; Ali Alnubani >>>>> ; Walker, Benjamin ; >>>>> David Christensen ; Hemant Agrawal >>>>> ; Stokes, Ian ; Jerin >>>>> Jacob ; Mcnamara, John ; >>>>> Ju-Hyoung Lee ; Kevin Traynor >>>>> ; Luca Boccassi ; Pei Zhang >>>>> ; Yu, PingX ; Xu, Qian Q >>>>> ; Raslan Darawsheh ; >>>>> Thomas Monjalon ; Peng, Yuan >>>>> ; Chen, Zhaoyan >>>>> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test >>>>> >>>>> Hi all, >>>>> >>>>> Here is a list of patches targeted for LTS release 18.11.9. >>>>> >>>>> The planned date for the final release is 3rd July. >>>>> >>>>> Please help with testing and validation of your use cases and report >>>>> any issues/results with reply-all to this mail. For the final release >>>>> the fixes and reported validations will be added to the release notes. >>>>> >>>>> A release candidate tarball can be found at: >>>>> >>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2 >>>>> >>>>> These patches are located at branch 18.11 of dpdk-stable repo: >>>>> https://dpdk.org/browse/dpdk-stable/ >>>>> >>>>> rc2: >>>>> Creating this to include important VF fix. >>>>> http://inbox.dpdk.org/dev/20200625035046.19820-1- >>>>> haiyue.wang@intel.com/ >>>>> >>>>> New patches in rc2: >>>>> 145bb0e780 bus/pci: fix VF memory access >>>>> 420a437247 net/tap: fix mbuf double free when writev fails >>>>> >>>>> Thanks. >>>>> >>>>> Kevin. >>>> [Govindharajan, Hariprasad] Hi Kevin, >>>> >>> Hi G Hariprasad, >>> >>> Thanks for testing. >>> >>>> The following performance and functional tests carried out with ixgbe, >>>> i40e and vhost devices >>>> >>>> DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12 >>>> >>>> P2p throughput >>>> P2p multi queue >>>> PVP rss >>>> vHost reconnect >>>> Flow control >>>> >>>> Zero copy feature could not be tested. >>>> From ovs, zero copy is used only vhost user client. So this particular patch >>> 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy >>> support in ovs. >>>> so for ovs to move to support 18.11.9, it should probably remove support for >>> zero-copy in the ovs code base? >>> The code says that zero copy is incompatible with vhost client mode. >>> It seems that the check for client/server was incorrect, and now it is fixed and >>> correctly detects this incompatible combination and returns an error to OVS. >>> >>> I don't think we can call that breaking. It was previously incompatible also, it just >>> didn't return an error as there was a bug. >>> >>> I don't see an issue with having this patch and the new behaviour. >>> >>> Ian/Ciara, let me know if I'm missing something. >> I think OVS only supports zero copy for vhostuserclient devices. In this case it looks like that’s no longer supported. I guess the real question becomes should the support in OVS be removed now? It is not broken as you said, just no longer supported in the OVS use case. >> > ah ok, it's not the commit above then, it's this one is the issue > > commit 81e025d7ed6a802845909df6fb90505508dc0fbf > Author: Xuan Ding > Date: Wed Apr 29 02:59:46 2020 +0000 > > vhost: prevent zero-copy with incompatible client mode > > [ upstream commit 715070ea10e6da1169deef2a3ea77ae934b4c333 ] > > In server mode, virtio-user inits under the assumption that vhost-user > supports a list of features. However, this could be problematic when > in_order feature is negotiated but not supported by vhost-user when > enables dequeue_zero_copy later. > > Add handling when vhost-user enables dequeue_zero_copy as client. > -- > > It's unfortunate that it is both fixing a bug and removing functionality > at the same time :/ > Just to wrap up this topic on this thread. We discussed further on ovs-dev https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/372320.html The patches that were removing the functionality have now (effectively) been reverted from 18.11. For 19.11 this will happen too for the next release. Ian replied that OVS testing is now passing with latest 18.11 branch https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/372535.html >> I don’t think it needs to block the release of this, but it's a follow up for the OVS. I believe you'd see the same behavior for OVS master and 2.13. >> > Yes, these patches are already in 19.11.3. > >> BR >> Ian >> >>> thanks, >>> Kevin. >>> >>>> Regards >>>> G Hariprasad