From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D26861B970 for ; Fri, 11 Jan 2019 13:35:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 04:35:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,465,1539673200"; d="scan'208";a="137391802" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.22]) ([10.237.221.22]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2019 04:35:16 -0800 To: Alejandro Lucero Cc: dev References: <20190103085621.23611-1-alejandro.lucero@netronome.com> <09fd5132-905b-bbe0-1178-392595027353@intel.com> <9afed691-6710-7efd-09e7-ae927cc091a8@intel.com> <9ffc5c5b-ce11-331d-b82c-ccbdab4d5350@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <8f2f9e96-cea5-2d1c-d502-8acb3089b778@intel.com> Date: Fri, 11 Jan 2019 12:35:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 12:35:19 -0000 On 1/11/2019 12:15 PM, Alejandro Lucero wrote: > On Fri, Jan 11, 2019 at 11:48 AM Ferruh Yigit > wrote: > >> On 1/10/2019 11:55 AM, Alejandro Lucero wrote: >>> >>> >>> On Wed, Jan 9, 2019 at 4:15 PM Ferruh Yigit >> > wrote: >>> >>> On 1/9/2019 2:20 PM, Alejandro Lucero wrote: >>> > >>> > >>> > On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit < >> ferruh.yigit@intel.com >>> >>> > >> >> wrote: >>> > >>> > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: >>> > > The Netronome's Network Flow Processor chip is highly >> programmable >>> > > with the goal of processing packets at high speed. >> Processing units >>> > > and other chip components are available from the host >> through the >>> > > PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD >> configures >>> > > a CPP handler for setting up and working with vNICs, perform >> actions >>> > > like link up or down, or accessing extended stats from the >> MAC >>> component. >>> > > >>> > > There exist NFP host tools which access the NFP components >> for >>> > > programming and debugging but they require the CPP >> interface. When the >>> > > PMD is bound to the PF, the DPDK app owns the CPP interface, >> so these >>> > > host tools can not access the NFP through other means like >> NFP kernel >>> > > drivers. >>> > > >>> > > This patch adds a CPP bridge using the rte_service API which >> can be >>> > > enabled by a DPDK app. Interestingly, DPDK clients like OVS >> will not >>> > > enable specific service cores, but this can be performed >> with a >>> > > secondary process specifically enabling this CPP bridge >> service and >>> > > therefore giving access to the NFP to those host tools. >>> > >>> > Hi Alejandro, >>> > >>> > >>> > Hi Ferruh, >>> > >>> > >>> > Getting a few build errors, more details below. >>> > >>> > > >>> > > Signed-off-by: Alejandro Lucero < >> alejandro.lucero@netronome.com >>> >>> > >> >> >>> > <...> >>> > >>> > > + /* Obtain target's CPP ID and offset in target */ >>> > > + cpp_id = (offset >> 40) << 8; >>> > >>> > With icc, i686 getting [1], it seems 'off_t' is 32bits long on >> 32bit >>> build. >>> > >>> > [1] >>> > error #63: shift count is too large >>> > >>> > >>> > We do not support 32 bits. I thought our PMD was not built in that >> case. >>> >>> If PMD doesn't support 32 bits, above is OK, I will update my script >>> accordingly. >>> >>> > >>> > >>> > <...> >>> > >>> > > + if (err != (int)len) { >>> > > + printf("%s: error when >> receiving, %d >>> of %lu\n", >>> > > + __func__, err, count); >>> > >>> > Giving build error for 32bits [3], and can you please use >> logging >>> macros instead >>> > of printf? >>> > >>> > >>> > Sure. >>> > >>> > >>> > [3] >>> > error: format ‘%lu’ expects argument of type ‘long unsigned >> int’, but >>> argument 4 >>> > has type ‘size_t’ {aka ‘unsigned int’} [-Werror=format=] >>> > >>> > <...> >>> > >>> > > + /* Obtain target's CPP ID and offset in target */ >>> > > + cpp_id = (offset >> 40) << 8; >>> > >>> > Same as above [1]. >>> > >>> > <...> >>> > >>> > > + if (err != (int)len) { >>> > > + printf("%s: error when >> sending: %d of >>> %lu\n", >>> > > + __func__, err, count); >>> > >>> > Same build error with above [3]. >>> > >>> > <...> >>> > >>> > > +nfp_cpp_bridge_serve_ioctl(int sockfd, struct nfp_cpp *cpp) >>> > > +{ >>> > > + int cmd, err; >>> > > + uint32_t ident_size, tmp; >>> > > + >>> > > + /* Reading now the IOCTL command */ >>> > > + err = recv(sockfd, &cmd, 4, 0); >>> > > + if (err != 4) { >>> > > + printf("%s: read error from socket\n", >> __func__); >>> > > + return -EIO; >>> > > + } >>> > > + >>> > > + /* Only supporting NFP_IOCTL_CPP_IDENTIFICATION */ >>> > > + if (cmd != NFP_IOCTL_CPP_IDENTIFICATION) { >>> > >>> > Giving build error with ppc_64-power8-linuxapp-gcc [2]. >>> > >>> > >>> > We do not support power architecture. >>> >>> Yes but issue seems not exactly ppc issue, more like signed - >> unsigned >>> comparison. Can you please check if is there any valid issue here? >>> >>> >>> This is a funny one. NFP_IOCTL_CPP_IDENTIFICATION is not zero, and cmd >> could be >>> anything. >>> And it does work with other compilers! >>> >>> Talking with a compiler guy in the office, and it is hard to know why the >>> compiler is triggering an error here. I suspect this is some sort of >> endianness >>> mess, and he thinks the compiler could be assuming the cmd variable >> after recv >>> call is always negative or positive, and the macro always being the >> opposite in >>> powerpc, so the comparison is always true, what is what the error >> message says. >>> >>> Anyway, it is not clear how to fix this. Maybe defining cmd as uint32_t >> could >>> help. Any change we can test this before sending another patch version? >> >> I am using a cross compiler for ppc, it is freely available, you should be >> able >> to get and test with it, or I can test for you if you prefer. >> >> > Ok. I got a cross compiler now. Any reference about how to use it with DPDK? just providing CROSS= to makefile should be enough, rest is same. I found following for arm, it applies to ppc too: https://doc.dpdk.org/guides/linux_gsg/cross_build_dpdk_for_arm64.html > > >>> >>> >>> >>> > >>> > >>> > [2] >>> > error: comparison is always true due to limited range of data >> type >>> > [-Werror=type-limits] >>> > >>> >> >>