From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2BBDA054D; Tue, 7 Jun 2022 17:46:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4BB24069C; Tue, 7 Jun 2022 17:46:13 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id B057E40156 for ; Tue, 7 Jun 2022 17:46:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LwtITA+ZVq8ScBtlVuEecjE6Vxd1Y2oWztri9KbXEe7zkxAOD/DgdpjaJGT/eY4C00F4HtjTNnr5ngQIk4njPJ9nTVga73apfx8A0xVuIiWPVg+1lJVbwvmYRteK0mMnEMzJJFWFFQ27hZ910onCCLOoPvfNK6sgwkGeBzdDS+S2mdBpKULnqVXmJ8J7fs0OLtaYkWfvaAMSxMSwp5E1dBjywal7493OG1ljVK/baBLmHD0bKvrfxwjVunqC2UMbw5S+0w0t8HS7tZeESNJQyB75KWh02QApjs3xNo4jSXEtmHqRbFp2xpgLsgYiXjCH4TgVvQHtonJT4aNTOuRRgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JYMww6B//fEi3vg2Uy3O0bjgPZFwrbqYFSUcyN/Vf64=; b=cAoMyDFZb/ES2aNUz3gbX2OQGcUmcgk/g0iU0GDKz7Rf5zCLM1ZH8G11bfmV+jH+Vq8sXDeF0k4WNTEc5gpOXU0J/YYFWNlhECWW7VgKm9AwKbNZCxkJyMxQOyYUYVEImSuHIXasVZRY8hzxJZ1ItBYJXtLEuUu4reZP+vF77quY8Da12Ereja92a7+aGCiowOil8R8o224xvMBfY/pX9EDPhxYjVJLZufzs3rm5vwp49eflN5ZO0bJmbNOmJMCtO1PWDZZ/mbhy3PeI8nsiu6VO7xb4ucQ7aGzUyiM6SF+abtVpBoery4SDDYudnF4xAINlO0+SUB1QFqydI1LY8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JYMww6B//fEi3vg2Uy3O0bjgPZFwrbqYFSUcyN/Vf64=; b=HEcC2C70w7JmZh4fKPxMvs7eqRl+OVd3mYUpPn8+RtUBx8rJW5Tf2ljyTH5xmXBHDVSZVdsuUc8bf88sqkaVjXq738HoRjVnT2uc8Ddp6v1GGCHdnqWKsNNqIUful95B4gKorz1Wf8CWvPF6wwYMfHXzgmSszaFGnoLI4tK31L8= Received: from BN6PR17CA0021.namprd17.prod.outlook.com (2603:10b6:404:65::31) by PH0PR02MB7221.namprd02.prod.outlook.com (2603:10b6:510:b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 15:46:08 +0000 Received: from BN1NAM02FT059.eop-nam02.prod.protection.outlook.com (2603:10b6:404:65:cafe::81) by BN6PR17CA0021.outlook.office365.com (2603:10b6:404:65::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.19 via Frontend Transport; Tue, 7 Jun 2022 15:46:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT059.mail.protection.outlook.com (10.13.2.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Tue, 7 Jun 2022 15:46:07 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 7 Jun 2022 16:46:05 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 7 Jun 2022 16:46:05 +0100 Envelope-to: lihuisong@huawei.com, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com Received: from [10.71.117.191] (port=39774) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nybPB-0004eX-MH; Tue, 07 Jun 2022 16:46:05 +0100 Message-ID: <8f636a38-b96f-1eba-9728-aa52b0942f05@xilinx.com> Date: Tue, 7 Jun 2022 16:46:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V3 app/testpmd 2/4] app/testpmd: unify RSS types display and obtaination Content-Language: en-US To: Huisong Li , , , , CC: , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220607083246.12259-1-lihuisong@huawei.com> <20220607083246.12259-3-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20220607083246.12259-3-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8bbd0f4e-c6ae-48be-ca71-08da489cd67a X-MS-TrafficTypeDiagnostic: PH0PR02MB7221:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RRroEylgXQZyrWazAYuuoFtladEUrUtgf6qJfZ/WfzHzCsx2K8tvnnjpS+Y0heAhhRUW6iiQYpWVAeZYO/La3Bj5uLqdfJv+PdfygWP4m8zZsvRW0upgakZbIC/Ey+UxGSO2OHQ1YbNj1rlJ+dZVPRNx8Iw64tG30/SCyUTan18y9DfgzxIzDq/r870L7zuG9eGmogBFZ7RVS1wkA1Rupy6u157c555zLibF07A1Er3uFymJoiBXwoM6y5K8dCcyR2WCO18YcVhw4oUhULj8JiTGZEaj/4pomb05IxC0WUGyUFobbyPa/nIkoREBoIzrDtj6pdcHhpTpLcO60/VsR4ylgJIfsA3G3NQaNfIe28bbTjkmP44uthUwFCUNn6tRmNbG+GkJJOkIZYKZ8R/Egp2kfISIqez3xyKPo5iearFz2qyPVYozf5ncyNQZdrDkuwty5KqL3ITt3p4Jg+7ZZeyfe1FE/OrolSfvZ/7RIpC1e+d8nHlcscQlJTsvDxcZ0AhbnWr3ygqtzCU8rBYaX9AN88mUGdYhcKi+89nJTBViT0DGV6Kr1AUMfsgnLVUlu61PErtzdBTWw8KWqIT0+MmiLinrvjfPvevMe0oqNQsFbxjalbF9EJO5G3dhU9P1mZyy3hPfMMG2nRhBNSkeQ515+134obh3i9L3uc+IZrFzWbcS24onaTM+4S0u1Fmskl0PtO4X3kR0nWWZx9XD4Q5c/xjZIwuPiYXHKWBDADc= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36756003)(110136005)(44832011)(47076005)(9786002)(8676002)(54906003)(8936002)(31696002)(31686004)(186003)(4326008)(70586007)(70206006)(4744005)(2616005)(356005)(36860700001)(426003)(26005)(2906002)(5660300002)(7636003)(82310400005)(336012)(316002)(40460700003)(53546011)(508600001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 15:46:07.5253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bbd0f4e-c6ae-48be-ca71-08da489cd67a X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7221 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2022 9:32 AM, Huisong Li wrote: > > The 'rss_type_table[]' maintains string name and value of RSS types. This > patch unifies a common interface to display or obtain RSS types. > > Signed-off-by: Huisong Li > Signed-off-by: Ferruh Yigit <...> > @@ -5669,6 +5681,7 @@ set_record_burst_stats(uint8_t on_off) > record_burst_stats = on_off; > } > > +#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) > static char* > flowtype_to_str(uint16_t flow_type) > { > @@ -5712,8 +5725,6 @@ flowtype_to_str(uint16_t flow_type) > return NULL; > } > > -#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) > - I think this change should be in first patch (v1/4) where 'flowtype_to_str' stopped being used.