From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
Cc: stable@dpdk.org, Khoa To <khot@microsoft.com>,
Tal Shnaiderman <talshn@nvidia.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: use bundled getopt with MinGW
Date: Mon, 28 Sep 2020 12:53:51 -0700 [thread overview]
Message-ID: <8f6dffd5-3040-9410-ecf2-3c24d2cf8d0a@intel.com> (raw)
In-Reply-To: <20200924231707.23554-1-dmitry.kozliuk@gmail.com>
On 9/24/2020 4:17 PM, Dmitry Kozlyuk wrote:
> Clang builds use getopt.c in librte_eal while MinGW provides
> implementation as part of the toolchain. Statically linking librte_eal
> to an application that depends on getopt results in undefined reference
> errors with MinGW. There are no such errors with Clang, because with
> Clang librte_eal actually defines getopt functions.
>
> Use getopt.c in EAL with Clang and MinGW to get identical behavior.
> Adjust code for MinGW. Incidentally, this removes a bug when free() is
> called on uninitialized memory.
>
> Fixes: 5e373e456e6 ("eal/windows: add getopt implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Reported-by: Khoa To <khot@microsoft.com>
> Reported-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com
<mailto:pallavi.kadam@intel.com>>
prev parent reply other threads:[~2020-09-28 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 23:17 Dmitry Kozlyuk
2020-09-26 1:23 ` [dpdk-dev] [EXTERNAL] " Khoa To
2020-10-05 7:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-09-28 19:53 ` Kadam, Pallavi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f6dffd5-3040-9410-ecf2-3c24d2cf8d0a@intel.com \
--to=pallavi.kadam@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=khot@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).