From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FBC841B8D; Tue, 31 Jan 2023 11:04:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11A2B40DFB; Tue, 31 Jan 2023 11:04:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 40B644067B for ; Tue, 31 Jan 2023 11:04:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwQn67LtmLT+7/xv8k2oXt2SdWxdgJCaRcKVTzI7IPo=; b=esd+EA9lu4i+CiYrzxCkxxtczOJ+1laAXU9krQjsGvD/Xl8gOr8BQe/OXxtEb3lwtgwnJ+ EK/1OjymMIQChCFaTcfOjsuE5vF6uS9EoBxVoijSC9CzDKjMQX2XGS6EwQ4TELTQfqUlML OuyqXYFQ8zOE0ZV5EZ9Ftl+KIjx1/lY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-nO9D_Wl8NY-wlETx7Zrrzg-1; Tue, 31 Jan 2023 05:04:18 -0500 X-MC-Unique: nO9D_Wl8NY-wlETx7Zrrzg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE52C3848C30; Tue, 31 Jan 2023 10:04:17 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CF2D492C3E; Tue, 31 Jan 2023 10:04:16 +0000 (UTC) Message-ID: <8f83ee36-3aef-ac41-0722-9df33bdf2f0d@redhat.com> Date: Tue, 31 Jan 2023 11:04:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230117165023.20567-1-hernan.vargas@intel.com> <20230117165023.20567-5-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230117165023.20567-5-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/17/23 17:50, Hernan Vargas wrote: > Early termination needs to be explicitly enabled. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 14fe76eb64..12fa988da6 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4463,7 +4463,7 @@ latency_test_dec(struct rte_mempool *mempool, > struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op, > int vector_mask, uint16_t dev_id, uint16_t queue_id, > const uint16_t num_to_process, uint16_t burst_sz, > - uint64_t *total_time, uint64_t *min_time, uint64_t *max_time) > + uint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et) > { > int ret = TEST_SUCCESS; > uint16_t i, j, dequeued; > @@ -4481,6 +4481,13 @@ latency_test_dec(struct rte_mempool *mempool, > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > TEST_ASSERT_SUCCESS(ret, > "rte_bbdev_dec_op_alloc_bulk() failed"); > + ref_op->turbo_dec.iter_max = get_iter_max(); > + /* For validation tests we want to enable early termination */ > + if (!disable_et && !check_bit(ref_op->turbo_dec.op_flags, > + RTE_BBDEV_TURBO_EARLY_TERMINATION)) > + ref_op->turbo_dec.op_flags |= > + RTE_BBDEV_TURBO_EARLY_TERMINATION; > + > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -4873,7 +4880,7 @@ validation_latency_test(struct active_device *ad, > iter = latency_test_dec(op_params->mp, bufs, > op_params->ref_dec_op, op_params->vector_mask, > ad->dev_id, queue_id, num_to_process, > - burst_sz, &total_time, &min_time, &max_time); > + burst_sz, &total_time, &min_time, &max_time, latency_flag); > else if (op_type == RTE_BBDEV_OP_LDPC_ENC) > iter = latency_test_ldpc_enc(op_params->mp, bufs, > op_params->ref_enc_op, ad->dev_id, queue_id, Not clear to me whether it should be a fix. Any thoughts? Thanks, Maxime