From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9375DA04B5; Wed, 9 Sep 2020 19:48:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6316E1BF8E; Wed, 9 Sep 2020 19:48:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A8CAA255 for ; Wed, 9 Sep 2020 19:48:46 +0200 (CEST) IronPort-SDR: PuUkbDtIa/k0SBYVj/OWyXF53voelzr2j3fWdjH1K7n6yrrEDZh6UFqYM3TglvEt+DrpOtVHSw 4fP53fYckjJA== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="176450107" X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="176450107" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 10:48:45 -0700 IronPort-SDR: 8JEP1i2fU/briJ5bS8eZq7NpunbkwQA5eoUvTAyk4gtqgmyErrAXgFjunIxt7C9fPsT+geslNp Ag22yTVkhjTA== X-IronPort-AV: E=Sophos;i="5.76,409,1592895600"; d="scan'208";a="480555039" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.245.241]) ([10.213.245.241]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 10:48:44 -0700 To: Jiawen Wu , dev@dpdk.org References: <20200901115113.1529675-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <8f911ba4-9f45-c349-71dc-852ce225ac43@intel.com> Date: Wed, 9 Sep 2020 18:48:42 +0100 MIME-Version: 1.0 In-Reply-To: <20200901115113.1529675-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 01/42] net/txgbe: add build and doc infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/1/2020 12:50 PM, Jiawen Wu wrote: > Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for txgbe PMD. > > Signed-off-by: Jiawen Wu <...> > > +Wangxun txgbe > +M: Jiawen Wu > +M: Jian Wang > +F: drivers/net/txgbe/ > +F: doc/guides/nics/txgbe.rst > +F: doc/guides/nics/features/txgbe.ini > + You can move the block above vmxnet, since with vmxnet3 paravirtual device block starts (yes the boundries are not very clear) <...> > --- a/config/common_base > +++ b/config/common_base > @@ -389,6 +389,16 @@ CONFIG_RTE_LIBRTE_MLX5_VDPA_PMD=n > CONFIG_RTE_IBVERBS_LINK_DLOPEN=n > CONFIG_RTE_IBVERBS_LINK_STATIC=n > > +# > +# Compile burst-oriented TXGBE PMD driver > +# > +CONFIG_RTE_LIBRTE_TXGBE_PMD=y > +CONFIG_RTE_LIBRTE_TXGBE_DEBUG_RX=n > +CONFIG_RTE_LIBRTE_TXGBE_DEBUG_TX=n > +CONFIG_RTE_LIBRTE_TXGBE_DEBUG_TX_FREE=n > +CONFIG_RTE_LIBRTE_TXGBE_PF_DISABLE_STRIP_CRC=n > +CONFIG_RTE_LIBRTE_TXGBE_BYPASS=n Make support is gone, in next version can you please drop all make build related changes? Also it is harder to add compile time flags with meson, better to eliminate them as much as possible. <...> > +++ b/doc/guides/nics/features/txgbe.ini > @@ -0,0 +1,52 @@ > +; > +; Supported features of the 'txgbe' network poll mode driver. > +; > +; Refer to default.ini for the full list of available PMD features. > +; > +[Features] > +Speed capabilities = Y > +Link status = Y > +Link status event = Y > +Rx interrupt = Y > +Queue start/stop = Y > +MTU update = Y > +Jumbo frame = Y > +Scattered Rx = Y > +LRO = Y > +TSO = Y > +Promiscuous mode = Y > +Allmulticast mode = Y > +Unicast MAC filter = Y > +Multicast MAC filter = Y > +RSS hash = Y > +RSS key update = Y > +RSS reta update = Y > +DCB = Y > +VLAN filter = Y > +Flow control = Y > +Flow API = Y > +Rate limitation = Y > +Traffic mirroring = Y > +Inline crypto = Y > +CRC offload = P > +VLAN offload = P > +QinQ offload = P > +L3 checksum offload = P > +L4 checksum offload = P > +MACsec offload = P > +Inner L3 checksum = P > +Inner L4 checksum = P > +Packet type parsing = Y > +Timesync = Y > +Rx descriptor status = Y > +Tx descriptor status = Y > +Basic stats = Y > +Extended stats = Y > +Stats per queue = Y > +FW version = Y > +EEPROM dump = Y > +Module EEPROM dump = Y > +Multiprocess aware = Y > +BSD nic_uio = Y > +Linux UIO = Y > +Linux VFIO = Y This file should be updated as the claimed featue added into the code, instead of marking all in one go. > diff --git a/doc/guides/nics/txgbe.rst b/doc/guides/nics/txgbe.rst > new file mode 100644 > index 000000000..133e17bc0 > --- /dev/null > +++ b/doc/guides/nics/txgbe.rst > @@ -0,0 +1,67 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2015-2020. > + > +TXGBE Poll Mode Driver > +====================== > + > +The TXGBE PMD (librte_pmd_txgbe) provides poll mode driver support > +for Wangxun 10 Gigabit Ethernet NICs. Can you please add a link to the NIC? I can see a link exists below but it is to the general product web page, but it can be good to have details of this sepecific NIC. > + > +Features > +-------- > + > +- Multiple queues for TX and RX > +- Receiver Side Scaling (RSS) > +- MAC/VLAN filtering > +- Packet type information > +- Checksum offload > +- VLAN/QinQ stripping and inserting > +- TSO offload > +- Promiscuous mode > +- Multicast mode > +- Port hardware statistics > +- Jumbo frames > +- Link state information > +- Link flow control > +- Interrupt mode for RX > +- Scattered and gather for TX and RX > +- DCB > +- IEEE 1588 > +- FW version > +- LRO > +- Generic flow API Similar comment with the .ini file, the feature list should be build up gradually as the code adds the mentioned feature. > + > +Prerequisites > +------------- > + > +- Learning about Wangxun 10 Gigabit Ethernet NICs using > + ``_. Not sure this is a prerequisite :) What do you think moving the link to "TXGBE Poll Mode Driver" section? > + > +- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup the basic DPDK environment. > + > +Pre-Installation Configuration > +------------------------------ > + > +Config File Options > +~~~~~~~~~~~~~~~~~~~ > + > +The following options can be modified in the ``config`` file. > + > +- ``CONFIG_RTE_LIBRTE_TXGBE_PMD`` (default ``y``) > + > + Toggle compilation of the ``librte_pmd_txgbe`` driver. > + > +- ``CONFIG_RTE_LIBRTE_TXGBE_DEBUG_*`` (default ``n``) > + > + Toggle display of generic debugging messages. These also should go away since Makefile is going away. <...> > +++ b/drivers/net/txgbe/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2015-2020 > + > +cflags += ['-DRTE_LIBRTE_TXGBE_BYPASS'] > Why this compile flag is required? At least it is not needed in this patch, can you add it when it is used? And can it be removed completely, or converted to the runtime config like device parameter? <...>