From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: remove useless address check
Date: Wed, 6 Oct 2021 12:33:28 +0100 [thread overview]
Message-ID: <8fbd7d1e-3f4c-1c46-9519-dfdf92a34a7a@intel.com> (raw)
In-Reply-To: <20211004193205.GA17631@chelsio.com>
On 10/4/2021 8:32 PM, Rahul Lakkireddy wrote:
> On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote:
>> reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>>
>> ../drivers/net/cxgbe/cxgbe_ethdev.c:
>> In function ‘cxgbe_dev_rx_queue_setup’:
>> ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
>> error: the comparison will always evaluate as ‘true’ for the
>> address of ‘fl’ will never be NULL [-Werror=address]
>> 682 | if ((&rxq->fl) != NULL)
>> | ^~
>>
>> Fixing it by removing useless check.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Looks good. Thanks for fixing it up.
>
> Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-10-06 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 17:27 Ferruh Yigit
2021-10-04 19:32 ` Rahul Lakkireddy
2021-10-06 11:33 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fbd7d1e-3f4c-1c46-9519-dfdf92a34a7a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).