From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66373A0C41; Wed, 6 Oct 2021 13:33:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52E634113C; Wed, 6 Oct 2021 13:33:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D30AF410F8 for ; Wed, 6 Oct 2021 13:33:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213095404" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213095404" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:33:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="560156247" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2021 04:33:35 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 04:33:35 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 6 Oct 2021 04:33:35 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 6 Oct 2021 04:33:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haqXUHd3558J2ESunP5QppQpPqQ1dniFtlWnBzyXk5i9xL2Vrto5xJIGbSqGHpD1b3tbxHP3kGCZ8xXsm5M1u3kSfrC6s98/hpc+HweqaaM7SXJ+mbs6qC6GWIUWL8FJHPH2tN3OwPMeJGKzG7CnLf8N/XBO2wvJHV5KgE+1wPweOUqNNR9wCgebDJAWMdmmVarPqEaBNhzI9geg+KaK1+J7pa0i9JkxKxGJdM1sXI83nIirPPS+q0Z3WBIromOiy1AcmZCQjN3gQ/f+9LC7wMg76f/IaahFJz0QhR9LAnKT+ehgquBXtjRzfF2kr/mANutjJrg4oeFnsnvSAorF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHwZ/Y8+pu7Ufe5gV0KsiSA+tP7DnCsGfmZMoPotzzM=; b=jpHda3IJ9LYbgbU67QP4irGorLs1w0q5Y2uelS0yI/h7+zeaMbaK5DxS9+I5xtYtdxDdWLJ0akd6Ks9glCXQ2Qe2sdZ812SMg6cgoDETRJxvkmC7NusuMVewF4NzXByOdhUnQdmBGBC81YWOAUPy/Hv9bS7wDQOypegxRJncrHh6cjROMlns/M4JDAw9xwxreqhk+MjvGGdCLqMTroSDGNlwqfdmIx6E5POj3+3j1sslybFX/n13VSWj18AK7xiQoRzKG7jQfwXrMNIwoYIln7n9dZI0ZSVUAXSANW2Kdq0ce7FiCKwA/L5DnmdubNg2ebVdzwGqTWv+Iiua82gAIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yHwZ/Y8+pu7Ufe5gV0KsiSA+tP7DnCsGfmZMoPotzzM=; b=bYj6cZKHn6RHCo0WnCZps/vCSovWkoCJf2LCZvuY/gZGobK/nEEd6wshfmO0Lu4sqCkAXz1Yr4JT+O7D1wFoO1+j6mip2tCPdf7oyO+tOLztzPQOKqgJhx20wivRITPLZ30CIVu0bMO43vl06P9RuwwhgRSo5ysUC0eWrmhMsFc= Authentication-Results: chelsio.com; dkim=none (message not signed) header.d=none;chelsio.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4870.namprd11.prod.outlook.com (2603:10b6:510:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct 2021 11:33:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021 11:33:34 +0000 Message-ID: <8fbd7d1e-3f4c-1c46-9519-dfdf92a34a7a@intel.com> Date: Wed, 6 Oct 2021 12:33:28 +0100 Content-Language: en-US To: Rahul Lakkireddy CC: References: <20211004172754.3461732-1-ferruh.yigit@intel.com> <20211004193205.GA17631@chelsio.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211004193205.GA17631@chelsio.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8PR06CA0035.eurprd06.prod.outlook.com (2603:10a6:10:100::48) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0035.eurprd06.prod.outlook.com (2603:10a6:10:100::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 11:33:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6cef472-0df8-416c-8b92-08d988bd2120 X-MS-TrafficTypeDiagnostic: PH0PR11MB4870: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QiJPjmCFvgNxBJCLKi7XTiBlKofvi+8b4uTe5jhWFirpHjR127sr7kbWfsKY7Z5mGBdUYYT3TRCZ9EeITOoJH2Xwp7DocZZn/VtH/SzdAxJH19zSPWgM+ePxNRS2rGGImB/bXikBcmQwPxhh6/aYrRoY8vcWT9RwBfBu2PS49A93RxngYB7mMLi8TNIw1Pv6+tEvxj0oD7QbzArYT9K9mNXu9aIRxeQnwm57mp9MyJACuXmtKwlE7zOAyQx51C+9JAkbz1vMZNYKLro0T+bYYk99g6tCXJBqauebnkG7tx2xhflFuZBxSvllPHNuxdc2HGcn9UrAx6bwR8LJiJpEr8GKLAJjmPjmFUsDQ5veBAoU/rj1VnRrmOo0TVD7Ayy7/el5CHCXBF1yW9nSOD+/BPftBE7jCm9pixC9x0Ig1IBdlMR1RasdBxM5g+Csc2xvaAcqgyo8zGxca/Zl1oSBTJvPYdOWMpfVEZuQCbrFMDbNno36Tmq3LLA+ievkcF0kuYcGb7//HPtn1qgyarS8KJ6UvKEN7AfMbNMDXK+HGXnEbUhHxXS1qgQQS2gkGXRjleP5b/gigEt0TpapaK6aM9FQ9W5oqDlqzTprNQi6TSFhfB/tVbZSAqAE6pNCtVdos5S2FE7f6xEWHM86k3wBaD9Sy8ED3PkasJF7Ki7OTIfcyWMWZbAyCr2zDIjQKN2WXmu1+xY17KDUxPKJZkUFpg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66556008)(53546011)(66946007)(66476007)(36756003)(26005)(5660300002)(31696002)(186003)(16576012)(316002)(6916009)(956004)(2616005)(4744005)(86362001)(6486002)(6666004)(31686004)(508600001)(38100700002)(4326008)(44832011)(8676002)(2906002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vjk0dzRCTFNNSGtTcDZkcWhyNkp2TEFBS09lMEkvTUlvQW91MDI5MlZieTY4?= =?utf-8?B?cHR4VnJ4M3pLOTZJbjVqVDhvZTNEcU5lSTB2Z3FWdGRvV3V1VElSWGZCMnQz?= =?utf-8?B?MTFUdEZQdHdHeTlZVG5kUFBpR2FPckZtTmd6REVCUUtWUmlEc3JDc1ZScmdv?= =?utf-8?B?OGoxNVJGYzdRM3ExaFRybmllY1p1NGo5SjhqQ09wcDlpdXBjSEFmRVhuVDZ5?= =?utf-8?B?T2gyeVkwRGhqWGZHR2txbCt2TmNoVXJUb0g5RG5JQlZ1dXd4MHY0SU1tQUkv?= =?utf-8?B?SFlLZ0Y1QUJQYWxrN0F4MnY4RkpGNWlhc2s0eTNmc3lEYnNGTTRxbDcrSlhD?= =?utf-8?B?aFROak01VVZZVWhWYkJkMzFXL2xsM0NGOUhmR1lKZXY5OVFjZ0cvaEVueTVR?= =?utf-8?B?MDRyb1gzUDBHSHE1dHFFc2hmNmZNcUFTWlRBYmZtcE5oamUyd2YrT0FYNE9R?= =?utf-8?B?ZzlPT2ZuTlFqLzdEdVBFSk1Sang5aUJUVytwa3BIWjJQdmVBY1o4UW05RkJ5?= =?utf-8?B?Tm5ycjhJM0VmMXhRYzlQSVEyaHFKVEZPRnJmdldDMWFGSkFsbzdJYUphUmc3?= =?utf-8?B?ZGxKc2RqU3Q1a1RRUS9qYktIZUFaOSs2bTl3aDJ4Zkl0U0FrN0QwVWlidmFi?= =?utf-8?B?cFYycXJ5WG81NkEzbmJVck9oUVQxTjhXS3RKaDNhVHZIZHdKT1JjVldpbVpI?= =?utf-8?B?SkUrMks4MUJMaGJxMEs1dExFSEJWNWhMTm55dWdlV1IxZC83Wm5zYkFpQmJD?= =?utf-8?B?RmNHQUlsUEtmMlptS3JkTUlrVm9ESi85ZWVFc0FRZmtyWkhnV0RtWTNyYlhq?= =?utf-8?B?dzhicVg3bEFUcEF3bHplclRvY09QQUNXaEZtSERNZkZRdWpGUGNZUnAwZE5i?= =?utf-8?B?VnIxUi8zOElOclN1ekxXdEVmODBJa0IrSS9teVBMaVhyWGtYbG1LdEtHeXdr?= =?utf-8?B?N1pqRW5kRU5tUGozLzhQZmlQZ1YwMEVBZFNaak9ITzVhSy9VZ1FFRTRlZGpO?= =?utf-8?B?RUloQkNLNkpMZFUwekVCQ2g3ZTcremh3dVRWZjFXN1ZhaG9Fd0krQnYrN1B2?= =?utf-8?B?ZTZEMEd4TnI2MEQ5NlUvcVJ3UXhJUkVHclRrVzJNYWVEQ3dWT2o2UzZHSk9M?= =?utf-8?B?Q0hlZzhFSkVtd2hUQkN1cDFXd2ZRV0UwbUZEQmJKWWc0OUd5em1EVndlclVi?= =?utf-8?B?OVpLdFEvengzaWdHSEMzMlZaRkptalpWY2R6aTJ2b0JNVWJOQUxDM0Y4RkpT?= =?utf-8?B?djVqN1k3TmVSYzFlcDlzaGlVb0N2N0p4U2Z0THdLdHh3blFKSE14THUycmtX?= =?utf-8?B?TUhOV1ZZc25qeVIrU3o3MTdoMjgwQTVTaGgwTzdKM2FHZjhmNjJEZjQyWjI0?= =?utf-8?B?bmtZMHJ5N3dzUDNIZTl1dnRQb0I0ZWJobHlKbE9FTFVwaTdwbzlRKzBrR0hI?= =?utf-8?B?dEliNkZia1oyNThoN1FqRHVhWkFFUDdXZ3kyY21HUTk0TmxyMmJzUTA2d0JK?= =?utf-8?B?MEM3cWVzNlpRbUN6eWNkckkvOGNEdnh0Qk9nMm5KdWlFYmRlUXRzdEpKOGpC?= =?utf-8?B?S3FxM05NOUN0eVA1OEVRZlI3T00xVFh0Vm9wanlaZVRCMkprUVZGYUt6a3hr?= =?utf-8?B?dWdrdzljbmVMSWNFclFCU0JzVStjK2pUZnkrRlBxWWJLOXl3N205b2ZjeTJp?= =?utf-8?B?Sk14Mm1WSksrWThvcGYrdjlzWUduRGNKK1RsQWs2ZmczQ2t0THhaSW14WDVN?= =?utf-8?Q?N77NJvavmpIVCVupajvYzLFOEGYuNGLxBBSH8bn?= X-MS-Exchange-CrossTenant-Network-Message-Id: d6cef472-0df8-416c-8b92-08d988bd2120 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 11:33:33.8689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8/hUyh1rOf6AMSrkX0jsxy4SHo0N0Lj1tJdGA760CDkghe7r8G0HY+TjtnbuPCN0aYWR9Rw3sf2BBNBJYnDDMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4870 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2021 8:32 PM, Rahul Lakkireddy wrote: > On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote: >> reported by "gcc (GCC) 12.0.0 20211003 (experimental)": >> >> ../drivers/net/cxgbe/cxgbe_ethdev.c: >> In function ‘cxgbe_dev_rx_queue_setup’: >> ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24: >> error: the comparison will always evaluate as ‘true’ for the >> address of ‘fl’ will never be NULL [-Werror=address] >> 682 | if ((&rxq->fl) != NULL) >> | ^~ >> >> Fixing it by removing useless check. >> >> Signed-off-by: Ferruh Yigit > > Looks good. Thanks for fixing it up. > > Reviewed-by: Rahul Lakkireddy > Applied to dpdk-next-net/main, thanks.