* [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled
@ 2017-10-09 14:38 Kirill Rybalchenko
2017-10-09 17:45 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Kirill Rybalchenko @ 2017-10-09 14:38 UTC (permalink / raw)
To: dev; +Cc: kirill.rybalchenko, andrey.chilikin, beilei.xing, jingjing.wu
Precompiler instructions #ifdef RTE_LIBRTE_I40E_PMD ... #endif
were not placed correctly, which caused number of
compilation errors if I40E PMD is disabled.
Fixes: 5a4806d304e0 ("app/testpmd: support updating pctype mapping")
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
app/test-pmd/cmdline.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 20e04f7..8dc5c85 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -13843,8 +13843,8 @@ cmd_ddp_info_parsed(
free(proto);
ret = 0;
-#endif
no_print_return:
+#endif
if (ret == -ENOTSUP)
printf("Function not supported in PMD driver\n");
close_ddp_package_file(pkg);
@@ -14390,17 +14390,16 @@ cmd_pctype_mapping_update_parsed(
#ifdef RTE_LIBRTE_I40E_PMD
struct rte_pmd_i40e_flow_type_mapping mapping;
unsigned int i;
-#endif
unsigned int nb_item;
unsigned int pctype_list[RTE_PMD_I40E_PCTYPE_MAX];
+#endif
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
return;
+#ifdef RTE_LIBRTE_I40E_PMD
nb_item = parse_item_list(res->pctype_list, "pctypes",
RTE_PMD_I40E_PCTYPE_MAX, pctype_list, 1);
-
-#ifdef RTE_LIBRTE_I40E_PMD
mapping.flow_type = res->flow_type;
for (i = 0, mapping.pctype = 0ULL; i < nb_item; i++)
mapping.pctype |= (1ULL << pctype_list[i]);
--
2.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled
2017-10-09 14:38 [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled Kirill Rybalchenko
@ 2017-10-09 17:45 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-09 17:45 UTC (permalink / raw)
To: Kirill Rybalchenko, dev; +Cc: andrey.chilikin, beilei.xing, jingjing.wu
On 10/9/2017 3:38 PM, Kirill Rybalchenko wrote:
> Precompiler instructions #ifdef RTE_LIBRTE_I40E_PMD ... #endif
> were not placed correctly, which caused number of
> compilation errors if I40E PMD is disabled.
>
> Fixes: 5a4806d304e0 ("app/testpmd: support updating pctype mapping")
>
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-09 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-09 14:38 [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled Kirill Rybalchenko
2017-10-09 17:45 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).