From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D712A0548; Tue, 20 Apr 2021 18:49:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A87F41735; Tue, 20 Apr 2021 18:49:33 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1F5E441439 for ; Tue, 20 Apr 2021 18:49:30 +0200 (CEST) IronPort-SDR: 6tnc+3mF3j3sKib74ZBPRifYLcAlTYjdh+TBsbSj3zHiH6MT7AS6VoJq9PW7vEovNRjSueE2/Q tB9CWWujM/kw== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="182675032" X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="182675032" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 09:49:29 -0700 IronPort-SDR: pUSihuv5dceJreUhcv4x/gLOUqiIIIGlf+mCk1+rbikAWOgQYYypUaTsFSDjOzBlcF/9zq4Zzd E1862lshgQAQ== X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="463200069" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.220.64]) ([10.213.220.64]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 09:49:28 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: David Marchand References: <20210409171631.18219-1-dmitry.kozliuk@gmail.com> From: "Burakov, Anatoly" Message-ID: <8fd733b5-fb6c-19ed-81ee-e755514f257f@intel.com> Date: Tue, 20 Apr 2021 17:49:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210409171631.18219-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mem: fix cleanup after incomplete initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Apr-21 6:16 PM, Dmitry Kozlyuk wrote: > In case of EAL initialization failure rte_eal_memory_detach() may be > called before mapping memory configuration, which in this case points > to the static structure. Attempt to unmap it yields error: > > EAL: Could not unmap shared memory config: Invalid argument > > Skip unmapping memory configuration if it's not yet shared. > > Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") > Cc: Anatoly Burakov > > Reported-by: David Marchand > Signed-off-by: Dmitry Kozlyuk > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly