DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
Cc: yuanhan.liu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
Date: Wed, 18 Jan 2017 11:52:41 +0000	[thread overview]
Message-ID: <8fea300e-350e-6b83-a706-acadec98afc8@intel.com> (raw)
In-Reply-To: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com>

On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> API rte_eth_dev_info_get() fills driver name according to drv_name
> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> 
> We do not use the same one with virtio device as some applications
> might depend on driver name to differetiate kinds of devices, such
> as VPP.
> 
> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> CC: stable@dpdk.org
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  drivers/net/virtio/virtio_user_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index c877968..110f6a9 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
>  	hw->use_simple_rxtx = 0;
>  	hw->virtio_user_dev = dev;
>  	data->dev_private = hw;
> +	data->drv_name = "virtio_user PMD";

How driver naming done changed in next-net.
Please check any other virtual driver in next-net for sample.

>  	data->numa_node = SOCKET_ID_ANY;
>  	data->kdrv = RTE_KDRV_NONE;
>  	data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> 

  reply	other threads:[~2017-01-18 11:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 11:44 [dpdk-dev] " Jianfeng Tan
2017-01-18 11:52 ` Ferruh Yigit [this message]
2017-01-18 13:49   ` [dpdk-dev] [dpdk-stable] " Tan, Jianfeng
2017-01-18 15:54     ` Ferruh Yigit
2017-01-19  1:16       ` Tan, Jianfeng
2017-01-19  8:16         ` Yuanhan Liu
2017-01-19  8:23           ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fea300e-350e-6b83-a706-acadec98afc8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=stable@dpdk.org \
    --cc=yuanhan.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).