From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CC692FA44; Wed, 18 Jan 2017 12:52:44 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 18 Jan 2017 03:52:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="50026991" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga004.jf.intel.com with ESMTP; 18 Jan 2017 03:52:42 -0800 To: Jianfeng Tan , dev@dpdk.org References: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com> Cc: yuanhan.liu@intel.com, stable@dpdk.org From: Ferruh Yigit Message-ID: <8fea300e-350e-6b83-a706-acadec98afc8@intel.com> Date: Wed, 18 Jan 2017 11:52:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 11:52:45 -0000 On 1/18/2017 11:44 AM, Jianfeng Tan wrote: > API rte_eth_dev_info_get() fills driver name according to drv_name > of rte_eth_dev_data. But we have not fill such info in virtio_user. > > We do not use the same one with virtio device as some applications > might depend on driver name to differetiate kinds of devices, such > as VPP. > > Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver") > CC: stable@dpdk.org > > Signed-off-by: Jianfeng Tan > --- > drivers/net/virtio/virtio_user_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c > index c877968..110f6a9 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name) > hw->use_simple_rxtx = 0; > hw->virtio_user_dev = dev; > data->dev_private = hw; > + data->drv_name = "virtio_user PMD"; How driver naming done changed in next-net. Please check any other virtual driver in next-net for sample. > data->numa_node = SOCKET_ID_ANY; > data->kdrv = RTE_KDRV_NONE; > data->dev_flags = RTE_ETH_DEV_DETACHABLE; >