From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85C0AA00C2; Fri, 14 Oct 2022 11:57:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77D0442D3E; Fri, 14 Oct 2022 11:57:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B4FEB42CF8 for ; Fri, 14 Oct 2022 11:57:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665741432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9fwq7TxmzCMhkaVtcAL+eS0yjPGt1ySp/r1gYS9yiF8=; b=SJ/G+SV7RyWoBZYamB708W7q623SzlFjhOO/A+h9t/qlBC5dKcH3iVj2mysooYszPd3jaT uYHb8PqECYRINjLPwF6MmroSfQ973uUhN/8pY7u0JJE9dhNJpuppo9Gmh3FK7C9jpCoPji rgTAW67nTkcmx3hZBXP/PmZjluFF3aw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-rWOd8mvhNwOCj6nbDoSFiw-1; Fri, 14 Oct 2022 05:57:09 -0400 X-MC-Unique: rWOd8mvhNwOCj6nbDoSFiw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61B6C29324AB; Fri, 14 Oct 2022 09:56:48 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73532112D18E; Fri, 14 Oct 2022 09:56:31 +0000 (UTC) Message-ID: <8fed7c19-184c-d3a0-7746-b15f9ebce44a@redhat.com> Date: Fri, 14 Oct 2022 11:56:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 09/30] baseband/acc100: reduce input length for CRC24B To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20221012025346.204394-1-hernan.vargas@intel.com> <20221012025346.204394-10-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20221012025346.204394-10-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/12/22 04:53, Hernan Vargas wrote: > Input length should be reduced only for CRC24B. > > Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index c0184b8174..c0e6d0ef23 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -1427,8 +1427,7 @@ acc100_dma_desc_le_fill(struct rte_bbdev_enc_op *op, > > K = (enc->basegraph == 1 ? 22 : 10) * enc->z_c; > in_length_in_bits = K - enc->n_filler; > - if ((enc->op_flags & RTE_BBDEV_LDPC_CRC_24A_ATTACH) || > - (enc->op_flags & RTE_BBDEV_LDPC_CRC_24B_ATTACH)) > + if (enc->op_flags & RTE_BBDEV_LDPC_CRC_24B_ATTACH) > in_length_in_bits -= 24; > in_length_in_bytes = in_length_in_bits >> 3; > Reviewed-by: Maxime Coquelin Thanks, Maxime