From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5FE4A0032; Fri, 16 Sep 2022 14:35:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 464104021D; Fri, 16 Sep 2022 14:35:22 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 23D7440156 for ; Fri, 16 Sep 2022 14:35:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663331721; x=1694867721; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=dTG6mBzg3EbDKm995SIWLVZXPApzYPe9sezxLezLG+o=; b=DCIbjr+CTvRv23mBwfCLGP9n7BF5/O1IEAcZx+NYa8vz9F6ZP6DTWd9T Lkqc/Z4O6HKGOWNIajs/ggAGBMll1QcvbBHEHSx4RdCbcIZeL8rIzuZn1 skEqtTMXtS4PvPNki1hwlzDKLxkzc3ec/C+FwU41/Ck8vLDqyoBtPRxwR r6Ddgh0cdYEWvZjYUA+njO3ejMHrzRKR0zy71TiMweYXOdROgW+pNRcG2 sS/lUZMXVU1f/WCl3TPcm8OXQgzPYjQU0TCT+3qy9H7oXvNl4vIkulxtU kR7RSO1Be6YbalC/s9HLBmvvqJSau50dh4/p2dal2D+1+u1JIBwuOgwFB w==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="278710275" X-IronPort-AV: E=Sophos;i="5.93,320,1654585200"; d="scan'208";a="278710275" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 05:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,320,1654585200"; d="scan'208";a="595238401" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 16 Sep 2022 05:35:19 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 16 Sep 2022 05:35:18 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 16 Sep 2022 05:35:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 16 Sep 2022 05:35:18 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 16 Sep 2022 05:35:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBkFSgndAZ9KZVA2vgLXfh8absqJXuaVqmWUq450MA1irWuLhy07OMfOjjSNacyzSJsuLYe1grwKXOeWWHNKU+B3fctG5tIRGYrYB11L4ejgYGIP3xXSEHXbcdrbUJh1DIGdK7FYxBcDr2vBl+1BC9laygfktTndw1icUco4AO2FTKIzbk4yjZROdloJB/DRKKyXYPE+VlrExP+L/+Yfz0WD3nRDrS6wr/K75Mz7ImKR77p57Iv1qOVNp4665n5pXrfJ53vlmnBIabDKxi5xavnSl6Zvo3oHMcAOhwc/cCWRx0rsKrWFngbAURrZQ3WzFVgpmZqOigneY839BhEesA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j7WG0YZgfinNn5QgeK9XolPEVLX41C0XXZZzHuG3sVc=; b=NErNqEgrq8sjSVDjy6AeEoszK4bpAFJSLxuqiAyhkWVsX+69Xi3xwIzNOy9u1OhJCDtUmCPoqtASmO9OMhGOZPRpQbbqvXbe45DJIIh4c32dWOY1lOdLq7MOTR4MpZq25EI5gbKW8lRTWhLXWO00N/ZZYkf+MivMJVettyeUQAVlmvQOcV8vqup0PRZB2yoU4k64HlksBCZ/T2Z72uCgnpx6bIc0mL5HafxqEtqbCFN7PaTjGuE2YPd9CxWfbVmdNV2XeEC3FiD9BMSlvDJ4hJJFutd4squ2hqClqk0mInelpreI0c37dKRFGpjubJV05BbNzqxfUQDlzik5n8/NfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA0PR11MB7355.namprd11.prod.outlook.com (2603:10b6:208:433::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Fri, 16 Sep 2022 12:35:15 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 12:35:15 +0000 Message-ID: <8fee26ed-5640-8bba-0bfa-9969694410c5@intel.com> Date: Fri, 16 Sep 2022 13:35:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry To: Stephen Hemminger CC: , , Conor Walsh , David Hunt , Bruce Richardson , Nicolas Chautru , Fan Zhang , Ashish Gupta , Akhil Goyal , Chengwen Feng , Ray Kinsella , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko , Jerin Jacob , "Sachin Saxena" , Hemant Agrawal , Ori Kam , Honnappa Nagarahalli , Konstantin Ananyev References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <20220914092929.1159773-1-kevin.laatz@intel.com> <20220914092929.1159773-2-kevin.laatz@intel.com> <20220914073043.3d9e9df7@hermes.local> Content-Language: en-US From: Kevin Laatz In-Reply-To: <20220914073043.3d9e9df7@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0255.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::20) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|IA0PR11MB7355:EE_ X-MS-Office365-Filtering-Correlation-Id: a892d674-4957-4c78-0bd2-08da97dfe7e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aGNJlZM+OaBbZy7alRiIDOsNauWKnpLKjrGVsmW7mgUzHkC30Fu69JThUphyz8G+kD3bBGbS/CCDX0dM/VgkPzZUuGAXHv8sIgGkR772wwX/d5IhkMdrP/idPj+3GIwf3QBOWcZe9uZSFfF+sdRXDWmseXALyUzSJzNsZuvyVAMWmPAdHHBNStyq/fVGFIN84f4eiBlDzJweN5jxAQ1Cyl2re6Qsr2HWUY6c4CqoYasJoyI7cr7jin2H8Dg/Av6UIjj/A2E2CHkJZs3M2SeouFpU0V9BUbCxaK2K66uLXGggKl7pL/qZuvIFTSyWpB3XY7VQlE14vCRHktdAhr4J2pdrGvp5cipYSws79whyi0DdEXlDFQEZuch8wfNRZMczDrQdbNRkPdTdA/1RGkxQO6aR7rQVcys1LMbe0qV+Cy4dDreu+bURHIQyBCb9d7lV0RpDLU9TZeDXaSFYVY8seJtK93RAgVzO3CFIxzAkJAcDYc5A5rOxe8JD9tZtdLcrkgLi51Kx0tlJVgq7oNo4RhKGsI12nos05Np627Vj6mv0+Mzmon0mIajZkV3QCCvBeCLrZKaesaUhcRchoXLJQiZ8Rsos7yAeOUT87+I37NypL2GowLobNEO5O7ts0tgiB06K2d6GpfEIdLJa1t1Qk5CtulB0vN/KOSsc03Z9H1In6MaYLWMVpRprnssGMsrSG0fkxWtcMAZSIc4TsXYimz/s7bEr9MGCZV6o9hKCdHQdQtK7F8jdZXOaPgRcXoc0We9eb/ICP23NqplTUn/Zl3L91dpxL5abNz2tCP2r8o4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(136003)(396003)(39860400002)(346002)(451199015)(6916009)(54906003)(7416002)(316002)(8936002)(5660300002)(31696002)(66946007)(4326008)(66556008)(66476007)(8676002)(86362001)(82960400001)(38100700002)(6506007)(41300700001)(6666004)(53546011)(6486002)(478600001)(26005)(2616005)(186003)(6512007)(31686004)(36756003)(44832011)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3dRQXJQRCtOaXowdCtDZnlpK0s4cTBSY2JnTndhNWhUcDBIWWlkRERkTVpx?= =?utf-8?B?d2p1OGRrS3lpRmR0TEwrSVg3cWE4TjYrUm5zRm8rRXVOVFdkLzU0V0tRalZG?= =?utf-8?B?NUNya0NFOEFrZUhGdFlnM0xoaGFpYW1sY3V3VXNnOC9nNlBwTlFUaVBtR3lC?= =?utf-8?B?TDEyMTNnaDQwWnZHUWpPMjBhc2d1bXZGVHhWTHFhVGZqZGtqMkVMaVNRbU1j?= =?utf-8?B?WGdCcDZMSm5xTUcwZjRLVSt3c1F4UDhhUm5Wd21oTTk5QXp3bVNjTWhuSVhy?= =?utf-8?B?Tk9jWHlFdjRocGdtRkkzZzBHVDFWaEV1aWVKdCtENEYvcXdXZzNvMFRXdVF6?= =?utf-8?B?UERDdDBGbWJJMzZXWGVBMk9xR2dqSTg2ZU9Vck9lWTNiZXJ1M2NMR05nYkpi?= =?utf-8?B?OWdET2VFQVhQMmdvSWovMktsRUN5UFpRNXZZbDAvR2t6WENMWHgwSVc5ZjRj?= =?utf-8?B?OVRVT2l6bUhPQ3ZUTkZFMTRWbmFlcHhRNXltT0I1RFNGQ3k3NDQxckRINGRZ?= =?utf-8?B?b1ByckJLZzhoaHl3R1BTTk9oK2tiZW9KYTFYQVlORXVhTGpBRmpackZra0lo?= =?utf-8?B?dDQ4Z1Z1eVhONTA0QWtKczd3QnNDMlZmeVlsL0FIM1pwZkZiZkhuYkxOeGQ4?= =?utf-8?B?YmtoOXRhNmVpb1dhZ0FWcEE3cXdUVnJDL1diTDdBNUNVYXR0RUQyQU9ISU5y?= =?utf-8?B?VFA0NmVWZWErbkh6bU5tUXllRi9UKzczM2tYVjQzbXJuemFrNEptUWIvR3oy?= =?utf-8?B?QzlxeE05MGxXcGNKYTF0SmFWMEc3QVJDZGt5Nnp4WHZ1cllVaENrNUxjN3FL?= =?utf-8?B?eCtPeXcydXJzMjQ3NmE3cjlrdkFGTXpSb0dJN3Y2cS9QZmVSZEQ0T1FxSSsy?= =?utf-8?B?WmxiczV2QmxLS291aXFUYWFLbGZKTmFQT1dWcHp1clF3emtNWExiUHVZYkww?= =?utf-8?B?NGgxalZ5UXlhcU83enBkKytxdHdVZU1WMk5rMkFYSkFhNkRLZzlKZG1NYnBx?= =?utf-8?B?UTNjLzRVN3g2T3VEMVhWb1o3SEhuRENHNHVTUmF5NE5Td3FqMWxva0YvNUFw?= =?utf-8?B?U1pLMmJGSklSeGE2U3FrYTZ5Y0p2cmZUUnY1cUVrZy9HNDNmck1KVkt5TjVE?= =?utf-8?B?QlpMZzFTL09NRS9NTnBydEN3cFYzbWN1RUJoelUzUXkyWE5XZmx5TmZ3RWVy?= =?utf-8?B?SHhyKzQ3OU5lRmtwME5GN1V0MlozY0taS25RTjVsMzBuQ0Y5VlpPeE82enpY?= =?utf-8?B?dHlFTW84Tk1NTjltNThUalc1T1c1bm1FS0IrckJ6ZldmSURlOVpiNlZoZENa?= =?utf-8?B?cm9EVU9USnEydmo3TTJpSlpEb2lCYzlOcGlkWXZRQXMwVXVVS3ZBdUVWNmw1?= =?utf-8?B?Y2pmK0w5RVZUSW85STVnL3VjYkN2NzJDOEk5WW90NW1CM1V6eW9mbVFmTEtG?= =?utf-8?B?SnNyaTZQVngzTnRxRituRWFjS3krbXBnKzJMVmp1dVFJZ05PRUZoYThKZ0lB?= =?utf-8?B?Mm9NRzJEaFBublBoNkhoMXhzN3lJVklEVUphbStkcHNxQ1J3cmd5blZYYnp1?= =?utf-8?B?YW5ZM3BlUHM1THdRRThpV0xqNGFWc3lWMGVYWTlLL2NWUndrN0lGNE8wUU1j?= =?utf-8?B?bUlqZGNlNDBiNWhuckRFZCs1L0xsTm15S2JaeXltSDhMQ1YyRjJEZnhYSmtJ?= =?utf-8?B?ZmZIRU1TcTEySUJSa1NqbHNmOFRWMS91VEY1UkZNYytOdmd4VUFiV1V0eXAr?= =?utf-8?B?bXlBOC9lZS91Snh2WjRSc3dxVnhxalFITkVZU1B0UU1UWGVmNzRPQWhNa1Qv?= =?utf-8?B?QmpwUkp4enl3UzhZL1NFNUovOWVhU2dLNWtxMTRBYXRmd2ZFVWZ2Y3pWMGo3?= =?utf-8?B?ZDdwd1p1SXJtVUtldjdGcHFZK3NxVFR4TEFZZW9pQ3o2YXpFWnV4cXkzakZr?= =?utf-8?B?bmUvOWU1d3FyMWZxN3hwVkRFaExPSW9nWjhOKzdFRmNaOFJXQmlpL3FMdnNR?= =?utf-8?B?dDVnc0ZtYmRSbUhvRHlKSW4zVEN2TTRHeVptMDVseG1lalVzMHJhcU5nTzAv?= =?utf-8?B?R0R2NWhQelZzNG9UOTc1R0gvOWNUVHRJMEVjcmlDcHFNSUZEQ1JJVzEwdWhB?= =?utf-8?Q?iSUl4zyLr932WHMGPAJ8+6RBn?= X-MS-Exchange-CrossTenant-Network-Message-Id: a892d674-4957-4c78-0bd2-08da97dfe7e7 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 12:35:15.6069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p4LbZoIDd7SQsjBI/G99lg5ZWOJQjp3y0ygrM9FUDgUO5OuoeJhm8lw/rWMmAQEb2RJ8DnAAcMoQh93j84M8TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7355 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 14/09/2022 15:30, Stephen Hemminger wrote: > On Wed, 14 Sep 2022 10:29:26 +0100 > Kevin Laatz wrote: > >> +struct lcore_poll_telemetry { >> + int poll_busyness; >> + /**< Calculated poll busyness (gets set/returned by the API) */ >> + int raw_poll_busyness; >> + /**< Calculated poll busyness times 100. */ >> + uint64_t interval_ts; >> + /**< when previous telemetry interval started */ >> + uint64_t empty_cycles; >> + /**< empty cycle count since last interval */ >> + uint64_t last_poll_ts; >> + /**< last poll timestamp */ >> + bool last_empty; >> + /**< if last poll was empty */ >> + unsigned int contig_poll_cnt; >> + /**< contiguous (always empty/non empty) poll counter */ >> +} __rte_cache_aligned; >> + > For api's always prefer to use fix size types. > Is there any reason the poll_busyness values could be negative. > If not please use unsigned types. We use -1 to indicate the core is "inactive" or a "non-polling" core. These are cores that have either a) never called the timestamp macro, or b) haven't called the timestamp macro for some time and have therefore been marked as "inactive" until they next call the timestamp macro.