From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Wenjun1" <wenjun1.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "Wu, Wenjun1" <wenjun1.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for IPv4 fragment packets
Date: Sun, 29 Aug 2021 11:18:37 +0000 [thread overview]
Message-ID: <8ff1fc48ee804acc9350cad327db1dfc@intel.com> (raw)
In-Reply-To: <20210817064955.160102-1-wenjun1.wu@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wenjun Wu
> Sent: Tuesday, August 17, 2021 2:50 PM
> To: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for IPv4
> fragment packets
>
> Originally, the value of field_selector for IPV4_FRAG header hdr1 is the same as
> the previous header hdr2. For IPv4 packets, field_selector for hdr2 can be any
> value between 0 and 4, depending on the selected field. Actually, this value for
> IPV4_FRAG should be constant 0, which denotes the field packet ID.
>
> This patch adds an assignment to hdr1->field_selector to make sure that it is
> always 0.
>
> Fixes: 3334513ef484 ("net/iavf: support flow director for IP fragment")
>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2021-08-29 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 7:57 [dpdk-dev] [PATCH] net/iavf: support FDIR L3 fields for IP " Wenjun Wu
2021-08-10 7:42 ` Zhang, Qi Z
2021-08-13 13:59 ` Ferruh Yigit
2021-08-17 6:35 ` Wu, Wenjun1
2021-08-17 6:49 ` [dpdk-dev] [PATCH v2] net/iavf: fix wrong FDIR L3 field set for IPv4 " Wenjun Wu
2021-08-29 11:18 ` Zhang, Qi Z [this message]
2021-08-17 6:50 ` [dpdk-dev] [PATCH v2] net/iavf: support FDIR L3 fields for IPv6 " Wenjun Wu
2021-08-29 11:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff1fc48ee804acc9350cad327db1dfc@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).