From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8882BA04B5; Tue, 27 Oct 2020 11:53:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D27C2BD5; Tue, 27 Oct 2020 11:53:41 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 22E282BD3 for ; Tue, 27 Oct 2020 11:53:38 +0100 (CET) IronPort-SDR: aY0wP2IJ+1qKO6NFmdJk3fGOEa/QgPREQDRrYsBrJbHagU/9Rhc3XilZ6+OcOXYwSxW8KtXEZu on427NqoNQdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="232245454" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="232245454" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:53:37 -0700 IronPort-SDR: E19WEi6B9c8L8jUJHfyPxGrz2WlOkwtnjCQhFbD7/sFH5NpJOHUSmAZBcOnlHSAPM5Io+hvnsj 1glklqC+OKYA== X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="468253111" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.87.204]) ([10.251.87.204]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:53:36 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201027062406.243081-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <9000f348-ab5f-e4a7-6048-ced2fafdef66@intel.com> Date: Tue, 27 Oct 2020 10:53:33 +0000 MIME-Version: 1.0 In-Reply-To: <20201027062406.243081-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/txgbe: fix driver exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/2020 6:24 AM, Jiawen Wu wrote: > Replace the 'rte_panic()' with an error return. > Also change the type of the calling function. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev.h | 2 +- > drivers/net/txgbe/txgbe_pf.c | 12 ++++++++---- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h > index b708e6d43..fb1368890 100644 > --- a/drivers/net/txgbe/txgbe_ethdev.h > +++ b/drivers/net/txgbe/txgbe_ethdev.h > @@ -290,7 +290,7 @@ void txgbe_configure_dcb(struct rte_eth_dev *dev); > int > txgbe_dev_link_update_share(struct rte_eth_dev *dev, > int wait_to_complete); > -void txgbe_pf_host_init(struct rte_eth_dev *eth_dev); > +int txgbe_pf_host_init(struct rte_eth_dev *eth_dev); Better to update where 'txgbe_pf_host_init()' is called and check the return type. Can you please check the following patch as sample: https://patches.dpdk.org/patch/81576/