From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7899068F5 for ; Fri, 23 Sep 2016 15:52:05 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED1A0D64B9; Fri, 23 Sep 2016 13:52:04 +0000 (UTC) Received: from [10.36.7.3] (vpn1-7-3.ams2.redhat.com [10.36.7.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8NDq2l8030955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Sep 2016 09:52:04 -0400 To: "De Lara Guarch, Pablo" , "Richardson, Bruce" References: <1469548587-3202-1-git-send-email-maxime.coquelin@redhat.com> Cc: "dev@dpdk.org" From: Maxime Coquelin Message-ID: <90027557-a2cb-f73c-5a7e-a577b8c12215@redhat.com> Date: Fri, 23 Sep 2016 15:52:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 23 Sep 2016 13:52:05 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 13:52:05 -0000 On 09/21/2016 11:53 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Tuesday, July 26, 2016 8:56 AM >> To: Richardson, Bruce; De Lara Guarch, Pablo >> Cc: dev@dpdk.org; Maxime Coquelin >> Subject: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC >> addresses tweaking >> >> This series adds a new option to enable/disable MAC addresses tweaking in >> l2fwd example. >> >> Doing that, we can enable basic VM 2 VM communication easily, without >> external projects dependencies, nor real NIC (as with vhost example). >> >> Example of cli with vhost-user: >> >> #l2fwd -c f --socket-mem=1024 \ >> --vdev 'eth_vhost0,iface=/tmp/vhost-user1,queues=1' \ >> --vdev 'eth_vhost1,iface=/tmp/vhost-user2,queues=1' \ >> -- -p3 --no-mac-tweaking >> >> By default, MAC addresses tweaking remains enabled, but maybe we could >> consider having it disabled by default to be consistent with l2fwd-cat >> for example. >> >> Maxime Coquelin (2): >> examples/l2fwd: Add new option to enable/disable MAC addresses >> tweaking >> doc: l2fwd: document new --[no-]mac-tweaking option >> >> doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg | 311 >> +++++++++++++++++++++ >> .../sample_app_ug/l2_forward_real_virtual.rst | 24 +- >> examples/l2fwd/main.c | 39 ++- >> 3 files changed, 358 insertions(+), 16 deletions(-) >> create mode 100644 doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg >> >> -- >> 2.7.4 > > Acked-by: Pablo de Lara > Thanks Pablo, Just sent the v2, but didn't applied your Ack since I did some changes, even though trivial ones. Regards, Maxime