From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58FF9A0A02; Fri, 26 Mar 2021 10:12:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5B0140685; Fri, 26 Mar 2021 10:12:42 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 626F14067B for ; Fri, 26 Mar 2021 10:12:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 09C395C00DA; Fri, 26 Mar 2021 05:12:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 26 Mar 2021 05:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ykb4HcPacNaANmvtAe0/mbJZDdEI+g3MdTiOX7eP4KM=; b=Xo0wkPLtdRKDHU+t eSaIXnRM6nSyyYNZ0RiofmuipLkb4QinDytTaxL3OigLiEY7h0i3w2XO46ZvrUX+ BSRsMg7/qgsWL9Wtl+lB3mW22/wOUGVSy/qrz31wmeMVfxLNdkLqUJNTZbuww6sI TNBaOdFEL9ebDJRYDsdKF2AFVTuLtlAZ1LPsR/Qj6bKJXlEFtkE+Y5bxrb7jsgli EbqxobhPWxaXjziO4dchung4zPMu8+N6hf1OyWBtdNRqtxiQ5MFFBMW0hdKL4S+p +IrtujK5snCKK+arbBBWu1BFpPW7T015AUkWX2ZGQPatFjXkYVRFmLI7IlUmSLVz OT6Gzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ykb4HcPacNaANmvtAe0/mbJZDdEI+g3MdTiOX7eP4 KM=; b=khuhdN+ILW+Iw4zGs8VsPJymVm8CmhYNNuWzFRKm6kF1UyPnudSpfBOID L6K4MJJ85js3inKmYCzbdyw8cLWpUDI1BNauby+B5hLNIpr5C+1YX6L4hE+JdWzs KKyueNxZdT3lLKvRoac18wulnac5/3WvcT7siXTxH52Vn8h1v+PeOHz5CgXd8kb8 WMdiKIbG8bi9gbAO9X3javqKXI5om0WI1rH4wVw+87md4jA286VrsRV0KbpTl0ty y3NK/PMroiJi769YxsEG/TzywNGe3GfuhdDPp1I1zok1daN+T54aFyDMaLCRDE/x loHBHgA3aNHLrudoHozx39XTJEFOw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeekuddrudekhedrudeihedrudektdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (180.165.185.81.rev.sfr.net [81.185.165.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 130CC24005C; Fri, 26 Mar 2021 05:12:37 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Tyler Retzlaff , Jie Zhou , Olivier Matz , Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Fri, 26 Mar 2021 10:12:35 +0100 Message-ID: <9009917.79gZZNtG4R@thomas> In-Reply-To: <20210320130525.16452-4-dmitry.kozliuk@gmail.com> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-4-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2021 14:05, Dmitry Kozlyuk: > DPDK code often relies on functions and macros that are not standard C, > but are found on all platforms, even if by slightly different names. > Windows provided macros or inline definitions for such symbols. > However, when placed in public header, these symbols were unnecessarily > exposed, breaking consumer POSIX compatibility code. > > Move all shims to , a header to be used instead of > by internal code. Include it in libraries and PMDs that > previously imported shims from . This shim could have been convenient for applications. If not named "internal", we could export the header file and allow apps including it. Otherwise the app can recreate this file on its side, it is not a big deal. Opinions?