* [dpdk-dev] [PATCH] net/enic: fix packet loss after MTU change
@ 2017-10-23 20:23 John Daley
2017-10-23 21:36 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: John Daley @ 2017-10-23 20:23 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, John Daley, stable
If multiple Rx queues and Rx Scatter are used and the MTU is
modified so that the number of mbufs per packet changes, packet
loss is possible.
The enic completion queue index was miscalculated leaving the
upper half of the queues uninitialized after an MTU change, possibly
leading to completions on those queues not getting processed.
Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update")
Cc: stable@dpdk.org
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 521167063..793260504 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1119,11 +1119,12 @@ static int
enic_reinit_rq(struct enic *enic, unsigned int rq_idx)
{
struct vnic_rq *sop_rq, *data_rq;
- unsigned int cq_idx = enic_cq_rq(enic, rq_idx);
+ unsigned int cq_idx;
int rc = 0;
sop_rq = &enic->rq[enic_rte_rq_idx_to_sop_idx(rq_idx)];
data_rq = &enic->rq[enic_rte_rq_idx_to_data_idx(rq_idx)];
+ cq_idx = rq_idx;
vnic_cq_clean(&enic->cq[cq_idx]);
vnic_cq_init(&enic->cq[cq_idx],
--
2.12.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: fix packet loss after MTU change
2017-10-23 20:23 [dpdk-dev] [PATCH] net/enic: fix packet loss after MTU change John Daley
@ 2017-10-23 21:36 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-23 21:36 UTC (permalink / raw)
To: John Daley; +Cc: dev, stable
On 10/23/2017 1:23 PM, John Daley wrote:
> If multiple Rx queues and Rx Scatter are used and the MTU is
> modified so that the number of mbufs per packet changes, packet
> loss is possible.
>
> The enic completion queue index was miscalculated leaving the
> upper half of the queues uninitialized after an MTU change, possibly
> leading to completions on those queues not getting processed.
>
> Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update")
> Cc: stable@dpdk.org
>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-23 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 20:23 [dpdk-dev] [PATCH] net/enic: fix packet loss after MTU change John Daley
2017-10-23 21:36 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).