From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E296DA056D; Mon, 21 Nov 2022 22:41:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CC6F42D30; Mon, 21 Nov 2022 22:41:27 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 99B9040DF6 for ; Mon, 21 Nov 2022 22:41:26 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3241D5C0152; Mon, 21 Nov 2022 16:41:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 21 Nov 2022 16:41:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669066886; x= 1669153286; bh=c2BxMsqMhTEPbiM+6HqGw5q+6yx7maYiq32xv+NVMbI=; b=p SKbR96ffIaF04TQZviRNVLyDtAJTGxUKuedI5VuuGDEbsnfs57azKESHnVoT/3jM 6GyyMrUSkXyZK4qUX1Yo6PveDpo2skdKiGSWEyqzBrJCW6XUqmXctPyxIdwYZKMU IlDV5Y+Muid4n268QiiFzCqBFygalw/6A5JgsWwnw4LofHipyw9IX8y50XAvVans wJti5p2lv0TWKEVRQlXxcTmZ0mRIdtcuHXvGjRVaJoTgCw1wI41vkH/O88d3AhKM HKNPUzrvkT08Gvv8Pe9vMaNqE2PMl582Em4HSnmAwVIfnRkFNdWIdrVUxUl1+Uu0 p5FgyNYqG82B4AsqzdsCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669066886; x= 1669153286; bh=c2BxMsqMhTEPbiM+6HqGw5q+6yx7maYiq32xv+NVMbI=; b=F YWpdH2N9z3luGpk6aU6MFiIV0Lh3sVHRBsm2CFZ5sr4BctK0mU94pjK+DqOlp8xX KNzGFxqr6ExCZuC+iY7thmFNYU4nVYzEHtMAhDrU7iHqTb+r5aRkX16iN85IYVY0 27d9RMtNAxtGXxjN25FKzapoMcMHelsqYfWDN6CoY9F2JppsWeLPr4D7zgwDr5Hl T5Z17lPuLKHQ2yBaDvEA7GGRQ08RuatPct0218sS8QIsTf7nqxvomc+oxvsYLYeC zCySBNDYuP4fppUz0GE3ynBvZJ8fEmXNBUlx9BEYyLB9HQtupzKJDm2QzOzyhEuP GXY0sJOz7WQOaB65zsxsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeigdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Nov 2022 16:41:25 -0500 (EST) From: Thomas Monjalon To: Sinan Kaya Cc: dev@dpdk.org Subject: Re: [PATCH 02/11] net/tap: check if name is null Date: Mon, 21 Nov 2022 22:41:23 +0100 Message-ID: <9023252.CDJkKcVGEf@thomas> In-Reply-To: <20221121204015.1135573-3-okaya@kernel.org> References: <20221121204015.1135573-1-okaya@kernel.org> <20221121204015.1135573-3-okaya@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/11/2022 21:40, okaya@kernel.org: > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev) > struct rte_eth_dev *eth_dev; > > name = rte_vdev_device_name(dev); > + if (!name) { Please it is preferred to check against NULL, because name is not a boolean, thanks. I know it's longer but it is more explicit. Thanks for the fixes in this series.