From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id B77DAA48C for ; Tue, 3 Apr 2018 12:53:02 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id v21so32863173wmc.1 for ; Tue, 03 Apr 2018 03:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=VmU/h+5nELgwZNYKm1c5SIB2itNZtgwwUT6WX0w53b0=; b=pWd7lC/nrBfk0pQGNaD20FksFRC8KCXRO4VN/DNGF1Sw/Du1Rd6lsUi03+sNdBxRFQ IiRtrRAMiSQOnaBF6+Jzm2hIsGq3DMI0ZrlFRin/RIcVZRHrD67UEav38VLlg4N5Rh8q RloN1/8hMRq6EqAuqkS2VPhJQrXAuQ76scspxzoglZyE+hyREjM/4a2K7e/ruObV5FgQ GGdqVUQ1anBq8PtFesuLlMvt5jxnC3tRURPV2lT6aZGVfsEK33SLY7mkFqYvSzeb7Bcf w+t7BebRPA1LyaLZJIrZCb+Ho8A7/rbC5tOXGRpjQ3GPKo3tHiz8e4caOhsPVGNTHmyk LSbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VmU/h+5nELgwZNYKm1c5SIB2itNZtgwwUT6WX0w53b0=; b=HP1aUYzfJMAngTrkMj+2/Mdcc4oLusjqwF2SZHefMZA6/Bv3iv6CH3N5h9LSJSrp3U KYNutIZ6V6zVkXfga5Vtd83iKG+7cvd9Rbosw5MuEW3dZnIK1kqn1MdBGeGkh94SfQEk AOpbRnWXlzDWrAo02xGD9xnDq2P1PCXFfXYnhbh5sjfpw8yBTVmREVxamxMhVmpo89nA t/PFgH2AxCqqrfmJ03iY5AExIDzz32Bs77zRNb1KZT63oFFEnyzryVOOavpepmsTq2FN LYBiHj9wpmy9Jz+hrz29rjJYWLKFs/url1CtuOhdrsg9Tp5/LJN1cfRKNbo0tJ+5jlmJ 0hkQ== X-Gm-Message-State: ALQs6tA3R7sth9379mVwaTh9Tj8XVJIgS6nolz/L5F7RaPYxUYCwTs1i a0fsgegFPf4EWEavl9ukNVyXtV5sv4Q= X-Google-Smtp-Source: AIpwx48oj3/XXbM2d0VTPusTzau2E/AZRdF1u0gZB922DSDD0vEDh0YyyIdtB/UDTQFYS3kM2vM76A== X-Received: by 10.28.213.12 with SMTP id m12mr3558813wmg.98.1522752782100; Tue, 03 Apr 2018 03:53:02 -0700 (PDT) Received: from [192.168.1.58] (82.107.69.91.rev.sfr.net. [91.69.107.82]) by smtp.gmail.com with ESMTPSA id n143sm475741wmd.29.2018.04.03.03.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Apr 2018 03:53:01 -0700 (PDT) To: Ferruh Yigit , Vipin Varghese , dev@dpdk.org References: <1519625719-10443-1-git-send-email-vipin.varghese@intel.com> <1522705068-18198-1-git-send-email-vipin.varghese@intel.com> <1522705068-18198-2-git-send-email-vipin.varghese@intel.com> <53cf54c7-1dca-fb55-ebc7-690e7b095e92@intel.com> From: Pascal Mazon Message-ID: <902cd2bd-9b89-bbc3-2731-84fdbc790e16@6wind.com> Date: Tue, 3 Apr 2018 12:53:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <53cf54c7-1dca-fb55-ebc7-690e7b095e92@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 10:53:02 -0000 Ok Ferruh, I missed that. Apart for the type in "documentation" the patches are ok with me. Acked-by: Pascal Mazon On 03/04/2018 12:05, Ferruh Yigit wrote: > On 4/3/2018 9:27 AM, Pascal Mazon wrote: >> Hi, >> >> I'm not sure why you split this patch in two. >> It seemed to me that it was fine to change the doc+logs in the same >> patch as the code. >> Especially since documentation change is very small. > It was my suggestion indeed, to separate actual functional change from routine > log update noise. > >> Anyway, there's just the "documnetation" typo in the commit title, >> otherwise it's fine by me. >> >> Best regards, >> Pascal >> >> On 02/04/2018 23:37, Vipin Varghese wrote: >>> The changes add TUN|TAP specific logs and documentation support. >>> >>> Signed-off-by: Vipin Varghese > <...>