DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yong Liu <yong.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fix build warning and failure in Suse11
Date: Wed, 18 Mar 2015 11:50:30 +0100	[thread overview]
Message-ID: <9030243.H2PSOagFNB@xps13> (raw)
In-Reply-To: <1426662641-24781-1-git-send-email-yong.liu@intel.com>

Hi Yong,

Thanks for working on these important fixes.

2015-03-18 15:10, Yong Liu:
> Suse11 SP3 default gcc version is 4.3.4, some options not support on this version.

I guess some of these errors are not only specific to Suse-11?
Maybe that 1 patch per issue would be easier to read and could provide a more
accurate description.

> error: implicit declaration of function ‘_mm_alignr_epi8’
> solution: include tmmintrin.h when enable SSE3
> 
> error: unrecognized command line option "-Wno-unused-but-set-variable"
> solution: add version check in fm10k Makefile
> 
> error: enic_main.c:845: error: initialized field overwritten
> solution: change struct initialization code
> 
> error: ‘testfn_pci_cmd’ defined but not used
> solution: add __attribute__((unused)) before function definition

Please could you explain more the problem?
There are other constructors in DPDK which don't need the unused attribute.

> 
> error: unrecognized command line option "-fno-var-tracking-assignments"
> solution: add version check in app/test/Makefile
> 
> error: implicit declaration of function ‘pread’
> solution: add _GNU_SOURCE flag when compile eal_pci_uio and eal_interrupts
> 
> signed-off-by: Marvin Liu <yong.liu@intel.com>

Please use -s git option to have an automatic well formatted Signed-off.
Your previous contributions were signed "Yong Liu". Do you prefer Marvin Liu?

  reply	other threads:[~2015-03-18 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18  7:10 Yong Liu
2015-03-18 10:50 ` Thomas Monjalon [this message]
2015-03-18 15:18   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9030243.H2PSOagFNB@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).