From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0041.outbound.protection.outlook.com [104.47.41.41]) by dpdk.org (Postfix) with ESMTP id 94E252951 for ; Mon, 15 Jan 2018 15:31:20 +0100 (CET) Received: from MWHPR03CA0009.namprd03.prod.outlook.com (10.175.133.147) by DM5PR03MB2699.namprd03.prod.outlook.com (10.168.197.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 14:31:19 +0000 Received: from BL2FFO11FD038.protection.gbl (2a01:111:f400:7c09::123) by MWHPR03CA0009.outlook.office365.com (2603:10b6:300:117::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Mon, 15 Jan 2018 14:31:18 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD038.mail.protection.outlook.com (10.173.161.134) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Mon, 15 Jan 2018 14:31:18 +0000 Received: from [10.214.249.235] ([10.214.249.235]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0FEVEtF013945; Mon, 15 Jan 2018 07:31:15 -0700 To: Jerin Jacob References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> <20180115122445.GB29114@jerin> CC: , , From: Hemant Agrawal Message-ID: <90315b96-e3a1-b47c-935c-e6437cef2716@nxp.com> Date: Mon, 15 Jan 2018 20:01:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180115122445.GB29114@jerin> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605002783119548; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(39380400002)(376002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189003)(199004)(85426001)(23746002)(8936002)(229853002)(230700001)(5660300001)(81156014)(81166006)(65956001)(65806001)(356003)(47776003)(8676002)(6246003)(65826007)(36756003)(76176011)(86362001)(104016004)(2906002)(2950100002)(97736004)(6916009)(498600001)(305945005)(58126008)(105606002)(106466001)(4326008)(67846002)(31686004)(53546011)(316002)(68736007)(54906003)(53936002)(50466002)(83506002)(93886005)(64126003)(77096006)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2699; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD038; 1:2+TPRplUxlUHLbKT3ZaYbi5GY2k35CeILEadfowEeNhcfV96LK1q0PGgbzbZ/ej9feqNjExAMd/3Yu8DiwxqDXdEhSgWE1VgnQ37m7QZtHAJQ89q+l3l8n/e4o57vNK+ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97d8ee25-c41d-4275-58bc-08d55c24a404 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:DM5PR03MB2699; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 3:8vw8E5Ky2B+OdCtMkoHw0WBjqb98BlpkyGKUFiIfpLSxMpMEMt3Jb1o1DKYVlTStC2C3wUd03Z9SWZvH0xWiVao76fxen47oczMd5V1AXJTdq/2+/9M6M36+IOX+esA1vD/xTWbHRqsC5FCQ1BitgOAzxIvE8RheOnYLovi3n1Fq8a2wJ1EWjTYYYAnXG5sHW8CBfxQed8HZObavhlBLxrZPV9LS2zHoWOekaOLrX7P+vgGaYAYSacP/RJ79G03vFqreAxyQfonFeHvb/w2DjihLRZl62rpTG21eHIaV+OA/UREBKARDBCmbBUNwHTbirnd+8CcPcQZezOYOQ6l9Wb02Ld67XBmf8lc/yRYKu7k=; 25:UQ0IdQPUN03hrqdqfCpuVIMWH+EPNMlQbI5/S6AC9MJmIzKmmKlSJ30bv0d4IqXC5hbM6qYbwqzO3ptAZM5xE/2tIUz1fLmaERniWCN66hsdKJi3M3j4d2T/vGFymJCk78XQFLsJr1fVRd1HCWXmmMutGWIzS45xYeJgcusLyevRHGTp2h9rJBX/OVF8mp81YIFFBcnYn5Jpvo7FgvIPbbRx6ViO/xZgUgtQNQVY4M3POlRgDG5ya4YU0bgv4KJRA4OP4zsAJrQsNr4qt9GF9RnfBYwF2yDG545Hmf1yR9Q9Taqlo1xsMllLHFMjBEXML/Jwk+c6X6IWnYyalcxmgQ== X-MS-TrafficTypeDiagnostic: DM5PR03MB2699: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 31:7OT99npoztQj6jARKy4xzhczQkmxCVzyiNYybgyBZoyeTqm3qVNR80lOybdJMliqid5QPizR0tC+ez/0Vpwj6LK27z7/YMBYe5TXQG2z8tzxULVE7iRC16Hfk1fbrainKeyEGhI1Iqh+/xoqWKoWMkOHYmArFmTvSVePkeNFoAcjB/obpIb1lkycrOaMKFE1ojECEHlENUXSIZx86MZOJI0rTfhgeC6c6k2SFg6zitk=; 4:zPNF8ypDOEMHn1x9uDyeA4pCdAXdMy0YZYpClMY2V/z/F/87rNVzH+JGv3uMULZmHTNb8iI4BSWFLbrb96CFdrIOulblTQp6BVTBQiVi72vpeMyrhfXDkPyhXNzSe41pxkUFKxqAutyU6xCUtzXn928j+Om7rz8knSDBt1Rc9AMCIML+cDJHoBpskqoyPafDKbQwFmvnD2sBJ0Ee0CtYKt9Icw0dLPgDWkVQ+hYrH1FNBdtI0XPHF3nv9LcXN/NALyGN55eE0O4EJ1FRxXOC/w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3002001)(3231023)(944501161)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123563025)(20161123556025)(201703131430075)(201703131433075)(201703131448075)(201703151042153)(20161123561025)(20161123565025)(20161123559100)(201708071742011); SRVR:DM5PR03MB2699; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:DM5PR03MB2699; X-Forefront-PRVS: 0553CBB77A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2699; 23:tQhovPc6ntfzha1kkI9HafwOjTAcg73apSAX7?= =?Windows-1252?Q?IP3yOa3/CCwcn9DiTV6wyJf0sEF7Dw/Hmyapb03Bt48NZFoQXWSUUXUX?= =?Windows-1252?Q?T9uZCh9cVkxPdbFmxCRB9Iy5VaBiJZhZmopeOKwz7ltbtI8Qym0BaQoq?= =?Windows-1252?Q?Z8VZF82yy7ESQo84VQAWzprZS8ZCZGP0z1Tt0S/Syv2ee0KzUTghNRZQ?= =?Windows-1252?Q?x/gVsEAVdJwxOTem0BUog/xH6um0aWY5qtSMx+M7q7hH8zhiSY3A1BCG?= =?Windows-1252?Q?U99GX1XHN+j31AWXJIfG8k3M+ruMG2cUDeAwCgeWOvrkUV64NeQYJ/Q3?= =?Windows-1252?Q?RrR1PRfgj3NYIgQCMgdDEeZH6mf0Dl9+SCbJ7SSTbEYcZGGYk/TXOGFw?= =?Windows-1252?Q?NKk7d3v08GIZJ4e+qx1InlMyitIE8zqNJecgfSABDRUTnRFu5gBTHiCk?= =?Windows-1252?Q?ys+Djp5XjnEMojaPE153tKHxM37442Bk8cy0FMMEJ7zlvsAnocfeunbN?= =?Windows-1252?Q?WuTcl+DwpG1FxkpBc200GIn1cWo4kiHVPWm7mBR5UsXLikE+xlqxqABq?= =?Windows-1252?Q?0DuZje8ZegyMxlYx/H+ruMCqq8A+UEGqocnhMemW7VYYNoHB2jdONUH3?= =?Windows-1252?Q?/CYM1lDbFNlO/v25SNi/uHFDTd1ZFZstS7kHQVvhRDw5hipreVf1p8NC?= =?Windows-1252?Q?C5bU1WnRUuk84U30zUk4USWxig0S24zEaBGn39dRhgczyvUrxQJ5Bl4m?= =?Windows-1252?Q?CAI0pX/jzlruLulPiBBU0IJTTdI2pQtVMvNPM1yrWH9lhuoqOnfuLB57?= =?Windows-1252?Q?SMHDifez0JGkSS6inZZatTTm3UmlPC7gioH2f4jrtR4iu5MAARDCJkZV?= =?Windows-1252?Q?tDVIG+//kBpzQ7STk8h6ioeYBIVYXxoTJCbfnJnVnbYBuV/08h1HI/9v?= =?Windows-1252?Q?pcB9O6f7dFDxYJdR/rDdr1p4+8vjZbRnzlFVBZmYWfMnX6f22C32OtpR?= =?Windows-1252?Q?n3pLlDTH1pmVe54Ne4tBUyphD2uHhVmZquledBbYniPSJ/4KWkqi1r/r?= =?Windows-1252?Q?pCG2HlwSaNkS539rSl8R+GgKRbpX3SyMejrK0H7kM9OjxWqf8e86qRrc?= =?Windows-1252?Q?1XE6PGA7INqY9zf7FrPX8vB69XASJKpk2P396IJBYGFSNu+q8V8EsO7g?= =?Windows-1252?Q?YUiqrG6IPVR7cRXdJFrLJ+RRAKeflJ6bXpHFwQj730rKIx9nHzxsjW0L?= =?Windows-1252?Q?yXGtO8i230WchIO8NB/iNp77U4G+DIQHM+1F5odHxFfcyDaCJH2i5Cv6?= =?Windows-1252?Q?6c/Cm6AsTMlGaAoR+ZsSK8ZDlT6fyjrEM9ZEQhfaR1Ho+F2wDa1hBFR8?= =?Windows-1252?Q?2YHkRDWlZaX?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 6:fnJFH7S3WOAqBjvwjtvb+kArozepqxuMrzX0x3YuqWWuNEjylb+k36FbNyk2AkS5CuoNF5oVwnJRIfEyWjTQyKvQUHx93iL7DfXbuO4FWAo04Ufh2IXLSJihIdAHyflAaM6VZO7sbfGYHd5Y2NuAx+bw1BgJ543G5p0eMT50EvRtSMwJGWy3Vatj9rbhUqiL9C/iY81eIKUNPSJ2TBl5b4F6Lyzqg1oNC0XHSoMgtURZNt3PPW4OM9ep/71zcCm2l6MtKQekBob4esqy1Nniv1YXNFNvc2RQ37Ga0lmVQGBhj93Oh/HdqjMm79a23vjpvCIlv1VqSdMmRioMHnEAPxiJB1jD1UsXU8iaoUPv3Es=; 5:3PzMhS1j7ejjA8aQLd7pbnNlZU2pl4jlvTAOcLob4Hv3oXzMlJyutw0WRISZdOZvysh1s5HSsKy/ypy/2Qcplh/lVUF4/06xeCCTA1Jyb4JXexDuMNYcYTS6JXIICveVoc8GPVdNlOv5qk7G/I+7FG80sSAaiEIOwCafd1Me4z4=; 24:2+c+/J90oQRQ34iS9alqqjsCF6NuLFPfI2WVf09OAEa67P47KS+Bgth6uaP3jA4UvwMLGoTq+1Gw/tKdWnKApzos0TOYOdddZ7PNV6OhIo4=; 7:6sXpc8iKeqliBcjs3SpyiNr31Y5RULQFdG6/MF7naXKzOHfHprlUvwem88ear2xa992m9exvAQu5GwbSDZ9BF/z8qEAb1wrgiXRu4eHmaMfaQnIl3t7G3E9p9CV+KN22tr+cIwkTiACdEa5FJLXPmgAPGbDybq7pVelI0HDlHgW9B/2fiSvgiAA5VozL6ZYqjCnLrLIRBKOnmorejwI79+Q/XeBd8ZHwNqyM3qoxs2HbVmQGRFsErDNFQjur9LKe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 14:31:18.1403 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97d8ee25-c41d-4275-58bc-08d55c24a404 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2699 Subject: Re: [dpdk-dev] [PATCH v2 2/5] eal: add platform mempool ops name in internal config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 14:31:21 -0000 On 1/15/2018 5:54 PM, Jerin Jacob wrote: >> static int >> diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h >> index 1169fcc..12c5b8a 100644 >> --- a/lib/librte_eal/common/eal_internal_cfg.h >> +++ b/lib/librte_eal/common/eal_internal_cfg.h >> @@ -54,6 +54,8 @@ struct internal_config { >> const char *hugepage_dir; /**< specific hugetlbfs directory to use */ >> const char *user_mbuf_pool_ops_name; >> /**< user defined mbuf pool ops name */ >> + const char *plat_mbuf_pool_ops_name; >> + /**< platform configured mbuf pool ops name */ >> unsigned num_hugepage_sizes; /**< how many sizes on this system */ >> struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; >> }; >> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map >> index 3fa1e13..909691f 100644 >> --- a/lib/librte_eal/rte_eal_version.map >> +++ b/lib/librte_eal/rte_eal_version.map >> @@ -203,6 +203,7 @@ DPDK_17.11 { >> DPDK_18.02 { >> global: >> >> + internal_config; > > I think, exposing the internal_config may not be a good idea. We may > need "plat_mbuf_pool_ops_name" value for multi process case too. > Considering the above points, How about adding it in > struct rte_config and then expose too rte_eal_get_configuration() > On the downside, it would be an ABI change. Yes! I was also not sure about exposing internal_config. rte_config is also a good option. If we add these options in the end, it should not break ABI? > >> rte_hypervisor_get; >> rte_hypervisor_get_name; >> >> -- >> 2.7.4 >> >