From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76EABA09EA; Wed, 9 Dec 2020 09:59:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD36FBE77; Wed, 9 Dec 2020 09:59:39 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 17046BE73 for ; Wed, 9 Dec 2020 09:59:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8E6A85C02A1; Wed, 9 Dec 2020 03:59:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 09 Dec 2020 03:59:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= +5P1U1zICWxf8MZGZKbJdR4Uwh3DmzjO3FoiJzh8z9o=; b=azYPsao6vmwH7u+D xmizooW0lhCzw18GJTy9HaKAfErot03W892nwbjPa+I3sHHKQvw6b0NmUh+52EK8 kxFmMUgHaPDhcywdt200Ftg2KgDMEHHSg6AdbFo+2UTcHcRDedXI/0BLkoAANO1T FIxApU+E27908se6Wj8BM8eYWh9JRbV+1sqHRz1SFMK7RsNRdC0ko2FDpDfV+Hmw YwGf4AMvBeof9g7TILEi0N7XDfPDN+s20zhCnRQG2HmjuT5bCgoE4jYIBLWxxAr1 noj/liO+xoasoyAFF9k3vmPmg7HPOwDx7QcxqLMOWXN1mclcQCN4Ft0ONU2XQxA2 A6oJ5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+5P1U1zICWxf8MZGZKbJdR4Uwh3DmzjO3FoiJzh8z 9o=; b=DF6wtkOWyIIVZ4A6XRmY6PbS0rYFZSfFKHnmnA6++LEuSMlZoOvAi2HpS JQEzvK0MZwmCpcr2SR1lj4yF1yW5wYCMLz/84EgB9nhrwe0PLijIQ9A5NPvHh5JW 8RCuXXb2IiPkK1l1QZnKc3Dklucczbxdp4thwGfVlWXhnS4ol8Pv1dFIlQZUGLqT N8+uqc2UxNkdX3nTCHBWIdfT/ucZhwlZgKQMQIY5mhrZKvwGxXMDjcw1NY6AMlaa wEjRpKm4Yf9QJLYF09hresiREYAlSq4rcg7LDnlIugCXLdxhnAAMZ7INQIB3ibRl C62szCcXkyRROc6/3gpM2xLOH4bdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejjedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF8B1108005B; Wed, 9 Dec 2020 03:59:34 -0500 (EST) From: Thomas Monjalon To: "Kadam, Pallavi" Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com Date: Wed, 09 Dec 2020 09:59:32 +0100 Message-ID: <9032110.0djWmH6T1b@thomas> In-Reply-To: <3fdb608d-1fb2-a307-8bbb-3878f7a1f38b@intel.com> References: <20201205011020.6276-1-pallavi.kadam@intel.com> <1656459.hZBu3j2uRN@thomas> <3fdb608d-1fb2-a307-8bbb-3878f7a1f38b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/12/2020 01:21, Kadam, Pallavi: > On 12/6/2020 7:49 AM, Thomas Monjalon wrote: > > 05/12/2020 02:10, Pallavi Kadam: > >> --- a/lib/librte_eal/windows/include/rte_windows.h > >> +++ b/lib/librte_eal/windows/include/rte_windows.h > >> @@ -18,6 +18,11 @@ > >> #define WIN32_LEAN_AND_MEAN > >> #endif > >> > >> +#ifdef __clang__ > >> +#undef _m_prefetchw > >> +#define _m_prefetchw __m_prefetchw > >> +#endif > > > > These changes are not specific to i40e, please separate. > Ok, will create a separate patch in v2. > This change is required once we add rte_random.c file on windows. > So, may be addition of rte_random.c file and this change should go together? > Please suggest. Thanks, Yes absolutely, addition of random feature should be atomic in a patch.