From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93AE4A0531; Fri, 24 Jan 2020 11:11:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E251F2BCE; Fri, 24 Jan 2020 11:11:33 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 813962A62; Fri, 24 Jan 2020 11:11:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 02:11:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,357,1574150400"; d="scan'208";a="260195208" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 24 Jan 2020 02:11:29 -0800 Received: from irsmsx604.ger.corp.intel.com (163.33.146.137) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Jan 2020 10:11:28 +0000 Received: from irsmsx606.ger.corp.intel.com (163.33.146.139) by IRSMSX604.ger.corp.intel.com (163.33.146.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 24 Jan 2020 10:11:28 +0000 Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by IRSMSX606.ger.corp.intel.com ([163.33.146.139]) with mapi id 15.01.1713.004; Fri, 24 Jan 2020 10:11:28 +0000 From: "Laatz, Kevin" To: "Power, Ciara" CC: "dev@dpdk.org" , "andrius.sirvys@intel.com" , "robin.jarry@6wind.com" , "Pattan, Reshma" , "stable@dpdk.org" Thread-Topic: [PATCH v2] usertools: fix telemetry python3 compatibility Thread-Index: AQHV0H3iNQIpDl7PRk2DtVk03IeNGKf5nAqw Date: Fri, 24 Jan 2020 10:11:28 +0000 Message-ID: <9061c5b6ad93430c86382f8d7661175b@intel.com> References: <20200116172425.19246-1-ciara.power@intel.com> <20200121170310.25382-1-ciara.power@intel.com> In-Reply-To: <20200121170310.25382-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDdhZmU1ZTItZTFhMC00ODE4LTg1ZTYtNGMyY2Y0Zjg2NDBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicXRaRzVQQ1ByTVpRZHdqZUdKajdORXF1aTBoZTkySzBVN1JncjVXTFgyOVlEdnRrUEw5bEpMOUU4NEszM0o0VSJ9 dlp-product: dlpe-windows x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The client script for use with the telemetry library did not support > Python3, as the data being sent over the socket was in string format. > Python3 requires the data be explicitly converted to bytes before being > sent. Similarily, the received bytes need to be decoded into string > format. >=20 > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Fixes: fe35622659ed ("usertools: fix telemetry client with python 3") > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: andrius.sirvys@intel.com > Cc: robin.jarry@6wind.com > Cc: reshma.pattan@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > Reviewed-by: Robin Jarry >=20 Acked-by: Kevin Laatz