From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF58642EBF; Thu, 20 Jul 2023 11:08:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D47E40E2D; Thu, 20 Jul 2023 11:08:14 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 833DB40DF5 for ; Thu, 20 Jul 2023 11:08:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6QU9Qck/D6XrA7oG8REzXWTxvJvqEwyBwhsJ3cTBrhjLm0UCcS+Xu3jEGiqEET7wE2caaAz22rmvOK4U59wLz24sU51IiCUmBNlbRW6E3ZAmGESo1OtQDWxWPh5rU4B1hwjIoqBivBOcRsuqO+sbwmcx5ifS5XQTiIqYMr+g58Ov+CXdVtLv25Q7ffe9lneZeCBN/rWrODkISHymeMKQlVthDmrAxku/oMLLGfCG8nApj78kZITqlLF0BwTUoq/j1z38iwsT/fTnUNDkFBjLdhSFXSzNG4aIK2GJypG+yszJF7dZKVaL0SrEtmCI9UQJJU64FDAAtwTIEs0w68nrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NjBa144rcWIe8BT+tXGXKRq6vPYgyCWYRwjo2UmR3VA=; b=mwS+dUS14EfFIvurXdxEURj4mP/K5esCwmS6GtSor73ljA10flP9j8OMGNzu4MQpZhGvvz1BEBcAcyw7Gsf5L1pDJz3+uL/fFdnXnj3jHeKJ5IfSfqn0K9MpUCdiixIwklFw8bGLgDuCJR/uv4QVX3pitdMpJmPGHbJFoWlh2j6FuCJNuFkPogv80X/dvjKDFvr4FYRKRQx60f/X4pykSTS2jK1U++rFO5FJ9M2Zl3X5/CbiDimu/EBvnTt+nTbZyEtwNCFyg4mMleLblZ43GYTmqrQphC4Sdm9zmFwyxbw2C0z3zSDVjej2Dvy0xrxgjlC+DRJNcgIZLPvkMs95TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NjBa144rcWIe8BT+tXGXKRq6vPYgyCWYRwjo2UmR3VA=; b=XR7LCg+oNIBc5y6zP1kyf2yR1dJn42ovqxatenwKkKRdqZysM2XxfJrjtzT/T6J84/hy/kZT7zOK3nC2LoGBnxCQIienc5QO/iRRlN8NAJ2V/Y043T2gFs4tqmK332ppTJGR9vl/SRqZ6PUApTrHAjsnzre5BQElg91JLXSyuSU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5272.namprd12.prod.outlook.com (2603:10b6:208:319::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.25; Thu, 20 Jul 2023 09:08:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::15a9:4e83:4217:8b49]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::15a9:4e83:4217:8b49%7]) with mapi id 15.20.6588.031; Thu, 20 Jul 2023 09:08:09 +0000 Message-ID: <90916e3a-05a2-f601-1d3d-985dd31d7419@amd.com> Date: Thu, 20 Jul 2023 10:08:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] tap: fix build of tap_bpf_program Content-Language: en-US From: Ferruh Yigit To: Stephen Hemminger , Long Li , Ciara Loftus , Qi Zhang Cc: Ophir Munk , dev@dpdk.org, Thomas Monjalon , Aaron Conole , dpdklab , David Marchand References: <20230717191548.16429-1-stephen@networkplumber.org> <3d8938a4-acb8-45d0-291b-133ba0157976@amd.com> <75eef8f8-c0c0-1950-6149-756bd624e9d6@amd.com> <20230719091249.0ea91a4e@hermes.local> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0234.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:372::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5272:EE_ X-MS-Office365-Filtering-Correlation-Id: cb12c4af-8fd4-4272-f959-08db8900d651 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KGa7kqZtPgB6J/jXKVIrU+6PmHlEgqwzw1pSCvaAMOz2x9Uy40XZ/GUZq/OUzeBlXM2vpU/6XHH7lmqm88792nt2IWCMh1WjqbsUiWnoaDT2F/DT89nixWbK2nX1iQ3Jef8Od0jDHJ82rOXMMvhJXV6YzXUdWQHMoheyDVLt252vu7c8b6S3BqZn+7TDdn73s2QT0/2rMNDdP47cmaSWOtK6Kt/NcjppypYBNbjCcOBOdmk5JcWSiOc+46LUc2UOhZ2EkDHr/oyl2G58TMZiFlIaQ3It/MDjDKwh9DRrTPLiEnLgl7gWrNco6tfEaFXB+RmCkle+6hVeFogjqtKYMn1yKfCpuRhPzhbsacWOuvAcqFWYUzUZW7H/gyVJBrWhNXTMek1E0FRsUJ60wnshD9+bBelz7zJxd//Te1aO/TrHiRXG4Y8sm3f1Kbi820ilriY2llcUZVWRFAn06le5+3PpoHBzvb3iL/JmVa5tlVYuAimZEnScNYcCsrnF+7/BqN4hjWWK33f+neP4QZYYOvuclBG2sdlwAvTHKiA3lnqPAgRMOf4EDkATPGs9wlBRnL9dt1IwAJRC52sAtxK88xZFrT9AidHCjlJmatj3IbbEOcX0hoXCe8QpFbdrThpy/GtrCLIlZNGDjocmt+wLdA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199021)(6666004)(4326008)(316002)(6512007)(6486002)(110136005)(26005)(186003)(31686004)(41300700001)(53546011)(6506007)(478600001)(5660300002)(8936002)(66556008)(66476007)(8676002)(7416002)(66946007)(54906003)(44832011)(2616005)(83380400001)(2906002)(38100700002)(86362001)(31696002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjA2UTJlQXZWRjJRY3dqNUZyYmFGdjR2YXdnanJubVVxdTJTVEdVR1ZKa0V0?= =?utf-8?B?RHJtbU83MHd6Skw5TkRlSm42WWQ2RXhXcHlmVkJYYU4xbHk0WENwQlZFcTdU?= =?utf-8?B?QkVMbklOQUhGR081MDVrK2FzYkJDOHZjckRjajNVbzQ1OFRKaVQyRjRrODkz?= =?utf-8?B?OFFJWTMxUmhCMzRXTnhrQTRtZ0kwb3lhWXNTWUV6ZDQ5eFlFQlVnWUd3UVJQ?= =?utf-8?B?SDZ0WFhVSkIxa2gyUDFtZVRuM1BLQnM0bU9vbElEMW90Mlk1Q2tDUVBPVjN0?= =?utf-8?B?dXVSK3BSWWpkdTFrMjhwaDJKVm5mamxuclFFSE8raVRVejBYZEErYVRWVC9v?= =?utf-8?B?SWZVVlNwenZUU2pyajVJWHY1K3pFWXd6dDVlNmNwTS8zOFUvMC9sYUl1cE5D?= =?utf-8?B?aUpDYXVnQ25xMDhJNDYxOFFQa2R0WGdocGRTS1BTcGZxYWVYeXhWWUFBdEQ0?= =?utf-8?B?K3M0d0c1V3Y1Z3VzMWIxQURzaUF0L0htczQ1MTF3Q3lia2R3QnVhUnptNzIy?= =?utf-8?B?MTYyL3g0TWNzQ05Pd1dFR2lkSmVVMlExdmg0YStDazZPTm5WVzA4amg0U1Bs?= =?utf-8?B?RE5zcmowOXlqTHBCNHBLTTNtVjlOeGFXajY4cXNiWnFkTjZQWjNPQ3BTeFhH?= =?utf-8?B?ck42SGVrZ0JNdmhFVytTUFFZb1NONGQ3SWlZcVd1MnhpRDltVWtKb2hmSXIy?= =?utf-8?B?VnlxTHVrcWgrS09aem5hN290V29WU0k1cElObGlOcmpFTC9nVzkvbkZFM29B?= =?utf-8?B?NmVraEhocVpmZVlUSWhkSGpodGo1aE00OUVTc2U0b2xHUGJJeEZYVE80U0xo?= =?utf-8?B?TllZOWtRN1pUWVBreWFYMEdqSFdjYnQ4cExzdi9aNVdKczdEZ1c3Tjh2NERD?= =?utf-8?B?Sk9JTU5lRmFjcjNEMTZRMk9MWHQyT2ZwY2YxYkVxbkp5a3pVdExmQzhZYlhz?= =?utf-8?B?d0FpeUtCQkF1U2pUaVdHZkpBamRFNGZWS2phZFBiNGliaVVyNXJMUkc4aTkv?= =?utf-8?B?YXd2Y3dwMU1uZTBqSVhVZmxVOGpwV1h2RWtGSVdURW1FRnM3ZDhKOXplSWZF?= =?utf-8?B?OEVsLzlnajBwZGNtRXFjazA2ZGkyWnQrY2ZYN0Q2RUVEQTZad2lWWVozcjhm?= =?utf-8?B?ZG1mckZXZXVXMzhFK0c5WjhwS3A0dkZHRE9CNXZNRTdvaE9uOVZPMVJsd2FD?= =?utf-8?B?eTNPb1BzRFJRRmF0WllnbjN1TGxQeDVaVVZxUnV5aUFsQnRZT3NhNEdlU0ZY?= =?utf-8?B?U1U1Ylpkd1d0TUZEMm10NHR1OUtzczZvZ0hZTk9nSm85RE9VV3daeFhMREVS?= =?utf-8?B?eVE0bFZ1emM2a3JMdVFvcndnMmJJekZoTk53ZkpDS2tscFUxQ0JLYTIwWCt4?= =?utf-8?B?NyswMzVaeGc4WklsTE44YzRyK1pmNlVsbFJla0E0YWw5S1l1VDU0SVhUWm8w?= =?utf-8?B?TEc1SUQ4dHZ4QTR0VHNCQ1FZckQ0cGxtOXA5aHVzdVY5czNZcm56MGo4MmQ3?= =?utf-8?B?M1Ard2liTU9YNDVlRm9tdjJIUXdJRDVUa1J1ZkJPUlU3TlRLM2NFNG5qTnRE?= =?utf-8?B?dG5MNXppNG1PZTdUMUkvcU15T0FJNEExakM2TE1WQnVXenVHUDFXMTZKQzRv?= =?utf-8?B?V3JLeWRpVzRhUk5PTEJXS2lhdEdNL1pKay9iUTJTWldoNG1tbWpGcFRqNE1I?= =?utf-8?B?dHhjRVBtMXZtUVBqR2IzT0M2Q2poSW04UkZrWXhSUFRCWU5lcTJXa0pwNk4z?= =?utf-8?B?TE10cUpVYXlvVjQyRzFSSXNZbHFmWGF0QnVaMXQrTnVBaFJaOTJmMkVkQlNt?= =?utf-8?B?RXBEYlJOcVNsS3piVGRIZGFtMVYvWkNXMG9WUTNsSGpqWXI1UHBGYllBSUVK?= =?utf-8?B?U2p3ZmsyckpKNEpjRUtybnZTRjlHVFpaK2lXcC9NalZYTVBPRDdWWDFVUkhH?= =?utf-8?B?dEhCZ0ZNdG1Vc0ljOHJlaUhlU09VeTVQSGVPOUZ2UmFxTWhZVmM0SFpLRS9m?= =?utf-8?B?WFhJQVhWVGcxVUU0M29saDRTUTg1c0JQSElKV0lpM0FFN0tOekFhMkRyb0U2?= =?utf-8?B?T0JGQ2tFcDlYcGRMbTFZUldhT01YbFBOaWUxQzVxVCtFVzhveHNKWHNkcEhh?= =?utf-8?Q?LrRFRQ6ynPhyY11nvtSq/XKpr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb12c4af-8fd4-4272-f959-08db8900d651 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:08:09.4450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KTiEFwhX5p5RArBoVwhhPKq0OA/w++drxgEQ3cWhA9i19aYKnrAhpTtLHZR4oVNV X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5272 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/20/2023 8:45 AM, Ferruh Yigit wrote: > On 7/19/2023 5:12 PM, Stephen Hemminger wrote: >> On Wed, 19 Jul 2023 11:03:36 +0100 >> Ferruh Yigit wrote: >> >>> On 7/19/2023 11:00 AM, Ferruh Yigit wrote: >>>> On 7/17/2023 8:15 PM, Stephen Hemminger wrote: >>>>> The tap_bpf_program.c is not built as part of normal DPDK >>>>> EAL environment. It is intended to be built standalone >>>>> and does not use rte_common.h. >>>>> >>>>> This reverts the related change from >>>>> commit ef5baf3486e0 ("replace packed attributes") >>>>> >>>>> Note: this patch will cause expected warnings from checkpatch >>>>> because the code involved is not used directly in DPDK environment. >>>>> >>>>> Signed-off-by: Stephen Hemminger >>>>> >>>> >>>> Agree, this seems done by mistake as part of batch update, >>>> >>>> Acked-by: Ferruh Yigit >>>> >>>> >>>> But I can't update the bpf file at all, if I am not missing something I >>> >>> * I can't *compile* the bpf file ... >>> >>>> am not sure if we should get just this update or have a patch/patchset >>>> that fixes the build. >>>> >>>> @Ophir, how the bpf file is compiled? And did you test it recently? >>>> >>>> I am using command from the documentation: >>>> `clang -O2 -emit-llvm -c tap_bpf_program.c -o - | llc -march=bpf >>>> -filetype=obj -o tap_bpf_program.o` >> >> It looks like this won't work because it was expecting to be able >> to find header files from older version of iproute2. These are not >> distributed, and the change to support libbpf in iproute2 makes the >> current versions not work. >> >> As a stopgap, will look back in history and see what version of header >> files will at least get a working build. >> >> From there, need to replace how the conversion of .o to array works. >> Would prefer to use dlopen() to read the ELF file rather than expecting >> developers to hack together their own tools. >> >> Not sure how much effort is really needed here. This is only being >> used for the case of rte_flow with multiq RSS. Probably, no one ever >> used it. >> > > Should we remove the file, instead of fixing '__rte_packed'? > +Long, and af_xdp maintainers, @Long, do you know if this bfp code is still in use somewhere, if so is the user interested in fixing/maintaining the code? @Ciara, @Qi, do you see any benefit to keep/extend this kind of bfp file usage? Do you think is this something to invest more?