From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2C92A0C43; Fri, 22 Oct 2021 11:01:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E5C241103; Fri, 22 Oct 2021 11:01:33 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 37C884069D for ; Fri, 22 Oct 2021 11:01:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="228029276" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="228029276" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 02:01:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="595481056" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 22 Oct 2021 02:01:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 02:01:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 02:01:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 02:01:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2UmJuQkaMSDejn+X1JU+QvLOt/B4PsBy/770CRsWwzekFWkreOVckuZI4dg9FNJCy3BRP5d6DWerO2C+43UNnO4M3ePulhy7Pzfe7JcMwB2IapRKn/WT9amBIXUYgVc13wPnxLYu14zs+MI3gPE/aDA3T8ii5xOun7hE0xP/8j2UEDKUy+ccKHB2ZHJKvbBoLWwuS0nWfIlKbRqoR2R2YMsWEvakqz5PqU+dqoG1tNKdch8TkOfaA7svwjow87jTff46v3l7/kgvDjMIS+8H6lsiLfeqmgapJSTUkMiHV1AOWgBbd0tF3UXTmR5WfKxJ4fP5CBQI4UWgm2L2Jdp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6bsE8p++Mb0FXzAWSsVkCniPBGFrwfPEsUdY9sYiPY=; b=d/eSXCOietFU9hznDfLXMLnJZ53Psu8a6StsHoCTpJB7mD5beKvYir3aOvGuBWBSgSF73jAQ4IObn9zmsTmNV6uyyxRRz9YegyTrmUHkNXJhTMXJW0uWu07glOdpabMM3AAE/o2IwJ0n4T4dVn1LURlGNXReFxoXi8YREAC1VHsm5rpLmLkkTOcDzwwzaZFHqiaFIL2cS/4WMacWMnlew3R6/q1W457un9R4VKCW48B9obesO+5dHRKKHe4xNifXOUvG/42ZI9/7xsCX2NaKuqsB/bYC0HxnoDSQSKmPvCQapk1vEyvNOVYaus6t3HY94e7AHs5dQR5DsY6gQDVMiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6bsE8p++Mb0FXzAWSsVkCniPBGFrwfPEsUdY9sYiPY=; b=m0xA6VTphotTpNkj2v7j7x+7TwDn9FxIbWJaKhwQcpDYOAh6CxZwbgOBmj2h+FhIOfmmLtW0+JRpwvmPLos9M2TR1t0e2y1cit1amUnRK2HlHL1cEKlVTWyDtmU8y7DYj3/5c0rgqUYcFb8RIBlHaQNST/USyTPllb1Wkvdkvfk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4966.namprd11.prod.outlook.com (2603:10b6:510:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct 2021 09:01:28 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 09:01:28 +0000 Message-ID: <909815e4-2eb3-5c11-7f77-314cc3e02ccd@intel.com> Date: Fri, 22 Oct 2021 10:01:22 +0100 Content-Language: en-US To: "Li, Miao" , "dev@dpdk.org" , "Hunt, David" CC: "Xia, Chenbo" , "maxime.coquelin@redhat.com" , "Burakov, Anatoly" References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-5-miao.li@intel.com> <6adee6a3-2b20-a7cd-761a-4e9662d430ee@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P250CA0017.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P250CA0017.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 22 Oct 2021 09:01:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: acc6a887-2308-4a0c-ba97-08d9953a88d0 X-MS-TrafficTypeDiagnostic: PH0PR11MB4966: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b1+OHIOEczaJTE07Oou6v2NQ//FDsmvWM3ka3pzcmuBG1+aLhygMwdmrxS6oHswiu736tnh6ZyFbfX9AXwYZQkcHPuzBfscWlO/o90rOBOi2+qgdjPlfUNOE8RcWZWqul0ddf9hAMPRfqwi/tErGoXmH5hiDWejWzy3HdBXf1C8+oHZrTH4xLz8x9gbqd/dpqdSkn/65mUQh7mVGIEmwp/sSSbHADHsSDiTFjKpLqkThhACm4Z+TnyRnl/XcJMrInt2wm/ZsPwMS6tWtAolbQiLqaWOwk0tG9UqZ006HhTWG15upxtoH5NGwuSRc9wzGPIQg31QqwuXSK0ytxOMqIPcbaOLVo9JiQGWKkhVcSkcOqtDMVx1fR+0PzmcziRBPlsccj90M25pZQQsLGh1E0rO/qn9w0+XKf3wT5iyRt9IWHCEXOiNPwpyDFyGreGvB2GmfFIJpDmQIxMeZFZ68U+A4zCV/Zpl+R6q3bKJRVM9zDBhxjQC2ENcvL/UI9V/ac3/SBUY2PD+rHaL7Q1k1CWLczmI1agesJRdZuIKXpZcKamtPm5Trrhb7csA0i+IYWftXGiASz61DwGqT++dTV8irzhonO155CSWRyUrGfMSoBJyxMBiVbkNIzlhqiR8F///XNeNkOKpPESxzG30ATHuVD6YGFWKLYOM0WN2E+johWytbWQ4kruULC0b/Z1dEjjS3etfWjXX1w3gQEeD/gg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(66556008)(66946007)(316002)(8676002)(6486002)(2906002)(4326008)(2616005)(956004)(8936002)(6666004)(44832011)(186003)(107886003)(16576012)(5660300002)(53546011)(110136005)(54906003)(26005)(508600001)(6636002)(31686004)(31696002)(82960400001)(38100700002)(83380400001)(86362001)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFduRzhyOGh0V0tIZjhkZUIxK20yTS9zbGdTT3lkeUxpY1RpNWlMaTRrYk1z?= =?utf-8?B?RDQxb1ZscDdpbGtuN0llSlloRVQrTU1KV0RGcWRtTEdWRGtiNzFXOG04b01I?= =?utf-8?B?NXV6eUJXU3JjQ0JsYkwvQkJvTDhjcVBMdnE1TmlqaU82SWlUaXBCbkdyc0Jy?= =?utf-8?B?ZWNRd1BzTWFvNjdsNXVNNjlFN21ZTXdsTmJEcnh6a1NqOCtrWEs1QzFTd3ZZ?= =?utf-8?B?UWc2QWVvdzlUMnlhclIwUjFTN1F2SU1Tb3Ayb01BTU5Qb3BCT3NnRE16NldX?= =?utf-8?B?WGUyRjhQVURyc1hiQnhEZFJtKzJmb09WVnZHeUpGdHY1L2hjVDBFbnVKbEkx?= =?utf-8?B?VjBNVVFCbU0wekNPVEd2NmVhc09VZXJ0ME9hVURqeEJDdUZyaE1nMmJzOWZC?= =?utf-8?B?aFc2S3FoSURLOVBiKzlqY1JnRWRUTUFvWktJRTRpaDJWMmxhTVBhbkVSNEYz?= =?utf-8?B?YndENUVpRDdsRUF5UUxkV0tpMExnSmZaNCs0V2orYlBTODBnakduckZBQ3o2?= =?utf-8?B?elFIdkR2eGZWbFpCTFlVelgyMG5pem5iRy9hRWxlaVhnY3UxVlNsY3FTS0xS?= =?utf-8?B?VUlKYmpPUTF1azBTUHE3S1dLaWtXR01UT2NWQWFFNnk2cEdVcjAvTUpXSzJP?= =?utf-8?B?U3ZCMG9Iem5kMC8xQXlWU1NvMlZjc0lJSnJieDN0NTYvUFZsUmdCWWhrQk5R?= =?utf-8?B?c3QvUFFzUWM0MWZMU1NiU21KV0UvUkw2aUZuSGUxYUFQcm1RalRjWnFkMnJZ?= =?utf-8?B?WjM1dzBjMkVYRmJ3YlJEQ3ZML3A5cFk0aXhFbDJjOHdjL0x1aWE1ckdkVkJV?= =?utf-8?B?WWk2aXA0cjA4N1pGRjM2UWhuOWx6L3FEK1FGdHF1MzlPWVE3WlRMWFNFbWpO?= =?utf-8?B?OXBpR3BwTWJxUG52ck5HSXdkR21lWEVRM0lJV2JwSjYrdmJHemVxRi9qRWRj?= =?utf-8?B?QTJ1VlVkL0tuZStWL0hzV0ZKb3NjOGFyYVZJZlUraWVEYzR4cTVnL09yTkFM?= =?utf-8?B?YXIwWm1kZUltUUFDd0ZGNFJ3L1Qva2c1YnpKWlBuYURaS3JoemFTajRPTnU5?= =?utf-8?B?WDg4YUJWRXBnSzM0N0JNQmZaL2NySDNmb1RGakkyWS9FNC9rM2pwVzZrOXBO?= =?utf-8?B?RDdwRUlOZXVQRHNwWkZmM2xrVE9nU013eE9RNjBOK2MyRXZNZ2p6VWRUUG5U?= =?utf-8?B?UkpPaHhyU0x5Ly9sUGpNNU9pMTZlakUzYSsyUyt3Tk5qZEIvRHpNL1YwQWlw?= =?utf-8?B?UHJkYTRDbVhBU3JtRDhvN0hINWJ6Sm9QT0pkNHA3eUY0NENIRi9HYSsxcGNW?= =?utf-8?B?RHJ1UytmbkU4ZmZTVWxSUldrc2hnN20rRWFJNTJ5aEFGL1BIeTl2ZkNHM0p6?= =?utf-8?B?UW9FRm0xM0w4MGNIWnQ4NmJPbVVaWDV2U2ZoQk9EZG1jdmVwTXRDcHRLeXlM?= =?utf-8?B?OW1vcjhBZVU2cDFDaU1CTDlVS3FyOXVjUm5EbDliZm9vcnhHeVFpNGh1R093?= =?utf-8?B?RmppR1BPTWUyUSsyd1BMa2J5dUZVcDVubkFzS3AzZ0NJekFDYzYvd0EzczBs?= =?utf-8?B?YVFhVEF0NE9lbUZLeCtCOExSMEkwMWlUSUI1RFlUTU1IVVZ6akdWUUdBMjNF?= =?utf-8?B?KytsRlJUakw5MXVmbVZsMGFRNmZSZjd2a2JKV3NVZUJNYmVTYXVFTDUwQWUr?= =?utf-8?B?cmxWRXN4WkY2V3hBSStmSTNPSE5jdHp5cE9URWhtVkNxa0Vhd1dnRld1YmV6?= =?utf-8?B?d0xuZFJ5OTlXY1RxU0NTb2g1QzJIdDZIU0F1RTU5VFVIa1M3bzlhVzhYNWZ6?= =?utf-8?B?TXhUMXFyRU02TUpPd3RrT0t0QTFUbGRmVEdiRWx3TEE5b3ZHc1VCNFdoWGZw?= =?utf-8?B?Tzhnc1hka2x2c2FxOUw2Q3BHeVFNY0VwelVsa2JwYW5DL2pnUWp1eUR6bDA4?= =?utf-8?Q?6bayBRwG2gRoxITDCNFZy0P794RZfelS?= X-MS-Exchange-CrossTenant-Network-Message-Id: acc6a887-2308-4a0c-ba97-08d9953a88d0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 09:01:28.8087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4966 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 9:20 AM, Li, Miao wrote: > Hi, > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Friday, October 22, 2021 12:48 AM >> To: Li, Miao ; dev@dpdk.org; Hunt, David >> >> Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; >> Burakov, Anatoly >> Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped >> >> On 10/18/2021 3:16 PM, Miao Li wrote: >>> Since some vdevs like virtio and vhost do not support rxq_info_get and >>> queue state inquiry, the error return value -ENOTSUP need to be ignored >>> when queue_stopped cannot get rx queue information and rx queue state. >>> This patch changes the return value of queue_stopped when >>> rte_eth_rx_queue_info_get return -ENOTSUP to support vdevs which cannot >>> provide rx queue information and rx queue state enable power management. >>> >> >> Don't we want to backport this patch? In case later a patch in the main >> repo relies on this return type and that needs to be merged to LTS... >> >> Also need to clarify if this is a fix or not. > > Yes, it is a fix. I will backport this patch to LTS in the next version. > If so can you please update the Fixes and stable tags? This way it will be part of backporting process. > Thanks, > Miao > >> >>> Signed-off-by: Miao Li >>> Acked-by: Anatoly Burakov >>> Reviewed-by: Chenbo Xia >> >> power library maintainer ack/review is missing. >> >>> --- >>> lib/power/rte_power_pmd_mgmt.c | 9 +++++++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/lib/power/rte_power_pmd_mgmt.c >> b/lib/power/rte_power_pmd_mgmt.c >>> index 0ce40f0875..39a2b4cd23 100644 >>> --- a/lib/power/rte_power_pmd_mgmt.c >>> +++ b/lib/power/rte_power_pmd_mgmt.c >>> @@ -382,8 +382,13 @@ queue_stopped(const uint16_t port_id, const >> uint16_t queue_id) >>> { >>> struct rte_eth_rxq_info qinfo; >>> >>> - if (rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo) < 0) >>> - return -1; >>> + int ret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo); >>> + if (ret < 0) { >>> + if (ret == -ENOTSUP) >>> + return 1; >>> + else >>> + return -1; >>> + } >>> >>> return qinfo.queue_state == RTE_ETH_QUEUE_STATE_STOPPED; >>> } >>> >