From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CCBD42546; Fri, 8 Sep 2023 11:28:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F9C040285; Fri, 8 Sep 2023 11:28:14 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 6B47940042 for <dev@dpdk.org>; Fri, 8 Sep 2023 11:28:13 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RhrK43YqsztRrF; Fri, 8 Sep 2023 17:24:08 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 8 Sep 2023 17:28:09 +0800 Message-ID: <90d47caa-5e45-67c2-a2b8-05ac57bdb618@huawei.com> Date: Fri, 8 Sep 2023 17:28:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm To: Stephen Hemminger <stephen@networkplumber.org> CC: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <liudongdong3@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230826074607.16771-1-haijie1@huawei.com> <20230826074607.16771-2-haijie1@huawei.com> <20230906081017.5d490c53@hermes.local> From: Jie Hai <haijie1@huawei.com> In-Reply-To: <20230906081017.5d490c53@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi, Stephen Hemminger On 2023/9/6 23:10, Stephen Hemminger wrote: > On Sat, 26 Aug 2023 15:46:03 +0800 > Jie Hai <haijie1@huawei.com> wrote: > >> Currently, rte_eth_rss_conf supports configuring and querying >> rss hash functions, rss key and it's length, but not rss hash >> algorithm. >> >> The structure ``rte_eth_rss_conf`` is extended by adding a new >> field "func". This represents the RSS algorithms to apply. The >> following API is affected: >> - rte_eth_dev_configure >> - rte_eth_dev_rss_hash_update >> - rte_eth_dev_rss_hash_conf_get >> >> If the value of "func" used for configuration is a gibberish >> value, report the error and return. Do the same for >> rte_eth_dev_rss_hash_update and rte_eth_dev_configure. >> >> To check whether the drivers report the "func" field, it is set >> to default value before querying. >> >> Signed-off-by: Jie Hai <haijie1@huawei.com> >> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com> > > This is unannounced API/ABI change. Thanks for pointing that. I'm sorry I didn't pay attention to this before. What should I do with this set of patches? Is it feasible to send annouce now? > > . Thanks, Jie Hai