From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDF42A0350; Fri, 26 Jun 2020 13:16:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6055C1BED6; Fri, 26 Jun 2020 13:16:22 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 608F41BED2 for ; Fri, 26 Jun 2020 13:16:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593170180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k+rgVI6GCrqJk/HjsD17/K61XpObejeFXIIR7XhZdf8=; b=Ye6d/7FuJ8VwEFygdfPzgUjV3HKTXSf11ZMTZmtxDPCbJeLI28ruii0CflOt7LVKA89H9e 3lfGK6GQEW+Qna78JV72cl3y3hkJ9h+ESSIz6u/o1r83MgdliHDW/oWS4bymeF91GzKr/s xt+vAQlaz2Nruo2H+1NRbyYzt/Ijd74= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154--4CngZ5NORez2gKbV7oO-Q-1; Fri, 26 Jun 2020 07:16:19 -0400 X-MC-Unique: -4CngZ5NORez2gKbV7oO-Q-1 Received: by mail-wm1-f69.google.com with SMTP id b13so8358600wme.9 for ; Fri, 26 Jun 2020 04:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+rgVI6GCrqJk/HjsD17/K61XpObejeFXIIR7XhZdf8=; b=l8gErIfXfwy57a6PIUh/6uOm8F2ygEvFBp5eQndwxWh7NC9gScXpcWW3SmNG2huj1s vCwyAZdqAcaAmuadGm/VRB0iLEyE7Bo64vvAruPVuc1FUXl686z305BwXNU9kttkH9Vn squ4YnJ5QpXqajvi5jfvsvNvQfpTXW1dPMGx/btGmVNO8ZdsJRxHYLEGbYk1uzzVQpZ4 FA7eopjHZdISL3USeNGUTxTPoxyWVq6sEPCKW/nojZy0Xp2DV82JP60bRSTHntwCABUm M7dnAmKaHvG2asQTMDbuIaoaiqyKaIeDBBYU6bpxQ++4KimyXUakSaOtIqjMyezYtMjb uD4w== X-Gm-Message-State: AOAM530yOC+zdyT+4KH2QF5rNHBLfSH5FCaCNmZVAlRL8GuPRudgayL/ y3iWpXRAekwrOBLQuQnR8Mi4mlD+PyOaJOFiSxobu9ueGuLN7BtoYmZ4NU436U64mNBF3skDz0j 3smg= X-Received: by 2002:a5d:4649:: with SMTP id j9mr3064218wrs.270.1593170177725; Fri, 26 Jun 2020 04:16:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypzaewzgkOz6SKyUouFeJz0D28oC2AHq0Afij8ieLKJJjy1N95FXzhYfoxDY5OFpVoDJ07ZA== X-Received: by 2002:a5d:4649:: with SMTP id j9mr3064206wrs.270.1593170177536; Fri, 26 Jun 2020 04:16:17 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([92.176.159.3]) by smtp.gmail.com with ESMTPSA id l190sm16570157wml.12.2020.06.26.04.16.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jun 2020 04:16:16 -0700 (PDT) To: Maxime Coquelin , matan@mellanox.com, xiao.w.wang@intel.com, zhihong.wang@intel.com, chenbo.xia@intel.com, david.marchand@redhat.com, viacheslavo@mellanox.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, grive@u256.net, dev@dpdk.org References: <20200624122701.1369327-1-maxime.coquelin@redhat.com> <20200624122701.1369327-17-maxime.coquelin@redhat.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <91006e55-f81c-a337-0d1c-5323271bb4d8@redhat.com> Date: Fri, 26 Jun 2020 13:16:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200624122701.1369327-17-maxime.coquelin@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 13/14] vhost: remove vDPA device count API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/24/20 2:27 PM, Maxime Coquelin wrote: > This API is no more useful, this patch removes it. > > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/rte_vdpa.h | 13 ------------- > lib/librte_vhost/rte_vhost_version.map | 1 - > lib/librte_vhost/vdpa.c | 9 --------- > 3 files changed, 23 deletions(-) > > diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h > index eda56dd556..776ed67c16 100644 > --- a/lib/librte_vhost/rte_vdpa.h > +++ b/lib/librte_vhost/rte_vdpa.h > @@ -175,19 +175,6 @@ __rte_experimental > struct rte_device * > rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev); > > -/** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > - * Get current available vdpa device number > - * > - * @return > - * available vdpa device number > - */ > -__rte_experimental > -int > -rte_vdpa_get_device_num(void); > - > /** > * @warning > * @b EXPERIMENTAL: this API may change without prior notice > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > index 7a919102cf..299576a494 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -36,7 +36,6 @@ EXPERIMENTAL { > rte_vdpa_register_device; > rte_vdpa_unregister_device; > rte_vdpa_find_device_id; > - rte_vdpa_get_device_num; > rte_vdpa_get_stats_names; > rte_vdpa_get_stats; > rte_vdpa_reset_stats; > diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c > index d7f9839eb2..864770d506 100644 > --- a/lib/librte_vhost/vdpa.c > +++ b/lib/librte_vhost/vdpa.c > @@ -25,7 +25,6 @@ TAILQ_HEAD(vdpa_device_list, rte_vdpa_device); > static struct vdpa_device_list vdpa_device_list = > TAILQ_HEAD_INITIALIZER(vdpa_device_list); > static rte_spinlock_t vdpa_device_list_lock = RTE_SPINLOCK_INITIALIZER; > -static uint32_t vdpa_device_num; > > > /* Unsafe, needs to be called with vdpa_device_list_lock held */ > @@ -92,7 +91,6 @@ rte_vdpa_register_device(struct rte_device *rte_dev, > dev->device = rte_dev; > dev->ops = ops; > TAILQ_INSERT_TAIL(&vdpa_device_list, dev, next); > - vdpa_device_num++; > out_unlock: > rte_spinlock_unlock(&vdpa_device_list_lock); > > @@ -112,7 +110,6 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev) > > TAILQ_REMOVE(&vdpa_device_list, dev, next); > rte_free(dev); > - vdpa_device_num--; > ret = 0; > break; > } > @@ -121,12 +118,6 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev) > return ret; > } > > -int > -rte_vdpa_get_device_num(void) > -{ > - return vdpa_device_num; > -} > - > int > rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m) > { > Acked-by: Adrián Moreno -- Adrián Moreno